[RC2] Still BSOD on saving the game

[AIAndy]

The blue screen described here still always happens in RC2, making it impossible to use that version for me (beta 43 works fine):
http://forums.te4.org/viewtopic.php?f=42&t=35657

[cultist]

also did for me.. skipping on it for now =P

[darkgod]

Could you run the game with gdb please ? http://te4.org/wiki/tome4-running-tome-gdb

[VoxPVoxD]

Could you run the game with gdb please ? http://te4.org/wiki/tome4-running-tome-gdb

I did this and set logging on but the only thing the log had in it when my computer locked up was this

Starting program: C:\Program Files\Tales of Maj'Eyal\t-engine.exe
[New Thread 980.0x7ac]
[New Thread 980.0x19c]
[New Thread 980.0x828]
[New Thread 980.0x6b4]
[New Thread 980.0x6a8]
[New Thread 980.0xf3c]
[New Thread 980.0x7b0]
[New Thread 980.0x774]
[New Thread 980.0xbb0]
[New Thread 980.0xa1c]
[New Thread 980.0x8c8]

I'll attach my te4_log just in case. I've tried with every RC (and also the new safe mode!) and this problem still recurs.

[darkgod]

Ah yes damnit .. hum can you run the game with the option --flush-stdout and give me an other log ?

[VoxPVoxD]

Sure thing!

[cultist]

Downloaded RC3 to see if it was fixed, still bsod crash on entering main map (this time two seconds after autosave finished and the other things were loading)
Don't have any logs tho

[AIAndy]

Version 1.0 still has the same behavior with BSOD on any attempt to save the game. This has been the case since RC1. Beta 43 works fine. Something causes the savefilepipe thread to fail and be dead when it is needed as seen in VoxPVoxD's log.
Is there any way to cause ToME to attempt writing the savegame to a different harddisk?

[AIAndy]

I have messed around with the savefilepipe code and removing the taking of a screenshot in there fixes the bluescreen. So the issue is somewhere in the code called by takeScreenshot in Game.lua.

[AIAndy]

I suspect that the change in the libpng used from beta 43 to RC1 causes the BSOD.

[gulbanana]

more specifically, the crash occurs during sdl_get_png_screenshot in core_lua.c. here's a build with that function commented out and returning 0:
http://forthehor.de/files/t-engine.zip

this does not have the BSOD, although of course savefiles don't have screenshots. that code hasn't changed from revision 5833 to 6337, so libpng is indeed a candidate for the cause of the bug.

[darkgod]

Ahh interresting
AIAndy can you try it please ?

[VoxPVoxD]

I can confirm that this fix solves my BSOD issue.

[AIAndy]

Ahh interresting
AIAndy can you try it please ?

Yes, as expected this works similar to commenting out the screenshot taking for savegames in the Lua code.

[AIAndy]

Version 1.0.1 still reliably causes a bluescreen when it tries to take a screenshot for saving.
After playing 1.0.0 fine with the exe from this thread, could I ask someone with a working T-Engine build environment compile a version of the 1.0.1 exe with the code for taking screenshots commented out?