[v1.0.4-1.0.5] Enhanced Object Compare

[Chronosplit]

indeed, for some reason my game is not updating addons :

thanks Zizzo

It's been the same deal with mine for a few versions. Not sure what's up, but it only seems to happen with certain addons. DLC and a few others will update, the others won't.

[Zizzo]

Having finally gotten an Archmage far enough to take Occult Technmancy (loosely based on knifebutton's guide, but my first few Skeletons died early, so I'm trying a Higher), I've discovered yet another thing that really ought to be in the comparison candidate list: the steamsaw being used with Metaphasic Spin, if we're <ctrl>-comparing a steamsaw. That's added in v3h.4, just pushed out.

[Zizzo]

I keep tripping over these. v3h.5 fixes <ctrl>-comparison of heroism infusions. We Apologize for the Inconvenience.™

[Zizzo]

v3i adds support for a few changed runes in 1.7. (And this is one of the addons where I expect my attempt at using the engine's new localization support to break the worst; We Apologize for the Inconvenience™ ).

[Laughmore]

Hi!

Pressing CTRL on a blink rune in inventory or in a store while wearing one causes:

Ogre Reaver at Store

ERROR:
Game version: tome-1.7.0
Addons: compare-1.7.0[X]

Game version (character creation): tome-1.7.0
Lua Error: /hooks/compare/load.lua:242: attempt to call field 'getRange' (a nil value)
At [C]:-1 getRange
At /hooks/compare/load.lua:242 info_cmp
At /mod/addons/compare/superload/mod/class/Object.lua:114 getDesc
At /mod/dialogs/ShowStore.lua:145 on_select
At /mod/dialogs/ShowStore.lua:189 select
At /mod/dialogs/ShowStore.lua:94 on_select
At /engine/ui/ListColumns.lua:437 onSelect
At /engine/ui/ListColumns.lua:658 display
At /engine/ui/Inventory.lua:308 display
At /engine/ui/Dialog.lua:965 toScreen
At /engine/Game.lua:187 display
At /mod/class/Game.lua:1940

Or

Wight White Monk (with my usual addons enabled plus a few more) checking a newly picked up blink rune.

ERROR:
Game version: tome-1.7.0
Addons: convenient-digging-1.5.5[X!], items-vault-1.7.0[O], race-undeadpack-1.6.0[X!], whitemonk-1.7.0[X], tooltip_away-1.7.0[X], turn_separators_v2-1.6.0[X!], easy_map_v2-1.6.0[X!], PlenumTooltipCustom-1.7.0[X], ashes-urhrok-1.7.0[O], genuine-veteran-1.6.6[X!], invorder-1.7.0[X], cults-1.6.0[O!], orcs-1.7.0[O], possessors-1.7.0[O], compare-1.7.0[X]

Game version (character creation): tome-1.7.0
Lua Error: /hooks/compare/load.lua:242: attempt to call field 'getRange' (a nil value)
At [C]:-1 getRange
At /hooks/compare/load.lua:242 info_cmp
At /mod/addons/compare/superload/mod/class/Object.lua:114 getDesc
At /mod/dialogs/ShowEquipInven.lua:55 on_select
At /mod/dialogs/ShowEquipInven.lua:236 select
At /mod/dialogs/ShowEquipInven.lua:166 super_any_key
At .../addons/compare/superload/mod/dialogs/ShowEquipInven.lua:35 any_key
At /engine/KeyBind.lua:222 receiveKey
At /engine/ui/Dialog.lua:807 keyEvent
At /engine/ui/Dialog.lua:510

Shield and shatter afflictions runes worked as expected. Blink rune without wearing one did not trigger the error (of course, didn't trigger the comparison popup).

Regeneration, Healing, and wild infusions also did not trigger (checked on a Cornac warrior).

With older version of addon and ToME, I can't recall (I don't compare blink runes as much; so grain of salt).

[Zizzo]

Pressing CTRL on a blink rune in inventory or in a store while wearing one causes:

[sound F/X: source diving] Gah, blink runes must have changed between beta1 and the release, and I didn't notice. Should be fixed in v3i.1, just pushed out. We Apologize for the Inconvenience.™

[Laughmore]

Works with new version.

Many thanks!

[Zizzo]

Was trying out Erenion's new Mirrorbladde class, and I was lamenting my inability to <ctrl>-compare weapons in my inventory with my mirror twin's wielded weapons, as we currently support for golems, worms that walk and mecharachnids. Then it occurred to me: wny are we only checking specific sidekicks? Any party member with an accessible inventory is potentially a source of comparison candidates — and that would also future-proof us against any future DLC or addon that adds an equippable sidekick. That's implemented in v3j, just pushed out.

[Blackvision]

Not your addon's fault, but might be possible to fix it in there?

When comparing items, I've frequently found the negative 'red' colour overflows from one effect (that's removed in the switch) into the rest of the item's details (see example image with arrow indicating point of overflow).

Not sure if that's something you'd want to address here, but thought it worth mentioning.

https://ibb.co/L9b6bSg

Thanks, Blackvision.

[Zizzo]

When comparing items, I've frequently found the negative 'red' colour overflows from one effect (that's removed in the switch) into the rest of the item's details (see example image with arrow indicating point of overflow).

Yeah, that's certainly something I've seen before. [sound F/X: source diving] …urk. This is getting deep into the engine's text rendering code. (I talked some about the engine's color codes in Notes to Self's FAQs.) So for instance, the description for an arcing weapon runs, "#LIGHT_GREEN#25%%#LAST# chance for lightning to strike from the target to a second target dealing #VIOLET#%d#LAST# damage". Then the side-by-side comparison code wraps another #LIGHT_GREEN#…#LAST# around that. Problem is, AFAICT the engine only nests colors one layer deep, so the double #LAST# ends up leaving the outer #LIGHT_GREEN# stuck. Not sure how to fix that without major surgery to the rendering code.

In the meantime, pushing out v3j.1 to fix a small typo in the comparison text for inscriptions.

[Zizzo]

I swear, can't go two versions without tripping over one of these… v3j.2 fixes <ctrl>-comparing of shielding runes. We Apologize for the Inconvenience.™

[Zizzo]

The 1.7.5 release, as you probably know, changed the description of the Infusion: Heroism talent. Which, yet again, broke my <ctrl>-comparison handling of heroism infusions, because my inscription comparison handling has always depended heavily on matching the exact text of the inscription's talent description — so every time one of the inscription talents changes, we have to update this addon to match. Seriously, something like half my recent changes to this addon are syncing up with inscription talent description changes. That strategy may have worked at first, but it's turning out to be not really sustainable in the long run.

So in v4, just released, we're trying something different. Our new strategy is loosely based on the infrastructure that the levelup dialog uses to show a talent's description at your current talent level with extra change annotations showing how it would change if you put a point in the talent. Tweaking that to look more like the existing <ctrl>-comparison of regular equipment was tricky, but so far I've tested all the inscriptions that we supported before and they all seem to be working as expected. And if I've done this right, it should insulate us from future changes to the game's inscriptions, should work transparently with inscriptions added by other addons, and (if I'm really lucky) should even be transparent to internationalization.

This is a pretty big change, though, so I'm anticipating that I've broken something. As always, here is a good place to report any bugs you find.