ToME: the Tales of Maj'Eyal

Everything about ToME
It is currently Wed Sep 19, 2018 8:55 am

All times are UTC




Post new topic Reply to topic  [ 5 posts ] 
Author Message
 Post subject: git commits
PostPosted: Wed May 16, 2018 1:07 am 
Offline

Joined: Wed Jun 21, 2017 4:59 pm
Posts: 4
(Not that it likely matters, but the sister of the account holder is the one posting this message):

I am a Computer Science student and need to contribute to an open source project. Per my brother's suggestion I was looking at the possibility of making a small change to the Thought-Forms talent. Looking at the project documentation, the url for the git repository is provided, as is the fact that contributions are welcome. However, when I signed up for a gitlab account it seems that the account is separate from the ToME git repository, and I could not find any links for instructions on making actual contributions. Did I miss a forum post/wiki entry, or is it not currently publicly available?

Also, if not covered at the same source as the account information, what is best practices for making commits? Creating a new branch, or is there a public contribution branch?


Top
 Profile  
 
 Post subject: Re: git commits
PostPosted: Wed May 16, 2018 10:50 am 
Offline
Perspiring Physicist

Joined: Sun Sep 09, 2012 7:43 am
Posts: 5752
Not my area of expertise, but I have contributed to this game via the git repo, so...
Possibly you signed up for a GitLab account, instead of signing up for the ToME4 git account. And possibly DarkGod creates the accounts for people rather than allowing anyone to use the system.

Best practise is (I think):
First fork the main code for the game.
Clone the fork onto your local machine.
Then create a new branch for your changes.
Make your changes to the code in the branch and test them.
Once your changes are done, commit them and push them back to the server.
Then make a Merge Request for your branch back to the main branch, assign to DarkGod. Also email him explaining what the changes are and why.

Finally, you may find it helpful to hop on the IRC channel, as you can chat with many of the contributors there.

_________________
My feedback meter decays into coding. Give me feedback and I make mods.


Top
 Profile  
 
 Post subject: Re: git commits
PostPosted: Wed May 16, 2018 2:44 pm 
Offline

Joined: Wed Jun 21, 2017 4:59 pm
Posts: 4
Thanks for the reply, once her forum account is able to post I'll let her take over the conversation (if needed).

When I was going over the git repo with her, I did not see an option to create an account, so you're probably right. I wasn't sure about the fork step, since I've only worked with write access with git on private repos before.


Top
 Profile  
 
 Post subject: Re: git commits
PostPosted: Wed May 16, 2018 6:03 pm 
Offline

Joined: Wed May 16, 2018 12:48 am
Posts: 3
Thank you so much for your reply, HousePet! (This is fiske's sister, the one trying to contribute code.)

I think I did create just a regular GitLab account, rather than a specific ToME4 git account. Do you happen to remember how you created your account when you contributed? I can't seem to find any sort of "sign up/register" link.

Or do you think maybe I just need to email DarkGod and see if he'd be willing to send me an invite?

I'll also hit up the IRC channel as you suggested.

Again, thank you so much for taking the time to offer guidance to an open source newbie. :)


Top
 Profile  
 
 Post subject: Re: git commits
PostPosted: Thu May 17, 2018 8:08 pm 
Offline
Uruivellas

Joined: Fri Oct 10, 2014 4:00 pm
Posts: 872
When I started contributing to ToME, DarkGod created an account for me on GitLab. I would recommend contacting him on IRC or by email.


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 5 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group