ToME: the Tales of Maj'Eyal

Everything about ToME
It is currently Thu Oct 18, 2018 6:57 am

All times are UTC




Post new topic Reply to topic  [ 13 posts ] 
Author Message
PostPosted: Tue Apr 19, 2016 3:27 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
There are a handful of passive talents and prodigies that have triggered effects with a cooldown, as generally noted by the somewhat cryptic line "Note: this has a cooldown" in the talent description. Problem is, the effect's cooldown isn't actually displayed anywhere convenient (okay, technically you can drag the passive talent off the talents dialog into the hotkeys toolbar, but that has drawbacks).

Hence my new Passive Cooldowns addon, which displays the talents' effect cooldowns in the buffs area of the Minimalist UI. Specifically, it shows cooldowns from:
  • Born into Magic
  • Cauterize
  • Meteoric Crash
  • Unbreakable Will
  • Spell Feedback
  • Draconic Body
  • Bloodspring
  • Elemental Surge
(If I've missed any, let me know.)

If you're an addon developer and you have a talent or prodigy that would benefit from this addon, it's easy to hook into it — all you need to do is put the field 'passive_cooldown = true' in your talent definition.

[Now, the implementation is kind of hacky, alas, as there's no convenient hook to add anything to the buffs area, so I won't swear I've got this exactly right. I'm lucky I already wanted the cooldown trackers to be on the detrimental-effects side, or I'd have had to overload the entire method…]

[Technical info:]
Code:
Hooks:
  ToME:load [to add the passive_cooldown field to talents of interest]
Superload:
  mod.class.uiset.Minimalist:
    displayBuffs() [to add our cooldown indicators]
    buffOrientStep() [to remember where to add our cooldown indicators]

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Last edited by Zizzo on Tue Apr 19, 2016 3:30 am, edited 1 time in total.

Top
 Profile  
 
PostPosted: Tue Apr 19, 2016 3:29 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
Frequently Asked Questions:

Why not just drag the talent into the hotkeys toolbar?

Well, you could drag the talent off the Talents dialog onto the toolbar, but that has drawbacks:
  • It takes up valuable toolbar real estate and an otherwise usable hotkey.
  • It's less noticeable when the talent's effect goes into cooldown.
  • It's not done automatically, so you have to remember to do it each time you learn the talent with a character.
  • A lot of players don't even know you can do that.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Tue Apr 19, 2016 3:58 am 
Offline
Sher'Tul

Joined: Sun Jun 15, 2014 12:19 am
Posts: 1148
Location: Yeehaw, pardner
I suppose you could put Vitality up there.

_________________
A little bit of a starters guide written by yours truly here.


Top
 Profile  
 
PostPosted: Wed Apr 20, 2016 1:45 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
Micbran wrote:
I suppose you could put Vitality up there.

[sound F/X: source diving] Ah, sneaky trigger hiding in a talent method not named trigger(). :oops: :wink: In fact, now that I know what to look for, there are a lot of other talents I should have been covering. Here's what's added in v1a, just pushed out:
  • Vitality
  • Shieldsmaiden Aura
  • Hold the Ground
  • Pestilent Blight
  • Guardian Unity
  • Fold Fate
  • Fold Warp
  • Fold Gravity
We also cover some talents from Embers of Rage:
  • Uncertainty Principle
  • Improved Gestalt
  • Subcutaneous Metallisation
  • Pain Enhancement System
and Ashes of Urh'Rok:
  • Voracious Blade
  • Incinerating Blows
  • Grim Future
  • Burning Sacrifice

Also also, some tweaks to the debuff icon for the trigger cooldown: we add the "clock-sweep" fractional countdown indicator to make it look more like a hotkey toolbar icon, and we add an explanatory note to the tooltip that this is in fact a passive cooldown trigger.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Wed Jul 20, 2016 12:11 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
So I just discovered that Embers' Embedded Restoration Systems talent might actually be suitable for tracking by this addon: it's sustained rather than passive, but it does have a trigger with a cooldown while it's active (in fact, before the difference occurred to me, I was surprised not to see a cooldown tracker for it). I'm working on the necessary code changes to cover this talent; before I push that out as a new release, though, are there any other talents with similar behavior that I should be handling similarly?

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Sat Jul 23, 2016 10:16 pm 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
Well, no answer, so I'll go ahead and push out v1b with support for Embers' Embedded Restoration Systems. Note that this involves some internal rearragements to add support for showing trigger cooldowns for sustained talents; if you're an addon developer and you'd like this addon to show a trigger cooldown marker for your sustained (or passive) talents, I've added some instructions on how to set that up.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Wed Aug 03, 2016 1:37 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
v1c is mostly a compatibility release with ZOmnibus v15; it also adds a new game option "Passive cooldown trackers", to turn the trackers on or off [this is mostly for ZOmnibus users who want all the other parts of ZOmnibus but don't like this bit :( :wink: ]. If you have any characters using this addon together with ZOmnibus, you should upgrade both together, and future characters should only use one or the other (if you forget, the character creation dialog will warn you).

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Wed May 30, 2018 1:18 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
So it's been brought to my attention that Forbidden Cults adds some new talents that could benefit from a passive trigger cooldown tracker. So far I've found Fuel Pain, Inner Tentacles and Unravel Existence; any more I've missed before I push out a release to cover these?

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Thu May 31, 2018 3:12 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
Okay, no other takers, so that's going out as v1d.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Thu May 31, 2018 7:57 am 
Offline
Archmage

Joined: Thu Jan 12, 2012 9:09 pm
Posts: 320
Would Severed Threads from Chronophage be another one?


Top
 Profile  
 
PostPosted: Fri Jun 01, 2018 1:41 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
[I knew I should have waited longer for a response, but with that big honking bug in Store Wish List, I was kind of in a rush to push out a ZOmnibus release… :oops: We Apologize for the Inconvenience.™]

Velorien wrote:
Would Severed Threads from Chronophage be another one?

[sound F/X: source diving] …Well, the description certainly sounds like it has a trigger cooldown, and the talent does define a cooldown of 15 turns, but I can't find in the code where that cooldown is actually started. In your experience, does the talent behave as the description describes, as though it has a trigger cooldown? [Ideally, if you have an active character using this talent that has a free hotkey toolbar slot, you could temporarily drag the talent off the Talents dialog onto the toolbar, and it should show whether the talent is actually going into cooldown.]

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Fri Jun 01, 2018 6:09 am 
Offline
Archmage

Joined: Thu Jan 12, 2012 9:09 pm
Posts: 320
Unfortunately, I don't have anyone with Chronophage handy--it's a category I leave for late in my build and most of my characters don't make it that far.

Edit: Tried making a cultist in debug mode. You're right, there is no 15 turn cooldown. The ability doesn't have a cooldown indicator when placed on the toolbar, and can trigger multiple times in quick succession. I can only assume that it's a bug.


Top
 Profile  
 
PostPosted: Sat Jun 02, 2018 2:25 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1562
Location: A shallow water area south of Bree
Velorien wrote:
Edit: Tried making a cultist in debug mode. You're right, there is no 15 turn cooldown. The ability doesn't have a cooldown indicator when placed on the toolbar, and can trigger multiple times in quick succession. I can only assume that it's a bug.

Well, at least I didn't miss something obvious. *whew* :wink: Thanks for testing this. For now, then, we'll put Severed Threads on the TODO list and update the addon when that bug is fixed.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 13 posts ] 

All times are UTC


Who is online

Users browsing this forum: No registered users and 0 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group