Page 2 of 4
Re: [v1.0.1] Store Wish List
Posted: Mon Apr 22, 2013 12:17 pm
by kazak
Noel--so essentially the stores that also give other options, like talent unlocks or ring creation?
Re: [v1.0.1] Store Wish List
Posted: Mon Apr 22, 2013 2:27 pm
by jenx
jenx wrote:There are also special towns for yeeks, tws, anorithils, and dwarves.
Testing Yeek, there are no nil stores in Irkkk
Re: [v1.0.1] Store Wish List
Posted: Tue Apr 23, 2013 12:51 am
by Zizzo
kazak wrote:Noel--so essentially the stores that also give other options, like talent unlocks or ring creation?
[sound F/X: source diving] That's it! The store name isn't being propagated through the Chat dialog to where I can get to it. Crap crap crap...
[sound F/X: further source diving] Okay, it looks like all stores have an internal "common" name that gets used in cases like this (you can see this in-game with these stores; the chat dialog is titled something like, "Fancyname's Elaborately Described Eviscerators", while the store dialog is titled something like "weapon smith"). For v2b (just pushed out), we'll use the common name when the town-specific store name isn't available, which should prevent this problem. We Apologize for the Error.(TM)
Re: [v1.0.1] Store Wish List
Posted: Tue Apr 23, 2013 2:52 am
by Zizzo
Gah! Stupid, stupid, stupid... The new store highlighting code from v2 had a stupid initialization error that would crash on entering a store unless something else had already set up the common game.player.addon table for it (which it's
supposed to check for and set up itself if necessary...
[sound F/X: forehead repeatedly striking desk]). Pushing out v2c to fix this. We Apologize for the Inconvenience.(TM)

Re: [v1.0.1] Store Wish List
Posted: Tue Apr 23, 2013 10:17 pm
by jenx
Much better now, and I like the in-store shading. no bugs yet.
Re: [v1.0.1] Store Wish List
Posted: Thu Apr 25, 2013 10:37 am
by jenx
I"m getting a bad on message. is the md5 up to date?
Re: [v1.0.1] Store Wish List
Posted: Thu Apr 25, 2013 11:57 pm
by Zizzo
jenx wrote:I"m getting a bad on message. is the md5 up to date?
[tests] Hmm, so I see.
[checks wiki] Odd; the listed MD5 matches what I'm seeing in my log files.
[sound F/X: typing] Well, I've "updated" the addon, putting back in the exact same MD5, and it now registers as valid for me. Let me know if it still doesn't work for you.
Item details vs current stats, and other ideas
Posted: Sun May 05, 2013 2:02 am
by Noel
Are the item details in the wish list snapshotted when an item is added to the list, rather than being calculated against the current player stats/talents?
I put an iron helm onto my list before I got any Armour Training. Now, I've got a point in Armour Training, but the "Talent: Armour Training" in the wish list item description is still red. I was expecting it to have greened.
Oh, and I've found myself mindlessly hitting Control while on a wishlist item and wondering why it didn't compare the item with my current equipment...'twould be a nice enhancement.
And yet another idea -- with all the items I tend to get in my list, it'd be nice to have an "item type" column...and even nicer if the items could be sorted by any of the columns.
Boy, I'm hard to please, eh?

Re: Item details vs current stats, and other ideas
Posted: Sun May 05, 2013 9:41 pm
by Zizzo
Noel wrote:Are the item details in the wish list snapshotted when an item is added to the list, rather than being calculated against the current player stats/talents?
I put an iron helm onto my list before I got any Armour Training. Now, I've got a point in Armour Training, but the "Talent: Armour Training" in the wish list item description is still red. I was expecting it to have greened.
Oh, and I've found myself mindlessly hitting Control while on a wishlist item and wondering why it didn't compare the item with my current equipment...'twould be a nice enhancement.
Yeah, in an early development version, I tried keeping a reference to the store object itself in the wishlist, so that I could match them by reference equality; that didn't seem to persist across a save/restore, though, so I punted it and just kept copies of the name and description. Hmm, maybe a clone of the object? I'd have to dig around in the code a bit to see if I could make that work.
Noel wrote:And yet another idea -- with all the items I tend to get in my list, it'd be nice to have an "item type" column...and even nicer if the items could be sorted by any of the columns.
Now, sorting functionality would be fairly easy, I think. The addon doesn't currently remember item type; if I did the cloning thing, I suppose that would come along for free.
Problem is, if I make this change, I'd pretty much
have to clobber your existing wishlist; it'd just be too much of a format change. I could do something tricky with it, I suppose, like stick a copy of the list in your notes to self if you also have that addon installed. Or if anyone has any better ideas, I'm all ears.
Re: [v1.0.1] Store Wish List
Posted: Fri May 10, 2013 3:23 am
by Zizzo
Migrating to v1.0.3. Still investigating the feasibility of the changes described above (and still hoping for ideas on what to do with the old list besides clobbering it...).
Re: [v1.0.1] Store Wish List
Posted: Sat May 11, 2013 1:24 am
by Zizzo
Pushing out v2e with a
bugfix for transmo chest breakage across save/reload. We Apologize for the Inconvenience.(TM)

Re: [v1.0.1] Store Wish List
Posted: Thu May 16, 2013 1:51 am
by Zizzo
And after some work, I've pushing out v3 with the features requested by Noel
above:
- Object descriptions are recomputed as needed, so they will adjust to changes in your character. If you now have the stats and talent levels you need to wear that armor, the description will now say so.
- You can compare a wish list item to what you're currently wearing with the <Ctrl> key, like in inventory dialogs.
- On the main wish list dialog, you can now sort the list by type/subtype, town, store or price.
Now, as I noted
above, this involves a major change to the wisl list data format, so I'll repeat my
WARNING from above that
this will clobber your wish list. If you're also using Notes to Self (or if you're getting this addon via ZOmnibus, which includes both), you'll be given the option to record notes about your wish list in your notes list before the wish list is cleared, which you can use as reference to reconstruct your wish list. We Apologize for the Inconvenience.(TM)
Re: [v1.0.1] Store Wish List
Posted: Tue May 21, 2013 11:14 pm
by Noel
Slick work, Zizzo!
I tried the 1.0.4 betas for a bit without your Zomnibus, and realized how amazingly much I rely on it. Virtual beverage of your choice, on me!
Re: [v1.0.1] Store Wish List
Posted: Wed May 22, 2013 1:50 am
by Zizzo
Noel wrote:Slick work, Zizzo!
I tried the 1.0.4 betas for a bit without your Zomnibus, and realized how amazingly much I rely on it. Virtual beverage of your choice, on me!
*blush* [bows] I can sympathize; frequently when testing an individual addon, I'll disable all the others, and then sometimes I'll go, "Gah! Where's all my stuff?! ...Oh, right, I turned off Inventory Show All Tabs."
And don't worry, v1.0.4 ZOmnibus is next on my list after migrating this addon.
Re: [v1.0.1-1,0.4] Store Wish List
Posted: Wed May 22, 2013 2:19 am
by Noel
Zizzo wrote:
And don't worry, v1.0.4 ZOmnibus is next on my list after migrating this addon.
That might not be needed. I'm running ToME 1.0.4 with Zomnibus 1.0.3, with no apparent bugs, and it sure looks like it's validated. The "link item" option is in the inventory, and chars are getting saved to the vault:
http://www.te4.org/characters/1768/tome ... 0d160da32a
ISTR darkgod posting something about cross-version addon validation?