[1.7.3] Dart Launcher mastery change request

Where bugs go to lie down and rest

Moderator: Moderator

Post Reply
Message
Author
trungaczne
Higher
Posts: 69
Joined: Mon Aug 03, 2020 8:48 pm

[1.7.3] Dart Launcher mastery change request

#1 Post by trungaczne »

Dark Launcher Mastery has a clause that says it bypasses sleep immunity. However it still doesn't affect unliving enemies. If my memory & code reading are correct, the only enemies with sleep immunities are a few undead enemies, so this clause isn't helpful and could be misleading people into thinking it'd work on unliving enemies. I suggest either

1. Make it bypass unliving status. This doesn't seem to be egregious since Dart Launcher mastery is underpowered anyway, although it is a small nerf to playable undead races.
2. Remove this clause from the description & the code since it's useless.

Tradewind_Rider
Thalore
Posts: 182
Joined: Sat Oct 05, 2019 8:55 pm

Re: [1.7.3] Dart Launcher mastery change request

#2 Post by Tradewind_Rider »

There are no sleep immune enemies in the game.

Sleep immunity is granted, when the actor is waking up from a sleep effect,
and gaining the insomnia effect.

But there is a statement in the talents description:

"Your darts ignore poison and sleep immunity" - in the Mastery talent

However, in the code it looks like this:

if target:checkClassification("living") and (self:knowTalent(self.T_DART_LAUNCHER_MASTERY) or target:canBe("sleep") and target:canBe("poison")) then


I think, a () is missing here, and this makes the Mastery do not bypass poison immunity.
It should be look like this:

if target:checkClassification("living") and (self:knowTalent(self.T_DART_LAUNCHER_MASTERY) or (target:canBe("sleep") and target:canBe("poison"))) then

nsrr
Sher'Tul
Posts: 1126
Joined: Mon Sep 21, 2015 8:45 pm
Location: Middle of Nowhere

Re: [1.7.3] Dart Launcher mastery change request

#3 Post by nsrr »

Fixed the bug with the missing parentheses. I didn't change the undead check. Now that it will actually bypass poison immunity, I think it's a decent enough perk along with the 20-40% slow it applies upon waking. Someone else might consider it worth changing, though; you could re-post the proposition on the Ideas board.

Fix MR: https://git.net-core.org/tome/t-engine4 ... quests/755

Post Reply