One-line change to a talent?

[visage]

It's been years since I last touched modding ToME and I'm just a bit rusty.

I'm pondering making a one-line tweak to a talent (adding "sustain_hate = 0" to Savage Hunter), and I'm wondering if there's a more elegant way to do that than copying the entire talent definition and adding that one line.

Looking at the definition of newTalent(t):

Code: Select all

	table.insert(self.talents_types_def[t.type[1]].talents, t)

Am I correct in thinking that I could access the instantiated talent and update its entry, instead? If so, what would be the Right Way(TM) to do that?

[Razakai]

Code: Select all

Talents.talents_def.T_BLOCK.cooldown = function(self, t)
		return 5
	end

In talents.lua is how I changed block CD in an old addon. Same concept here.

[Zizzo]

Am I correct in thinking that I could access the instantiated talent and update its entry, instead? If so, what would be the Right Way(TM) to do that?

Well, I hope it's not the wrong way, because that's how a lot of my addons have been doing surgery on talents. [sound F/X: source diving] Passive Cooldowns is probably closest to your use case, if you want some code to look at.

But yeah, for what you describe, I'd probably put something like the following in hooks/load.lua:

Code: Select all

class:bindHook('ToME:load', function(self, data)
  local Talents = require 'engine.interface.ActorTalents'
  local TD = Talents.talents_def
  TD.T_SAVAGE_HUNTER.sustain_hate = 0
end)

[visage]

Thanks to both of you!

But yeah, for what you describe, I'd probably put something like the following in hooks/load.lua:

That was well-timed. I'd just settled in to figure out how to make it work when I checked the forums and saw this response... which worked perfectly.

[visage]

Ok, another question.

I've built a simple addon that aims to shorten the game a bit by stripping out floors from a bunch of zones. The thing I'm wondering about is modifying escort allocation to account for the changed number of floors. It looks like I need to iterate through all of the race definitions and alter random_escort_possibilities for each. Is there an elegant way to do that?

[HousePet]

Since you'd have to loop over the race definitions and the subrace definitions to catch them all, and they are all identical anyway, I would consider just putting a Superload wrapper on mod\class\Player\onBirth() and redoing the Escort location assignment with your own revised restrictions after the current code has ran.
(Bonus points if you can stop an East start from being able to get an escort on floor 1 of their "tier1.1" dungeon.)

[Zizzo]

Since you'd have to loop over the race definitions and the subrace definitions to catch them all, and they are all identical anyway, I would consider just putting a Superload wrapper on mod\class\Player\onBirth() and redoing the Escort location assignment with your own revised restrictions after the current code has ran.

Yeah, that's what I do in Escort Rescheduling, which is playing in basically the same area.

[visage]

Thanks!

Another addon question...

Is there an example out there of a talent that provides a targeting ball but requires that it be centered on an enemy? I thought such existed, but I'm failing to recall what it might be. Alternately, how might I implement that?

[Erenion]

Yes, there is. Volley from Archery Prowess (the category is called archery-utility in-code) is such a talent.

[visage]

Yes, there is. Volley from Archery Prowess (the category is called archery-utility in-code) is such a talent.

That did the trick; thanks!

[visage]

Since you'd have to loop over the race definitions and the subrace definitions to catch them all, and they are all identical anyway, I would consider just putting a Superload wrapper on mod\class\Player\onBirth() and redoing the Escort location assignment with your own revised restrictions after the current code has ran.

Yeah, that's what I do in Escort Rescheduling, which is playing in basically the same area.

So, having completely forgotten this thread I was messing around yesterday with tweaking escort distribution and I ran into an issue I don't understand. The following logs that birther is non-nil, but when the original onBirth is run it errors out, complaining that birther is nil.

Code: Select all

local base_onBirth = _M.onBirth
-- change the permitted levels for escorts
function _M:onBirth(birther)
    if birther == nil then
        game.logSeen(self, "onBirth got a nil birther")
    else
	game.logSeen(self, "onBirth got a non-nil birther")
    end
    if world.name == "Maj'Eyal" then
       world.random_escort_possibilities = { {"tier1.1", 1, 2}, {"tier1.2", 1, 2}, {"daikara", 1, 2}, {"old-forest", 1, 2}, {"dreadfell", 1, 2}, {"reknor", 1, 2}, }
    end
    return base_onBirth(birther)
end
return _M

Any ideas on what I'm missing? (I assume it would work to simply copy the definition of onBirth over rather than the above, but this seems like the better approach if viable.)

[HousePet]

return base_onBirth(birther) -> return base_onBirth(self, birther)

You need to add self as the first argument to the original function when you do this.

[visage]

return base_onBirth(birther) -> return base_onBirth(self, birther)

Seriously, lua?

Thanks, HousePet! That fixed one issue; on to the next! =)