- The dialog comes up every time you activate Arcane Combat, which is presumably why it doesn't automatically reset when you exit the levelup dialog — which, in turn, means you have to bounce the talent manually every time you level up.
- Conversely, the only way to get to the dialog is by deactivating Arcane Combat, waiting for it to cool down, and reactivating it.
- The only things you can configure Arcane Combat to do is use a single talent or use all talents. What if, say, I'm in Tempest Peak and I want Arcane Combat to use Flame and Earthen Missiles but not Lightning?
It resolves these problems as follows:
- The new game option "Arcane Combat configure on activate" can be disabled to suppress the configuration dialog on talent activation (hence the name), allowing the talent to auto-reset as needed.
- Whether the above option is enabled or disabled, the configuration dialog is always available via the talent's right-click popup menu.
- The configuration dialog itself is improved: each applicable talent can be enabled or disabled separately (you have to leave at least one enabled, though, or the dialog won't let you exit). You can configure talents that you haven't learned yet, so you don't have to remember to go back to the dialog and enable Earthen Missiles when you learn it; obviously, Arcane Combat will only randomly choose from talents you have learned and can cast.
[Technical notes:]
Code: Select all
Hooks:
ToME:load [to modify the Arcane Combat talent]
GameOptions:generateList [to add our game option]
Superload:
mod.dialog.UseTalents:
use() [overloaded, to add config option to Arcane Combat]
See, the way I was doing it before, if you had, say, everything but Lightning configured for Arcane Combat proc, and everything but Lightning was on cooldown (or you hadn't learned them yet), we were telling the underlying Arcane Combat trigger function to just trigger anything at random — which, of course, could result in Lightning triggering, which is not what we want.