Porting ToME2 to the T4 engine

[Steven Aus]

Well, I got a princess quest on Level 6 of the Barrow-downs, but when I won it didn't create the level down (although it did give me the reward). Actually, ever since you put in the proxy quest message for the princess quest, I don't think it has successfully created a princess (either a random monster in a cage, or nothing in the cage).

Here is what happened:

error = "Lua Error: /engine/Level.lua:122: attempt to index local 'e' (a nil value)\
At [C]:-1 __index\
At /engine/Level.lua:122 removeEntity\
At /data/chats/quest-princess-finish.lua:43 \
At /engine/Game.lua:313 onTickEndExecute\
At /engine/Game.lua:304 tick\
At /engine/GameTurnBased.lua:49 tick\
At /mod/class/Game.lua:547 "

The rebinding (Alt-L instead of Ctrl-L) didn't work for my existing game.

Here are some other errors:

error = "Lua Error: /engine/interface/ActorTalents.lua:279: /engine/interface/ActorTalents.lua:256: /engine/interface/ActorTalents.lua:150: /data/general/grids/all.lua:123: attempt to index global 'DamageType' (a nil value)\
stack traceback:\
\9/data/general/grids/all.lua:123: in function 'change_for_dmgtype'\
\9/mod/class/Grid.lua:262: in function 'check'\
\9[string \"return function(self, x, y, what, ...) local ...\"]:1: in function 'checkAllEntities'\
\9/engine/interface/ActorProject.lua:211: in function 'project'\
\9/mod/spell-util.lua in function 'ball_spell'\
\9/data/talents/spell/fire.lua:72: in function </data/talents/spell/fire.lua:68>\
\9[C]: in function 'xpcall'\
\9/engine/interface/ActorTalents.lua:147: in function </engine/interface/ActorTalents.lua:140>\
At [C]:-1 \
At [C]:-1 error\
At /engine/interface/ActorTalents.lua:279 useTalent\
At /mod/class/Player.lua:640 useTalent\
At /engine/interface/PlayerHotkeys.lua:170 \
At /engine/interface/PlayerHotkeys.lua:162 activateHotkey\
At /mod/class/HotkeysIconsDisplay.lua:178 onMouse\
At /mod/class/Game.lua:1208 fct\
At /engine/Mouse.lua:58 "

This is when I tried to pick up 2 Short Bows when my inventory already had 2 Short Bows which looked the same from what I knew about them. Also, I have got the following error at other times too when picking things up (most likely when there was something similar already in my inventory). I don't think I've had the error before the latest version of the module files.

error = "Lua Error: /mod/class/Actor.lua invalid order function for sorting\
At [C]:-1 \
At [C]:-1 sort\
At /mod/class/Actor.lua:1491 sortInven\
At /mod/class/Player.lua:1133 pickupFloor\
At /mod/dialogs/UseItemDialog.lua:133 use\
At /mod/dialogs/UseItemDialog.lua:45 fct\
At /engine/ui/List.lua:155 onUse\
At /engine/ui/List.lua:81 fct\
At /engine/Mouse.lua:58 receiveMouse\
At /engine/Mouse.lua:98 delegate\
At /engine/ui/Dialog.lua:657 mouseEvent\
At /engine/ui/Dialog.lua:399 fct\
At /engine/Mouse.lua:58 "

Just in case you need my log from my playthrough today for any additional information, here it is:

https://www.dropbox.com/s/z6nwwf785y7cv ... 2.zip?dl=0

Btw: is there a weight limit for the inventory (I only have Strength 3)? I guess this is not implemented yet. When you do implement it, I might have to start another character.

When I encountered the princess quest on the level in the save below, I found the princess was a zombie giant salamander, stuck behind a wall. When I rescued the "princess" (after the save below) the wall disappeared but the zombie giant salamander remained, which I could kill. I think other times the princess square had no unit in it, although maybe another time there was a different unit there.

https://www.dropbox.com/s/a7thuliijbd85 ... 4.zip?dl=0

Note: you can put more items in Home (nee Thieves Guild) then you have room for - it goes up to x (so 24 items), but any items you put in there afterwards are lost permanently. Even though the Mathom-house allows you to put items that you lose control of, maybe the Mathom-house will take more than its capacity too, which might make them disappear (not that it matters as much if you lose control of items placed in the Mathom-house anyway, compared with Home which you don't).

Interface bug: when you have two doors adjacent to you, you can't use "o" to try out a door until it's unlocked, you have to push the direction key one by one until it opens. I suggest that if you are next to two locked doors at the same time, you are asked to give a valid direction to a door to keep trying to unlock. Currently it gives an error message (just a regular one, not a lua one) when you are next to two doors and press "o".

Globe of light sometimes currently gives an error when hitting enemies - although mostly it still does damage even if it gives the error:

error = "Lua Error: /engine/interface/ActorTalents.lua:279: /engine/interface/ActorTalents.lua:256: /engine/interface/ActorTalents.lua:150: /data/general/grids/all.lua:123: attempt to index global 'DamageType' (a nil value)\
stack traceback:\
\9/data/general/grids/all.lua:123: in function 'change_for_dmgtype'\
\9/mod/class/Grid.lua:262: in function 'check'\
\9[string \"return function(self, x, y, what, ...) local ...\"]:1: in function 'checkAllEntities'\
\9/engine/interface/ActorProject.lua:211: in function 'project'\
\9/mod/spell-util.lua in function 'ball_spell'\
\9/data/talents/spell/fire.lua:77: in function </data/talents/spell/fire.lua:68>\
\9[C]: in function 'xpcall'\
\9/engine/interface/ActorTalents.lua:147: in function </engine/interface/ActorTalents.lua:140>\
At [C]:-1 \
At [C]:-1 error\
At /engine/interface/ActorTalents.lua:279 useTalent\
At /mod/class/Player.lua:640 useTalent\
At /engine/interface/PlayerHotkeys.lua:170 \
At /engine/interface/PlayerHotkeys.lua:162 activateHotkey\
At /mod/class/HotkeysIconsDisplay.lua:178 onMouse\
At /mod/class/Game.lua:1208 fct\
At /engine/Mouse.lua:58 "

A very important balance issue: Globe of Light is not seeming to take any time to cast, which means you can keep using it until everything is dead, even if they are close. I don't think this is intended, or is it?

I quit the game before I died, but the last error I got was this, probably from a confusion causing monster. I wasn't carrying a weapon.

error = "Lua Error: /mod/class/interface/PlayerCombat.lua:117: attempt to call method 'hasFlag' (a nil value)\
At [C]:-1 hasFlag\
At /mod/class/interface/PlayerCombat.lua:117 one_blow\
At /mod/class/interface/PlayerCombat.lua:692 bumpInto\
At /mod/class/Actor.lua:899 attack\
At /mod/class/Actor.lua:514 check\
At [string \"return function(self, x, y, what, ...) local ...\"]:1 checkAllEntities\
At /engine/Actor.lua:209 move\
At /mod/class/Actor.lua:445 move\
At /mod/class/Player.lua:286 moveDir\
At /mod/class/Player.lua:279 moveDir\
At /mod/class/Game.lua:812 move_or_scroll\
At /mod/class/Game.lua:823 \
At /engine/KeyBind.lua:230 "

Trying to use an identified Ranger Totem item that restores levels and stats (it's in my save right at the end of this post).

error = "Lua Error: /mod/class/Player.lua /mod/class/interface/ActorStats.lua:127: attempt to compare nil with number\
At [C]:-1 \
At [C]:-1 error\
At /mod/class/Player.lua:1196 playerUseItem\
At /mod/dialogs/UseItemDialog.lua:69 use\
At /mod/dialogs/UseItemDialog.lua:45 fct\
At /engine/ui/List.lua:155 onUse\
At /engine/ui/List.lua:81 fct\
At /engine/Mouse.lua:58 receiveMouse\
At /engine/Mouse.lua:98 delegate\
At /engine/ui/Dialog.lua:657 mouseEvent\
At /engine/ui/Dialog.lua:399 fct\
At /engine/Mouse.lua:58 "

I didn't die actually. I was able to use a Wand of Noxious Cloud on the unit attacking me while I was confused. However, it gave this error, maybe because the unit was killed and the poison couldn't do any more damage:

error = "Lua Error: /engine/interface/GameTargeting.lua:119: /data/general/grids/all.lua:149: attempt to index global 'DamageType' (a nil value)\
At [C]:-1 \
At [C]:-1 error\
At /engine/interface/GameTargeting.lua:119 fct\
At /engine/interface/GameTargeting.lua:125 targetMode\
At /engine/interface/GameTargeting.lua:254 targetMouse\
At /mod/class/Game.lua:1189 fct\
At /engine/Mouse.lua:58 "

Also, there was a possessor on the previous level. Not sure what they can do to player characters, apart from possessing them and then the player losing the game.

Does failing to use a wand correctly result in you losing any turns? Because I don't think that's currently happening.

Now using Globe of Light doesn't even damage rotting corpses. Here's the error:

error = "Lua Error: /engine/interface/ActorTalents.lua:279: /engine/interface/ActorTalents.lua:256: /engine/interface/ActorTalents.lua:150: /data/general/grids/all.lua:417: attempt to index global 'DamageType' (a nil value)\
stack traceback:\
\9/data/general/grids/all.lua:417: in function 'change_for_dmgtype'\
\9/mod/class/Grid.lua:262: in function 'check'\
\9[string \"return function(self, x, y, what, ...) local ...\"]:1: in function 'checkAllEntities'\
\9/engine/interface/ActorProject.lua:211: in function 'project'\
\9/mod/spell-util.lua in function 'ball_spell'\
\9/data/talents/spell/fire.lua:72: in function </data/talents/spell/fire.lua:68>\
\9[C]: in function 'xpcall'\
\9/engine/interface/ActorTalents.lua:147: in function </engine/interface/ActorTalents.lua:140>\
At [C]:-1 \
At [C]:-1 error\
At /engine/interface/ActorTalents.lua:279 useTalent\
At /mod/class/Player.lua:640 useTalent\
At /engine/interface/PlayerHotkeys.lua:170 \
At /engine/interface/PlayerHotkeys.lua:162 activateHotkey\
At /mod/class/HotkeysIconsDisplay.lua:178 onMouse\
At /mod/class/Game.lua:1208 fct\
At /engine/Mouse.lua:58 "

My most recent save in case you need it:

https://www.dropbox.com/s/wnp7wu0t9eg3a ... 7.zip?dl=0

[Atarlost]

[Oh, and I also just noticed that I hadn't yet implemented the NPC cause-wounds spells' chance of cursing equipment; that's now implemented. ]

I don't remember ever having this happen. Are you sure there's supposed to be a curse chance for cause minor and not just the higher curses?

[Steven Aus]

As well as the other stuff above, would it be possible to make an addon where you can throw harmful potions at enemies and/or use blessed water to uncurse items? I'm not asking you to do so, just wondering if it would be possible.

Also, another question and an issue:

Does Magic Device need to be levelled separately even if you have high level Sorcery?

I had both high level Sorcery and high level Magic Device skill, but the increased effect for having a certain proficiency didn't seem to be working, such as identifying all items in inventory and on the floor with one charge (and I would guess the second increased effect, identifying all items in inventory, floor and 1 square away from the character on the floor). I would guess any other bonuses for having high Magic Device skill might not work either.

[Zizzo]

Well, I got a princess quest on Level 6 of the Barrow-downs, but when I won it didn't create the level down (although it did give me the reward).

[sound F/X: source diving] Ah, it's trying to remove the non-existent princess before it places the down stairs. I've put in a similar emergency stopgap for that, so it should work for now.

The rebinding (Alt-L instead of Ctrl-L) didn't work for my existing game.

No, I meant I'd rebound my keys, from the "Key Bindings" entry on the game menu. We Apologize for the Confusion.™

Here are some other errors:

[sound F/X: source diving] Huh. I thought Entity:loadList() was supposed to pre-load engine.DamageType. Oh well; that should be fixed now.

This is when I tried to pick up 2 Short Bows when my inventory already had 2 Short Bows which looked the same from what I knew about them. Also, I have got the following error at other times too when picking things up (most likely when there was something similar already in my inventory). I don't think I've had the error before the latest version of the module files.

[sound F/X: source diving] Ooh, a tricky one: turns out false and nil are not as interchangeable in Lua as one might think, because "nil ~= nil" evaluates to true. I think that's fixed now.

Just in case you need my log from my playthrough today for any additional information, here it is:

Okay, I just added a bunch of debugging log lines to the princess quest room generation; post your log file the next time you get a princess quest without a princess.

Btw: is there a weight limit for the inventory (I only have Strength 3)? I guess this is not implemented yet.

As you say. One of the many things on my priority queue…

When I encountered the princess quest on the level in the save below, I found the princess was a zombie giant salamander, stuck behind a wall. When I rescued the "princess" (after the save below) the wall disappeared but the zombie giant salamander remained, which I could kill. I think other times the princess square had no unit in it, although maybe another time there was a different unit there.

Okay, something is going seriously wrong here. You're using your persistent-levels addon for all of this, yes? Maybe I should do some testing with that…

Note: you can put more items in Home (nee Thieves Guild) then you have room for - it goes up to x (so 24 items), but any items you put in there afterwards are lost permanently.

I thought that was supposed to be checked for by the engine code. Let me look into that.

Interface bug: when you have two doors adjacent to you, you can't use "o" to try out a door until it's unlocked, you have to push the direction key one by one until it opens. I suggest that if you are next to two locked doors at the same time, you are asked to give a valid direction to a door to keep trying to unlock. Currently it gives an error message (just a regular one, not a lua one) when you are next to two doors and press "o".

That's odd; what you describe is what's supposed to happen. I'll check that one too.

Globe of light sometimes currently gives an error when hitting enemies - although mostly it still does damage even if it gives the error:

Yeah, that's the same error as above. Should be fixed now.

A very important balance issue: Globe of Light is not seeming to take any time to cast, which means you can keep using it until everything is dead, even if they are close. I don't think this is intended, or is it?

[sound F/X: source diving] Ah, so that's why you're supposed to return true from the talent's action() method… Should be fixed.

I quit the game before I died, but the last error I got was this, probably from a confusion causing monster. I wasn't carrying a weapon.

[sound F/X: source diving] Huh. That's supposed to be covered already. I'll need to investigate that.

Trying to use an identified Ranger Totem item that restores levels and stats (it's in my save right at the end of this post).

[sound F/X: source diving] Stupid typo in the restore-stat method; that would have affected anything that tried to restore stats. Should be fixed now.

I didn't die actually. I was able to use a Wand of Noxious Cloud on the unit attacking me while I was confused. However, it gave this error, maybe because the unit was killed and the poison couldn't do any more damage:

No, that's just another manifestation of the bug you were getting from Globe of Light above.

Also, there was a possessor on the previous level. Not sure what they can do to player characters, apart from possessing them and then the player losing the game.

You mean a Novice possessor (soul) or something similar? Those are supposed to be able to possess corpses left behind by monsters you've killed, effectively bringing them back to life. Needless to say, that's not implemented yet.

Does failing to use a wand correctly result in you losing any turns? Because I don't think that's currently happening.

I'm pretty sure it's supposed to. I'll check.

Now using Globe of Light doesn't even damage rotting corpses. Here's the error:

Yeah, same bug again. Presumably it's choking trying to apply damage to the grid before it can get around to damaging the monster.

[Oh, and I also just noticed that I hadn't yet implemented the NPC cause-wounds spells' chance of cursing equipment; that's now implemented. ]

I don't remember ever having this happen. Are you sure there's supposed to be a curse chance for cause minor and not just the higher curses?

Yep, 33% chance. Of course, that's if it actually hits upon an item in its random equipment pick, and it's picking from all the equipment slots, including empty ones, and including the placeholder ones used for Possession and Mimicry (so all six ring slots, for instance), so there's a decent chance it's just missing everything you're wielding. I make an effort to reproduce this logic in my implementation, as a courtesy to the player.

As well as the other stuff above, would it be possible to make an addon where you can throw harmful potions at enemies and/or use blessed water to uncurse items? I'm not asking you to do so, just wondering if it would be possible.

Well, throwing potions is implemented in the original T2, and will also be in the module once I implement the 'throw' command. There's no such thing as "blessed water" in T2, though; you're thinking of NetHack. I'm sure it would be doable in an addon, though I'm not sure how I'd do it OTTOMH.

Does Magic Device need to be levelled separately even if you have high level Sorcery?

Sorcery doesn't affect your ability to use wands and staffs, if that's what you mean.

I had both high level Sorcery and high level Magic Device skill, but the increased effect for having a certain proficiency didn't seem to be working, such as identifying all items in inventory and on the floor with one charge (and I would guess the second increased effect, identifying all items in inventory, floor and 1 square away from the character on the floor). I would guess any other bonuses for having high Magic Device skill might not work either.

That probably just means I've implemented Magic-Device and/or wands/staffs wrong. I'll investigate.

[Steven Aus]

Thanks for all your work! My addon code that I've been using can be found at:

https://www.dropbox.com/s/o9canhiaaqy6n ... s.zip?dl=0

And yes, I know I was thinking of Nethack. Nethack did a lot of things right, after all, including having a function for nearly everything you could possibly try in real life. I don't expect that here, it's just that Nethack gives a lot of good ideas.

Also, a lot of things when they go in my inventory don't get tested for being cursed or blessed (if that's a state) because they have already been partially identified. There is a difference between Identify and *Identify*, isn't there, and also between the pseudo-identification skills?

And I take it that currently potions of one type is always a potion of that type, there is no blessed/neutral/cursed property on it?

I got to the princess room in Level 12 Barrow-downs, and died to a hammerhead shark. However even though the save has gone, the log should have the information you need if the princess quest didn't work properly.

https://www.dropbox.com/s/htbvjz700ygcp ... l.zip?dl=0

The character dump caused an error, but still produced the character text file.

error = "Lua Error: /mod/dialogs/CharacterSheet.lua:544: attempt to call field 'self_knowledge' (a nil value)\
At [C]:-1 self_knowledge\
At /mod/dialogs/CharacterSheet.lua:544 dump\
At /mod/dialogs/CharacterSheet.lua:113 on_input\
At /engine/KeyCommand.lua:71 receiveKey\
At /engine/ui/Dialog.lua:666 keyEvent\
At /engine/ui/Dialog.lua:401 "

Also, you can't push past Neutral units (you can push past allies, but not neutrals).

The Globe of Light still isn't working properly (although you may still be in the process of fixing it):

error = "Lua Error: /engine/interface/ActorTalents.lua:279: /engine/interface/ActorTalents.lua:256: /engine/interface/ActorTalents.lua:150: /data/general/grids/all.lua:123: attempt to index global 'DamageType' (a nil value)\
stack traceback:\
\9/data/general/grids/all.lua:123: in function 'change_for_dmgtype'\
\9/mod/class/Grid.lua:262: in function 'check'\
\9[string \"return function(self, x, y, what, ...) local ...\"]:1: in function 'checkAllEntities'\
\9/engine/interface/ActorProject.lua:211: in function 'project'\
\9/mod/spell-util.lua in function 'ball_spell'\
\9/data/talents/spell/fire.lua:77: in function </data/talents/spell/fire.lua:68>\
\9[C]: in function 'xpcall'\
\9/engine/interface/ActorTalents.lua:147: in function </engine/interface/ActorTalents.lua:140>\
At [C]:-1 \
At [C]:-1 error\
At /engine/interface/ActorTalents.lua:279 useTalent\
At /mod/class/Player.lua:640 useTalent\
At /engine/interface/PlayerHotkeys.lua:170 \
At /engine/interface/PlayerHotkeys.lua:162 activateHotkey\
At /mod/class/HotkeysIconsDisplay.lua:178 onMouse\
At /mod/class/Game.lua:1208 fct\
At /engine/Mouse.lua:58 "

Now you can access doors by pressing "o" and a direction, but you're not able to keep trying doors until you unlock them, which you can do when there is only one door next to you. So basically, if there is only one door next to you, "o" works to try it repeatedly until 100 turns have passed or you open it. But if there are two or more doors next to you "o" makes you choose a direction, but it only tries the door once.

[Zizzo]

Also, a lot of things when they go in my inventory don't get tested for being cursed or blessed (if that's a state) because they have already been partially identified. There is a difference between Identify and *Identify*, isn't there, and also between the pseudo-identification skills?

I think this may just be terminology confusion. A Potion of Weakness, for instance, will pseudo-ID as {cursed} before it's been identified, but it's not cursed in the same way that, say, a sword can be cursed; it's just a bad potion that you don't want to drink.

And I take it that currently potions of one type is always a potion of that type, there is no blessed/neutral/cursed property on it?

That's right. Only wearable equipment has a meaningful cursed state, and that should be visible if it's been identified.

I got to the princess room in Level 12 Barrow-downs,

Um… the Barrow-downs is only supposed to go to level 10. Was there a princess quest on level 10, with a down stair in the quest room? Because the code's supposed to catch that.

and died to a hammerhead shark.

Was that the quest monster? Odd; it has the AQUATIC flag, so it shouldn't be able to move or be generated outside a water grid. Maybe I didn't implement that? I'll check.

However even though the save has gone, the log should have the information you need if the princess quest didn't work properly.

[reads log file] Well, that certainly wasn't the error I was expecting. It's falling afoul of the code that prevents unique NPCs from being generated more than once; it thinks the princess has already been generated and won't generate her again. I thought I was clearing that flag at the end of the quest, though… I'll investigate.

The character dump caused an error, but still produced the character text file.

[sound F/X: source diving] Hmm, apparently I changed my mind about what the spell.self_knowledge() method should be called between implementing it and using it… Fixed.

Also, you can't push past Neutral units (you can push past allies, but not neutrals

[sound F/X: source diving] Interestingly, it turns out that's what the original T2 code does too. I think I'll go ahead and allow pushing past neutrals for now, though, until and unless we run into someplace where that causes problems.

The Globe of Light still isn't working properly (although you may still be in the process of fixing it):

Hmm, that's still using old code. Might be the persistent-levels thing; if the old code is "baked into" the persisted door grid, it wouldn't notice the change in the new code.

Now you can access doors by pressing "o" and a direction,

[checks watch] …Wait a minute, I only just fixed that a couple hours ago. Are you a Time Lord or something?

[Steven Aus]

Maybe the princess being unique check clashes with the way persistentdungeons works?

No, I know potions can't be cursed. What I mean is, you can get Staffs that have Identify, and you can get more expensive staffs that have *Identify*. When I use the first kind, it is not fully identified (because it still gives the message about "You may need to identify this item to find more about it" or whatever). I haven't been able to afford the staff that mentions *Identify*.

I got aquatic monsters for a lost sword quest too, and they were able to move about normally.

I think you might have already done a fix for the door issue yesterday, or at least a partial one. Anyway, doesn't matter.

Note: you can walk on lava with no damage currently.

Also, I think I might have done game:changeLevel(11) on level 10, because this was before you implemented the check to make sure the down level appeared, and I didn't know that it didn't go past level 10.

[Zizzo]

Maybe the princess being unique check clashes with the way persistentdungeons works?

No, that was my sloppiness; I wasn't properly clearing the "unique has been generated" flag for the princess when I removed her on quest completion. That should be fixed, but you'll need to start a new game for it, since all your current games will have her flagged as generated.

No, I know potions can't be cursed. What I mean is, you can get Staffs that have Identify, and you can get more expensive staffs that have *Identify*.

[checks notes] Um… no, Greater Identify isn't available on staffs. I assume you mean scrolls?

When I use the first kind, it is not fully identified (because it still gives the message about "You may need to identify this item to find more about it" or whatever). I haven't been able to afford the staff that mentions *Identify*.

Oh, okay, I see what you're aiming at. Generally, only wearable equipment will have flags that aren't revealed by a standard Identify. [At least I can't think of anything else OTTOMH that would need *Identify*'ing, though I'm sure our readers will remind me if I've forgotten something. ] And within that, with the possible exception of rings and amulets, you generally only need to *identify* ego or artifact equipment. …Wait, I take back part of that; rods with egos may need to be *identify*'d too.

Oh, and on the subject of staffs and identifying stuff:

I had both high level Sorcery and high level Magic Device skill, but the increased effect for having a certain proficiency didn't seem to be working, such as identifying all items in inventory and on the floor with one charge (and I would guess the second increased effect, identifying all items in inventory, floor and 1 square away from the character on the floor).

That probably had to do with the staff itself. You've no doubt seen that wands and staffs all have [M|N] numbers in their name. Those are described in more detail in my T2 spell spoiler, in the section on wands and staffs; for our purposes here, the second number is the maximum spell level you can get by using the wand/staff. So if you have a Staff of Identify [1|16], for instance, then the effective spell level of the staff will never get higher than 16, no matter how high your Magic-Device skill level is. You can see the effective spell level you're getting in the wand/staff's tooltip description. Generally the [M|N] numbers will be higher for wands and staffs found at deeper levels, so further down you'll likely find a Staff of Identify [1|17] or so that you'll want to hang onto.

I got aquatic monsters for a lost sword quest too, and they were able to move about normally.

Yeah, I've fleshed out the block_move() method further to catch that — and on top of that, the princess/lost-sword quest generation was already supposed to be filtering out aquatic monsters.

Note: you can walk on lava with no damage currently.

What?! That's one of the first things I– [sound F/X: source diving] …I …never actually implemented that, apparently. Let me think about what the right way to implement that is.

Also, I think I might have done game:changeLevel(11) on level 10, because this was before you implemented the check to make sure the down level appeared, and I didn't know that it didn't go past level 10.

Yeah, that occurred to me later. That makes sense, as Game:changeLevel() no doubt assumes that its caller has already done the necessary bounds checking.

[Steven Aus]

Yes, I meant some scrolls have *Identify*.

I've just realised, if you get a princess quest, and before finishing go to another level and get another princess quest, you might get the same error. Since unlike with the base game, when the persistentdungeons addon is activated the princess is not deleted and recreated as you change levels. Can you make the princess non-unique without her appearing as a monster that you have to kill somewhere?

I don't have any more bug reports or suggestions for the moment. What are you planning to implement soon, apart from damage from certain floors such as lava?

[Zizzo]

I've just realised, if you get a princess quest, and before finishing go to another level and get another princess quest, you might get the same error. Since unlike with the base game, when the persistentdungeons addon is activated the princess is not deleted and recreated as you change levels. Can you make the princess non-unique without her appearing as a monster that you have to kill somewhere?

That problem had occurred to me too. The solution I'm going with for now is to use the 'force_unique' parameter of Zone:makeEntityByName() to force the princess to be generated even if the game thinks she shouldn't be.

I don't have any more bug reports or suggestions for the moment. What are you planning to implement soon, apart from damage from certain floors such as lava?

I was actually thinking of making another release soon. After that, I'll probably go back and finish up the map generation work I left back on trunk.

[Atarlost]

Does the princess actually need a unique flag at all? She's only generated by the quest.

[Steven Aus]

There is an error with the version I just downloaded, every time I move I get an:

error = "Lua Error: /mod/class/Player.lua:335: attempt to index global 't_eff' (a nil value)\
At [C]:-1 __index\
At /mod/class/Player.lua:335 describeFloor\
At /mod/class/Player.lua:290 moveDir\
At /mod/class/Player.lua:279 moveDir\
At /mod/class/Game.lua:812 move_or_scroll\
At /mod/class/Game.lua:826 \
At /engine/KeyBind.lua:230 "

Not sure what happens when you run.

[Zizzo]

Does the princess actually need a unique flag at all? She's only generated by the quest.

(shrug) Possibly not, but she's flagged as unique in T2's r_info.txt, and modifying my Perl conversion script to change that on the fly would have been slightly more work than the solution I eventually went with.

There is an error with the version I just downloaded, every time I move I get an:

Yeah, I didn't think that would work out of the gate… [sound F/X: source diving] Mm, just a stupid typo. Should be fixed now.

[Steven Aus]

Thunderstrike doesn't cost mana or time, even though it is meant to cost 1 mana per level and time to cast. So in regards to time, it is like Globe of Light before it was fixed. However, if you "fail to concentrate properly" it takes time, so that bit is working. You might want to check the other Thunderlord-specific talents to make sure they are properly requiring mana and using time.

Is the reason why "Perfect casting" talent is not working because the robe counts as a failure chance? Or is Perfect casting not implemented yet?

Trying to drink an unidentified average potion:

error = "Lua Error: /mod/class/Player.lua /engine/interface/ActorTemporaryEffects.lua:116: attempt to index local 'p' (a nil value)\
At [C]:-1 \
At [C]:-1 error\
At /mod/class/Player.lua:1219 playerUseItem\
At /mod/dialogs/UseItemDialog.lua:69 use\
At /mod/dialogs/UseItemDialog.lua:45 fct\
At /engine/ui/List.lua:155 onUse\
At /engine/ui/List.lua:81 fct\
At /engine/Mouse.lua:58 receiveMouse\
At /engine/Mouse.lua:98 delegate\
At /engine/ui/Dialog.lua:657 mouseEvent\
At /engine/ui/Dialog.lua:399 fct\
At /engine/Mouse.lua:58 "

Trying to merge stun durations of Thunder Strike I think:

error = "Lua Error: /engine/interface/GameTargeting.lua:119: /engine/interface/ActorTalents.lua:150: /mod/util.lua:569: attempt to index local 'def' (a nil value)\
stack traceback:\
\9/mod/util.lua:569: in function 'merge_effect_duration'\
\9/data/timed_effects.lua:262: in function 'on_merge'\
\9/engine/interface/ActorTemporaryEffects.lua:124: in function 'setEffect'\
\9/data/damage_types.lua in function 'side_effects_pre'\
\9/data/damage_types.lua:182: in function 'projector'\
\9/engine/interface/ActorProject.lua:219: in function 'project'\
\9/mod/spell-util.lua in function 'beam_spell'\
\9/data/talents/player/race-class.lua:338: in function </data/talents/player/race-class.lua:334>\
\9[C]: in function 'xpcall'\
\9/engine/interface/ActorTalents.lua:147: in function </engine/interface/ActorTalents.lua:140>\
At [C]:-1 \
At [C]:-1 error\
At /engine/interface/GameTargeting.lua:119 fct\
At /engine/interface/GameTargeting.lua:125 targetMode\
At /engine/interface/GameTargeting.lua:254 targetMouse\
At /mod/class/Game.lua:1196 fct\
At /engine/Mouse.lua:58 "

It's so hard to hit the starting monsters in Bree with arrows (apart from the really weak ones). The battle scarred veteran, mean-looking mercenary and agent of the black market are especially hard to hit. Even if they hit and you did 2 damage, it would be better than firing 6 or 8 or 10 arrows and missing all of them. Is this intended? Even though they are the tougher "no XP" characters, how are you supposed to clear your way around Bree if you can't hit them with arrows? And what is the use of arrows btw if the "to hit" chance drops a lot with further squares? The whole point with Archers (and to a lesser extent Rangers) is to be far away from the enemy.

When I tried to equip something onto a slot that was already full (in this case, a robe) the item that was previously in the slot was not put into inventory and was lost because of an error. Note: the item I equipped was actually a cursed item. Why does the princess give cursed items by the way, and how can the items still have useful traits or abilities if they are cursed?

Note: somehow the thieves removed the cursed item, even though we can't, at the start of the thieves' guild quest.

error = "Lua Error: /mod/class/Player.lua /engine/interface/ActorInventory.lua:115: attempt to index local 'inven' (a nil value)\
At [C]:-1 \
At [C]:-1 error\
At /mod/class/Player.lua:1414 doWear\
At /mod/dialogs/UseItemDialog.lua:113 use\
At /mod/dialogs/UseItemDialog.lua:45 fct\
At /engine/ui/List.lua:155 onUse\
At /engine/ui/List.lua:81 fct\
At /engine/Mouse.lua:58 receiveMouse\
At /engine/Mouse.lua:98 delegate\
At /engine/ui/Dialog.lua:657 mouseEvent\
At /engine/ui/Dialog.lua:399 fct\
At /engine/Mouse.lua:58 "

How do you use dark rifts or fountains? There is a fountain that says, "The liquid here seems magical."

When I took the up stair on Barrow Downs Level 2 to go back to Level 1, I appeared at the exit to Bree (Barrow Downs Level 1) instead of a down stair. Is this just a funny interaction with the base module and the add-on, and is there any way to alter that behaviour?

When running to the Black Market:

error = "Lua Error: /data/general/objects/rod-tips.lua:543: attempt to index global 'DamageType' (a nil value)\
At [C]:-1 __index\
At /data/general/objects/rod-tips.lua:543 getval\
At /mod/class/Object.lua:836 getDesc\
At /engine/dialogs/ShowStore.lua:129 generateList\
At /engine/dialogs/ShowStore.lua:59 init\
At /mod/dialogs/ShowStore.lua:45 init\
At /engine/class.lua:147 new\
At /mod/class/Store.lua:428 interact\
At /mod/resolvers.lua:39 check\
At [string \"return function(self, x, y, what, ...) local ...\"]:1 checkAllEntities\
At /engine/Actor.lua:209 move\
At /mod/class/Actor.lua:445 move\
At /mod/class/Player.lua:286 move\
At /engine/interface/PlayerRun.lua:136 runStep\
At /mod/class/Player.lua:501 act\
At /engine/GameEnergyBased.lua:129 tickLevel\
At /mod/class/GameEnergyBasedEvilHack.lua:32 tick\
At /engine/GameTurnBased.lua:51 tick\
At /mod/class/Game.lua:547 "

After that, when trying to visit the Black Market, even by walking (the other shops work fine):

error = "Lua Error: /data/general/objects/rod-tips.lua:543: attempt to index global 'DamageType' (a nil value)\
At [C]:-1 __index\
At /data/general/objects/rod-tips.lua:543 getval\
At /mod/class/Object.lua:836 getDesc\
At /engine/dialogs/ShowStore.lua:129 generateList\
At /engine/dialogs/ShowStore.lua:59 init\
At /mod/dialogs/ShowStore.lua:45 init\
At /engine/class.lua:147 new\
At /mod/class/Store.lua:428 interact\
At /mod/resolvers.lua:39 check\
At [string \"return function(self, x, y, what, ...) local ...\"]:1 checkAllEntities\
At /engine/Actor.lua:209 move\
At /mod/class/Actor.lua:445 move\
At /mod/class/Player.lua:286 moveDir\
At /mod/class/Player.lua:279 moveDir\
At /mod/class/Game.lua:812 move_or_scroll\
At /mod/class/Game.lua:823 \
At /engine/KeyBind.lua:230 "

When trying to identify a named but unidentified book (btw: how do you "read" a book? by *Identify*ing it?)

error = "Lua Error: /engine/interface/ActorTalents.lua:996: /engine/interface/ActorInventory.lua:149: attempt to index local 'o' (a nil value)\
At [C]:-1 \
At [C]:-1 error\
At /engine/interface/ActorTalents.lua:996 unload\
At /engine/Game.lua:419 unregisterDialog\
At /mod/dialogs/ShowEquipInvenFloor.lua:74 use\
At /engine/dialogs/ShowEquipInven.lua:49 fct\
At /engine/ui/ListColumns.lua:463 onUse\
At /engine/ui/ListColumns.lua:135 fct\
At /engine/Mouse.lua:58 receiveMouse\
At /engine/Mouse.lua:98 delegate\
At /engine/ui/Dialog.lua:657 mouseEvent\
At /engine/ui/Dialog.lua:399 fct\
At /engine/Mouse.lua:58 "

Also when Smeagol did his steal gold trick he teleported to the same square that I was on.

This game, which worked fine before when I saved it, its new save is not working (note: I saved it on the down stair of a princess quest, but after I'd left the level and come back to it a couple of times):

https://www.dropbox.com/s/netoho17pzanz ... r.zip?dl=0

error = "Lua Error: /mod/class/Grid.lua:57: attempt to call field 'attrs' (a table value)\
At [C]:-1 attrs\
At /mod/class/Grid.lua:57 check\
At /engine/Grid.lua:43 setupMinimapInfo\
At /engine/Map.lua:491 updateMap\
At /mod/class/Map.lua:390 redisplay\
At /engine/Map.lua:391 loaded\
At /mod/class/Map.lua:32 loaded\
At /engine/Savefile.lua:552 delay\
At /engine/Module.lua:1050 instanciate\
At /engine/utils.lua:2221 showMainMenu\
At /engine/init.lua:165 \
At [C]:-1 dofile\
At /loader/init.lua:217 "

[Zizzo]

Thunderstrike doesn't cost mana or time, even though it
is meant to cost 1 mana per level and time to cast.

[sound F/X: source diving] Ah, one last thing that was broken by my earlier ill-fated Thnder Strike fix. Should be fixed now.

Is the reason why "Perfect casting" talent is not working because the robe counts as a failure chance? Or is Perfect casting not implemented yet?

The Prefect Casting ability doesn't mean all spells get a zero fail chance; it just removes the minimum 5% fail chance, so that you can get a spell's fail chance to zero with sufficiently high INT and skill level.

Trying to drink an unidentified average potion:

[sound F/X: source diving] Could have been a Potion of Heroism or Berzerk Strength; both of those were missing the parameter table in :setEffect(). Fixed.

Trying to merge stun durations of Thunder Strike I think:

[sound F/X: source diving] You are correct. I also got that wrong in the Cut and Hasted effects. Fixed.

It's so hard to hit the starting monsters in Bree with arrows (apart from the really weak ones).

Didn't we touch on this before? [re-reads thread] Oh, right, we found that your attack power was unusually low, and I put in some debugging log messages to try to track down why. I've put in a few more log messages; try it again and send me a log file.

When I tried to equip something onto a slot that was already full (in this case, a robe) the item that was previously in the slot was not put into inventory and was lost because of an error.

Ulk, that stack trace doesn't really give any indication of what's breaking, unfortunately. So the item that got swapped out was not cursed, but the item you were wearing was? That may have something to do with it; I'll investigate.

Why does the princess give cursed items by the way,

She's not supposed to. I'll need to look into that.

Note: somehow the thieves removed the cursed item, even though we can't, at the start of the thieves' guild quest.

Hmm, I forget whether that's intended behavior; I'll need to check the T2 code.

How do you use dark rifts or fountains? There is a fountain that says, "The liquid here seems magical."

Fountains aren't implemented yet. On void jumpgates, use your change-level key (usually '>' or '<'); it should (I hope…) teleport you to the pair gate.

When I took the up stair on Barrow Downs Level 2 to go back to Level 1, I appeared at the exit to Bree (Barrow Downs Level 1) instead of a down stair. Is this just a funny interaction with the base module and the add-on, and is there any way to alter that behaviour?

You had a princess quest on level 1, I assume? So there were no down stairs when level 1 was created, and the princess quest stair wouldn't have been added to the list of "places to remember that there's a down stair" (since I wasn't expecting to need to), so the change-level code wouldn't have known there was a down stair it could put you on and would have used the up stair as a fallback. I'll have to dig around in the level-generation code to see how to get that information set up right.

When running to the Black Market:

[sound F/X: source diving] Mm, the problem is something in the Black Market's stock — in this case, it looks like a Rod Tip of Acid Balls, but it looks like all rod tips were broken [I can never keep track of when I can count on the engine to require() modules like DamageType for me and when I have to do it myself…]. That should be fixed for future rod tips, but the one currently in the Black Market has probably already been persisted with the broken code, so it'll be a problem until it cycles out of stock.

When trying to identify a named but unidentified book

…? Not sure how you could get one of those. [sound F/X: source diving] Hmm, AFAICT the error is happening in ActorInventory:addObject(), which isn't obviously connected; were you using a stack of Staffs of Identify, by any chance?

(btw: how do you "read" a book? by *Identify*ing it?)

There should be a "Browse spells" option in the use-item dialog for the book.

Also when Smeagol did his steal gold trick he teleported to the same square that I was on.

Well, that's certainly not supposed to happen. I'll investigate.

This game, which worked fine before when I saved it, its new save is not working (note: I saved it on the down stair of a princess quest, but after I'd left the level and come back to it a couple of times):

O-kay, that's something deep in the bowels of the map handling code that is apparently not getting reinitialized properly on reload. I'll investigate.