[1.3.1] Bone shield is broken?

[Charlie_B]

According to the description, the 1st level of Bone Shield regenerates every 30 turns and subsequent levels are supposed to reduce the regen delay. However, I'm currently playing a Skeleton Reaver with Bone Shield on level 4 and while I'm getting the currect number of shields the regen delay is definitely not 6 turns - it appears that it's still stick on 30?

[Micbran]

Mine was working earlier when I was playing corruptor about... A week ago? Any addons?

[Charlie_B]

Hmm. No, no addons. I only downloaded the game a few days ago (although I played a lot on my old laptop).

I've just tested again. Not sure exaclty how to calculate a 'turn' but I have to walk 35 paces before a part of the shield regenerates :/

[Micbran]

Unless you're playing a very fast character, I don't see how that could be happening.

[Charlie_B]

Well, I've fixed it, but I still suspect there's a bug.

The fix was to deactivate then reactivate the sustain. It seems that if you upgrade Bone Armour while it's sustained the number of shields increases but it doesn't alter the regen time.

[Micbran]

Not a bug. That is intended, at least in the code that is. The sustain is marked as "no_sustain_autoreset = true" Whether to stop the player from potentially screwing them self over when they spend their points or whether it is simply deprecated code is beyond me. My guess is the former.

[Charlie_B]

It seems counter-intuitive that the number of shields increases automatically, but changing the regen rate requires you to manually disable and re-enable the sustain?

[Effigy]

When you modify your talents, it gives you a message listing all sustained talents that aren't updated automatically. You need to deactivate and reuse those talents for changes to take effect.

[shadcor]

The reason talents like this don't automatically reset is if it did you'd suddenly have 0 levels of shielding and be waiting on the shield to build back up. This way you can turn it off and back on when it's safe and you can rest to refresh, and meanwhile you still get some of the benefits.

[Zeyphor]

when you level up bone shield the refresh speed doesn't update; for that to happen you need to recast bone shield

not a bug

[ghostbuster]

I play ToME for years and I did not know that.
Could we have a warning at the end of the talent description?
Something like
Refresh rate will only be updated when the talent is restarted.

[Effigy]

This is what it shows after you level up Bone Shield with it sustained:

Untitled.png (58.65 KiB) Viewed 5264 times

[Stenag]

Warning: You have increased some of your statistics or talent. Talent(s) actually sustained:

Currently ? (Actuellement != actually )

[Effigy]

Yeah, it could be rephased slightly.

[Charlie_B]

I'm still not convinced. When you upgrade Bone Shield the message suggests that you may need to refresh it, but you can immediately see that the upgrade has taken effect - you get more shields. That implies that the upgrade has taken effect and therefore you don't need to refresh. For half of a talent to upgrade and the other half of the same talent not to is very unexpected and - as we've seen - leads to confusion.

Furthermore, the text says "If these are dependent on one of the stats you have changed..." - which seems to be wrong. Even if I upgrade a talent without changing my stats at all it still needs to be refreshed for the change to take effect. Presumably it should say 'stats or talents'?

The reason talents like this don't automatically reset is if it did you'd suddenly have 0 levels of shielding and be waiting on the shield to build back up. This way you can turn it off and back on when it's safe and you can rest to refresh, and meanwhile you still get some of the benefits.

There's no reason why changing the refresh rate on Bone Shield would have to leave you with no shields. It could update automatically in the same way the number of shields does.