notacorporal wrote:Re multiple slot items, is this to do with the [CTRL] compare feature? I think this is a seperate issue. i.e. it needs a fix specific to that feature, i.e. it is not your problem.
It kinda is, though. The problem is that since this is for effective values, it needs to act like you have
nothing equipped in whatever slot when it calculates what the effective increase is.
Like, for example, say you have 10 phys save and you have a helm that gives +10 phys save, it'll show as giving +10 effective. But when you equip it, your save is now 20, and it'll only show an effective increase of +5, even though in reality it's bringing you from 10 to 20.
I've fixed that specific issue, I just wanted to point out that it's linked with the comparison system more than is immediately apparent.
As of right now I've got it working so that you should get the 'true' effective value when you activate the compare mode. So activating the comparison will actually change the original effective value in the tooltip, as it starts accounting for removing the original item. (If you don't have anything in that slot or you're actually wearing the item it should always be 'correct'.)
I think I've got it working right, it's just ... rather complicated.
Are there any other stats this would be useful for than powers/saves/accuracy/defense?