[1.2.3] Spellcraft & spellshock_on_damage

[Alisar]

Spellcraft description

In addition, you hone your damaging spells to spellshock their targets. This talent gives a bonus of %d to Spellpower solely for the purposes of overcoming the target's Spell Save. Spellshocked targets suffer a temporary 20%% penalty to damage resistances.

damage_types.lua line 512

Code: Select all

			if src:attr("spellshock_on_damage") and target:checkHit(src:combatSpellpower(), target:combatPhysicalResist(), 0, 95, 15) and not target:hasEffect(target.EFF_SPELLSHOCKED) then
				target:crossTierEffect(target.EFF_SPELLSHOCKED, src:combatSpellpower())
			end

Spellcraft adds spellshock_on_damage correctly, but that never gets added to the combatSpellpower() check.

[0player]

Spellshock on damage is one thing; overcoming Spell Save is another. Spell Save isn't used when damaging, it is used when applying a timed effect.

[Alisar]

If that is the intention, it doesn't do that either anywhere in the code.

I think it is meant to apply only to spellshock, as the only place it mentions increasing spellpower is in the middle of the section about spellshock on damage. Also, spellshock_on_damage is set to the amount of spellpower it increases it by.

[HousePet]

Checked the code and I can confirm that the bonus spellpower is mentions isn't used anywhere.