(addon bug) [1.2 b8] shader bug -> infinite Lua spam

[Doctornull]

Entering Murgol's Lair for the first time:

Code: Select all

Added unique	mod.class.NPC/Emelaba the giant eel	::	1
[TOME ENTITY FILTER] selected basic	101.16777828398	112.5
[TOME ENTITY FILTER] selected Ego	63.404997386365	65.5
[TOME ENTITY FILTER] selected Ego	23.403891458852	65.5
[TOME ENTITY FILTER] selected Ego	43.395263589429	65.5
[TOME ENTITY FILTER] selected Ego	34.148769027239	65.5
[TOME ENTITY FILTER] selected Ego	50.370125923741	65.5
[TOME ENTITY FILTER] selected Ego	62.507630178823	65.5
[TOME ENTITY FILTER] selected Ego	27.223137364309	65.5
[TOME ENTITY FILTER] selected Ego	65.473977297538	65.5
[TOME ENTITY FILTER] selected basic	92.646865884691	103.5
[TOME ENTITY FILTER] selected basic	81.384580695276	103.5
[TOME ENTITY FILTER] selected basic	92.70223909237	112.5
[TOME ENTITY FILTER] selected basic	76.819747116375	112.5
Loading tile	object/wizardhat_linen.png
[TOME ENTITY FILTER] selected Double Ego	17.241537371241	20.5
Loading tile	object/torque_iron.png
[TOME ENTITY FILTER] selected Ego	40.252352684097	65.5
[TOME ENTITY FILTER] selected basic	84.457276178747	112.5
[TOME ENTITY FILTER] selected Double Ego	2.687092024178	20.5
Loading tile	object/2haxe_iron.png
[TOME ENTITY FILTER] selected Double Ego	10.796942561468	20.5
[TOME ENTITY FILTER] selected Ego	26.919176272796	65.5
Wait finished, counted 4172, 1990 ticks
Lua Error: /mod/class/Player.lua:449: attempt to index local 'pf' (a nil value)
	At [C]:-1 __index
	At /mod/class/Player.lua:449 updateMainShader
	At /mod/class/Game.lua:1477 onUnregisterDialog
	At /engine/Game.lua:380 unregisterDialog
	At /engine/ui/Dialog.lua:40 done
	At /engine/Zone.lua:807 getLevel
	At /mod/class/Game.lua:822 changeLevelReal
	At /mod/class/Game.lua:702 base_changeLevel
	At /mod/addons/zomnibus/superload/mod/class/Game.lua:45 changeLevel
	At /mod/class/Game.lua:1664 
	At /engine/KeyBind.lua:241 
C Map minimap texture: 318 (50x50; 64x64)
Using cached font	/data/font/DroidSans.ttf	18
Lua Error: /mod/class/Player.lua:449: attempt to index local 'pf' (a nil value)
	At [C]:-1 __index
	At /mod/class/Player.lua:449 updateMainShader
	At /mod/class/Game.lua:1468 onRegisterDialog
	At /engine/Game.lua:329 registerDialog
	At /engine/Game.lua:247 tick
	At /engine/GameTurnBased.lua:44 tick
	At /mod/class/Game.lua:1141 
 ----------------  Stack Dump ----------------
--------------- Stack Dump Finished ---------------
Using cached font	/data/font/DroidSans.ttf	18
Lua Error: /mod/class/Player.lua:449: attempt to index local 'pf' (a nil value)
	At [C]:-1 __index
	At /mod/class/Player.lua:449 updateMainShader
	At /mod/class/Game.lua:1468 onRegisterDialog
	At /engine/Game.lua:329 registerDialog
	At /engine/Game.lua:247 tick
	At /engine/GameTurnBased.lua:44 tick
	At /mod/class/Game.lua:1141 
 ----------------  Stack Dump ----------------
--------------- Stack Dump Finished ---------------
Using cached font	/data/font/DroidSans.ttf	18
Lua Error: /mod/class/Player.lua:449: attempt to index local 'pf' (a nil value)
	At [C]:-1 __index
	At /mod/class/Player.lua:449 updateMainShader
	At /mod/class/Game.lua:1468 onRegisterDialog
	At /engine/Game.lua:329 registerDialog
	At /engine/Game.lua:247 tick
	At /engine/GameTurnBased.lua:44 tick
	At /mod/class/Game.lua:1141 
 ----------------  Stack Dump ----------------
--------------- Stack Dump Finished ---------------

[Doctornull]

After clearing out all addons (except my own), I'm unable to reproduce this bug.

I'll put addons back slowly and see if I can find what breaks the shader... maybe.
Or not.

Either way, it seems like the error was not 1.2b8's fault

[Marson]

updateMainShader() gets called in 1.1.5 in 26 places, but in 1.2 that function assigns game.posteffects to pf—which only exists in 1.2
pf will end up nil in any addons that haven't been updated.

[Doctornull]

updateMainShader() gets called in 1.1.5 in 26 places, but in 1.2 that function assigns game.posteffects to pf—which only exists in 1.2
pf will end up nil in any addons that haven't been updated.

Argh, now I have to wonder which addon class or race this was.

Thanks Marson!