Null Tweaks 2014-12-04: Rocks and Stones

[Doctornull]

I like everything about this Mod but the poison talent changes. Could you please add an option to make it back to vanilla?

That may take a while, but I'll try.

[Spleenling]

I like everything about this Mod but the poison talent changes. Could you please add an option to make it back to vanilla?

That may take a while, but I'll try.

Thank you

[Doctornull]

Timed Effects

An option will toggle this fix. The fix is to change the on_merge behavior of some timed effects to use the maximum of (old duration, new duration) rather than their average duration (old+new)/2. This results in less wonky results from multiple different burn effects, and results in more sensible behavior when you are suffering from an effect which is about to expire.

For example, in the old code if you had 1 turn left of being on fire, any new Burning duration would be halved (and the damage per turn DOUBLED). When you are being set on fire by multiple opponents, like a pack of fire dragons, this can result in silly and unintended damage per turn.

The fix is to always use the maximum duration. In both cases total damage is conserved: if you would suffer from 100 total fire damage, you will still suffer from 100 total fire damage either way.

Affected effects are: Burning, Cut, Wasting, Manasurge, Restless Night, and (when it exists in 1.2) Lightburn.

[Orangeflame]

(Using grayswandir's weapon pack)
Whips use exotic weapons mastery by default... and Nulltweaks is (not so) helpfully turning that into greatweapon mastery instead of agile mastery.

[Doctornull]

(Using grayswandir's weapon pack)
Whips use exotic weapons mastery by default... and Nulltweaks is (not so) helpfully turning that into greatweapon mastery instead of agile mastery.

If you're using that option in Nulltweaks, then whips do not use Exotic Mastery, and in fact Exotic Mastery no longer exists... so I'm not sure what's going on if you see Exotic anywhere.

Using only Nulltweaks and grayswandir's weapons pack, I'm only able to see Agile Mastery on any whips.

What other addons are you using?

[Orangeflame]

Updated both addons, started a new game, and whips use Agile Mastery now

[Doctornull]

Updated both addons, started a new game, and whips use Agile Mastery now

Yay!

[Umbrall]

I like how if you had used my merge, t = round((dam1*t1 + dam2*t2)/(t1 + t2)), then it fixes every problem you mention in the text while simultaneously not having wonky behaviour that makes more burning slow it down.

[Doctornull]

I like how if you

Passive-aggressive whining is not on topic.

We discussed this in IRC and your case was not convincing.

Please drop it.

[Umbrall]

You're being very aggressive, it was very much on topic, your reasons ironically apply the least to the burning you've mentioned in the title.

Also this was significantly less aggressive than you were, I was playfully mentioning it and how it was amusing that mine was more effective at the goals you stated.

My case was very convincing. You alternated between being convinced and having one minor issue and arbitrarily dismissing it because you were confused. And now suddenly this has become an issue that I don't want to continue because I had to give a response there.

[nox1999]

vulnerability poison error.

Lua Error: /engine/interface/ActorTalents.lua:77: bad argument #2 to 'info' (number expected, got nil)
At [C]:-1
At [C]:-1 info
At /engine/interface/ActorTalents.lua:77 info
At /mod/class/Actor.lua:4517 getTalentFullDescription
At /mod/dialogs/UseTalents.lua:317 generateList
At /mod/dialogs/UseTalents.lua:67 init
At /engine/class.lua:97 new
At /mod/class/Game.lua:1720 f
At /mod/class/Game.lua:1494
At /engine/KeyBind.lua:235

[Doctornull]

And now suddenly this has become an issue that I don't want to continue

Excellent!

vulnerability poison error.

Not excellent at all!

This is my bug, I'll push a fix after some testing.

[Doctornull]

vulnerability poison error.

Fix posted. Please let me know if you have further issues!

Thanks.

[pheonix89]

Is this 1.20 compatible?

[Doctornull]

Is this 1.20 compatible?

Not guaranteed to be yet. I'll post an update when it's fully tested.

If you're testing it with 1.2, please do let me know if you find any bugs. Thanks!