[b43, 1.0.4] Improve AI and aggro detection for Fillarel

[Crim, The Red Thunder]

Upon having my first character to Successfully reach the east, after slaying Krogar, leaving Fillarel almost completely unscathed, she turns and begins to attack ME. While I was VERY careful to make sure none of my bombs reached far enough to hit her, she somehow acquired a personal dislike of me. (-50)

As near as chatlog was able to figure out, somehow, she must have attacked my golem with an AoE spell, apparently reflecting some portion of that damage onto her. SOMEHOW, this apparently causes her to attack and blame ME for her own stupidity. PLEASE, either adjust the AI targeting for her, or adjust her hostility detection to prevent her from breaking her own unlock. Hardly seems fair for her to blame me for her actions...

[5k17]

This looks more like a problem of the golem's damage reflection than of Fillarel. Either it shouldn't reflect damage to friendlies at all or it shouldn't turn them hostile.

[darkgod]

fixed

[Crim, The Red Thunder]

Necroing this for [1.0.4]. Bug has returned.

Same problem. I entered the east, alchemist as my character, golem by my side, reflective skin is on. I kill krogar, and realize that Fillarel has turned hostile. Despite this, I didn't attack her. AGAIN.

Attaching log. (Edit: Can't attach, too big. Been playing for a while) Uploaded here instead: http://www.sendspace.com/file/4twr2v

Please fix this... again.

[Hachem_Muche]

This bug is caused by a typo in the NPC definition. A quick search shows that the same typo occurs in a few other places (Grand Corruptor, Slasul). Here's a patch to fix these:

Code: Select all

 game/modules/tome/data/chats/slasul.lua                 | 2 +-
 game/modules/tome/data/quests/anti-antimagic.lua        | 2 +-
 game/modules/tome/data/zones/town-zigur/npcs.lua        | 2 +-
 game/modules/tome/data/zones/unremarkable-cave/npcs.lua | 2 +-
 4 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/game/modules/tome/data/chats/slasul.lua b/game/modules/tome/data/chats/slasul.lua
index 0f11ca3..a02962f 100644
--- a/game/modules/tome/data/chats/slasul.lua
+++ b/game/modules/tome/data/chats/slasul.lua
@@ -97,7 +97,7 @@ In return let me offer you this powerful trident.]],
 				game.level.map:particleEmitter(npc.x, npc.y, 1, "demon_teleport")
 				game.level.map:particleEmitter(player.x, player.y, 1, "demon_teleport")
 				npc.invulnerable = 1
-				npc.never_angry = 1
+				npc.never_anger = 1
 				player:setQuestStatus("temple-of-creation", engine.Quest.COMPLETED, "legacy-naloren")
 			end
 		end},
diff --git a/game/modules/tome/data/quests/anti-antimagic.lua b/game/modules/tome/data/quests/anti-antimagic.lua
index b87ff10..a21a013 100644
--- a/game/modules/tome/data/quests/anti-antimagic.lua
+++ b/game/modules/tome/data/quests/anti-antimagic.lua
@@ -126,7 +126,7 @@ myssil_dies = function(self)
 	if not corr then return end
 
 	corr:doEmote("Victory is mine!", 60)
-	corr.never_angry = nil
+	corr.never_anger = nil
 	game.player:setQuestStatus(self.id, self.COMPLETED)
 end
 
diff --git a/game/modules/tome/data/zones/town-zigur/npcs.lua b/game/modules/tome/data/zones/town-zigur/npcs.lua
index efae58d..4c0761e 100644
--- a/game/modules/tome/data/zones/town-zigur/npcs.lua
+++ b/game/modules/tome/data/zones/town-zigur/npcs.lua
@@ -31,7 +31,7 @@ newEntity{ base = "BASE_NPC_ELVEN_CASTER", define_as = "GRAND_CORRUPTOR",
 	level_range = {30, nil}, exp_worth = 1,
 	rank = 3.5,
 	max_vim = 800,
-	never_angry = 1,
+	never_anger = 1,
 	max_life = resolvers.rngavg(300, 310), life_rating = 18,
 	resolvers.equip{
 		{type="weapon", subtype="staff", forbid_power_source={antimagic=true}, autoreq=true},
diff --git a/game/modules/tome/data/zones/unremarkable-cave/npcs.lua b/game/modules/tome/data/zones/unremarkable-cave/npcs.lua
index 7ba88b2..1c38af7 100644
--- a/game/modules/tome/data/zones/unremarkable-cave/npcs.lua
+++ b/game/modules/tome/data/zones/unremarkable-cave/npcs.lua
@@ -45,7 +45,7 @@ newEntity{ define_as = "FILLAREL",
 	instakill_immune = 1,
 	teleport_immune = 1,
 	move_others=true,
-	never_angry=true,
+	never_anger=true,
 
 	body = { INVEN = 10, MAINHAND=1, OFFHAND=1, BODY=1 },
 	equipment = resolvers.equip{