[SVN] Describe Elandar's Irresistable Sun immunity

[SageAcrin]

Although, I'm not really sure why Elandar's got universal Irresistable Sun immunity in SVN; This may be better placed in bugs, given the comment implies that it's there to prevent Argoniel's Sun from messing up Elandar...

But if I read the code right, Elandar's totally immune to anyone's Irresistable Sun, which should at least be a listed immunity somewhere.

[Torokasi]

Wait, if Elandar immunes Argoniel's new trick anyway (he should - Irresistable Sun doesn't have friendly fire) then why is he getting immunity to this? It basically neuters Aeryn's already poor offense and any PC running the prodigy is suddenly lacking an offensive option against him. This seems sorta silly. :/

[Theyleon]

It's called Irresistible Sun, how can anyone logically resist it

[Mewtarthio]

He appears to be immune only to the pulling effect, not the damage.

[SageAcrin]

Code: Select all

			if not tgts[target] then
				tgts[target] = true
				if not target:attr("ignore_irresistible_sun") then
					local ox, oy = target.x, target.y
					target:pull(self.x, self.y, 1)
					if target.x ~= ox or target.y ~= oy then 
						game.logSeen(target, "%s is pulled in!", target.name:capitalize()) 
					end

					if self:reactionToward(target) < 0 then
						local dam = eff.dam * (1 + (5 - core.fov.distance(self.x, self.y, target.x, target.y)) / 8)
						DamageType:get(DamageType.FIRE).projector(self, target.x, target.y, DamageType.FIRE, dam/3)
						DamageType:get(DamageType.LIGHT).projector(self, target.x, target.y, DamageType.LIGHT, dam/3)
						DamageType:get(DamageType.PHYSICAL).projector(self, target.x, target.y, DamageType.PHYSICAL, dam/3)
					end
				end
			end

I might be reading the order of operations wrong, but it looks like it checks for immunity and then just skips everything in the middle, which includes the damage.

Of course, if it's just the pulling, it still ought to have some description to it.

(I'm not sure why this is necessary in general, unless it's some strange way to buff Elandar. Wouldn't it be easier to make the pull also have the friendlies check, and ditch a special flag check? There's no pet classes that normally build Strength, so making it more summon friendly wouldn't have much of a bad impact...)

[Mewtarthio]

Looks like you're right. My mistake; I misjudged the indentation there.