[git] game freezes after engaging adventurere party

[MisiuPysiu]

Hi,

In the latest git version after engaging some adventurer group on the world map, the game freezes. The adventurer zone doesn't load.

I tried, and reproduced this bug without any addons installed, with the latest git version.

Cheers.

[darkgod]

Cant seem to reproduce, can you reupdate, recompile the exe and try again please ?

[MisiuPysiu]

yeah, this may be caused by my old version of the exe files

I will try with a newer version and report back.

Cheers.

[MisiuPysiu]

Hmm,

Used the latest .exe files (generated today by johnnyzero). but the problem still occurs. I tried a new character, still the same. I don't know, I haven't compiled the .exe files by myself so I can't tell if the problem lies there.

Cheers.

[johnnyzero]

I can't reproduce the issue.
I'm on git master, commit 0ff7f01cc16988ea78ce58da00357b0b3c23d5a5.

When was the last time you did a git pull? The binary I posted earlier today won't work with lua from earlier revisions in the master branch (i.e., you have to be at least on the commit mentioned in the binary).

[MisiuPysiu]

Hmm,

I pulled the git today (using TortoiseGit), together with the ego item changes.
I copied all the files from Your zipped file into the t-engine4 directory. I used to do so for the last year, when different binaries were compiled (tried to do it by myself but failed miserably twice).

To reproduce, I created a new berserker lev 1 and went to the world map. Engaged the first adventure party i found.
The progress bar is just filling up and cleaning (going to 100% and back to 0%) over and over again and nothing happens

No addons are beeing used.

[MisiuPysiu]

Just noticed, the same behavior occurs when you want to enter the ruined dungeon.
And this time my 24 lev solipsist is gone. The game saved on an non existing level - save is broken

[darkgod]

I'll need the te4_log.txt file then (oh and do run wioth the flush log option please)

[MisiuPysiu]

Here is the file,

te4_log.txt

(118.71 KiB) Downloaded 372 times

cheers

[johnnyzero]

Thanks for the log.

My hunch seems to be correct. I converted these .txt files to DOS format line endings (CRLF) from unix line endings (LF) and see the same behavior as you. On my machine, I cloned the repository with cygwin's git, which left the .txt files with unix line endings. Darkgod uses linux for his development, so it makes sense that he wouldn't see the issue either.

For a short-term fix, MisiuPysiu, you will want to make sure you're cloning/checking out T-Engine with Unix/LF line endings. I think you can set this option with the Git for Windows installer.

This link explains project line endings in more detail. Darkgod, you might want to set the .gitattributes file for the project to make sure that unix line endings are always used (since t-engine is sensitive to them).

[MisiuPysiu]

hey,

this seems to be a perfect explenation for the bug. Im in the middle of cloning the git repository without crlf conversion. Hope this will help:)

Thanks a lot for the help:)

Cheers.

[Hachem_Muche]

Ahah! This is the same error I reported here: http://forums.te4.org/viewtopic.php?f=42&t=38172

Johnny, what is the exact syntax for the "Unix/LF line endings" you're talking about? I can't find any option like it in Tortoise Git's Windows GUI interface.

I worked around this problem by manually copying the text files in the mod.data.languages.names directory from the 1.0.4 release into my local repository.

[johnnyzero]

Tortoisegit looks to require msysgit, so load up a git bash shell (found in your start menu), cd to your t-engine checkout, and enter the following command:

Code: Select all

git config core.autocrlf false

or you can set up your git install to globally disable line ending conversion:

Code: Select all

git config --global core.autocrlf false

You'll have to reset or re-checkout the project. Check out the link I posted earlier for more info.

[Hachem_Muche]

Fixed, thanks.

For windows users, the procedure is to go to the settings screen and open up Git settings. Then click "Edit global .gitconfig" to open up the global config file and add:

Code: Select all

[core]
	autocrlf = false

Edit: Found the button to select "AutoCrlf" also need to set "SafeCrtlf" to true or else Git will mess up patches as it flags every line as different.

[darkgod]

I fixed the file reader to correctly understand \r\n (it's still a bad idea to use windows line endings, it's dirty)