Conflicting egos on items [1.0]

[b0rsuk]

1. Weapon egos causing an effect on critical hit can overwrite each other, so only 1 critical hit effect is possible. Example:
Caustic mace of crippling (only acid splash)

2. Items granting activated talents overwrite as well.
Archer's gloves of the Juggernaut (only Steady Shot)

3. The stamina leeching effect of "leech" weapons doesn't seem to work at all, unless it's just meant to lower their stamina without increasing mine.

4. I vaguely remember that on-hit effects (elemental longsword of torment) are also affected. Only one on-hit effect is present on the weapon.

As for #1 and #2, if it's working as intended, then at least exclude these items from shops. They are priced like fully functional items, a newbie trap.

[Hachem_Muche]

This is caused during object resolution by the table.merge function overwriting indices with the same name, in this case, combat.special_on_crit.

To fix this, the egos.combat field special_on_crit would need to be converted into a subtable so that .merge could merge multiple instances. This would affect the ego defintions for a number of types of egos. In addition, the combat code would need to be updated to run through the (potential) list of functions produced.

In addition to .special_on_crit, this bug (probably, I haven't tested them) affects .special_on_hit, .burst_on_hit, .burst_on_crit, and others. This could be a bit of work depending on the approach.

DarkGod, I can put together a patch to do this, depending on what you want.