Online addon check failure

[aardvark]

I recently posted a couple of my addons to the te4.org addon page in response to several requests to do so. I'm given to understand that addons can't be used online unless they're so posted. The problem is that even though I've posted them, people still complain that they fail validation. I've triple checked the addons' MD5 hashes against te4_log.txt; they are identical (copied and pasted from there, in fact).

The only thing I can figure is that something is failing on the server. Without access to the server code, I can only guess at the problem.

Everything is right on my end. What gives?

[daftigod]

aardvark,

if you have been editing your addon with ToME still open, the new md5 hash is added to the end of the te4.log, without deleting the old md5 hash. Make sure that you are either 1.) using the most recent m5 hash for your addon at the end of te4.log (search for md5 until you get to the last one), or 2.) restart ToME before you pull the m5 hash out of the log file, which guaruntees that the log file will be overwritten with a fresh version.

Hope this helps

[aardvark]

if you have been editing your addon with ToME still open, the new md5 hash is added to the end of the te4.log, without deleting the old md5 hash.

That's useful to know, but no. It's from a clean restart of ToME after copying the zipped and renamed addon to the proper directory.

I have the terrible suspicion that the problem is the server side code making unsafe assumptions about module and addon names.

[darkgod]

Unsafe as in ?

[aardvark]

Assumptions about what characters will be in a module or addon name? In another thread, lukep mentioned that he didn't think addon names could have hyphens. I replied that mine all did and worked fine, but since I'd never tried them online before....

When I checked Module.lua and PlayerProfile.lua, I found it sent the addon name to the server as "[module short_name]-[addon short_name]-x.y.z", where x, y, and z are the version numbers. If the server is splitting the composite addon name on the dashes, mine (tome-lib-fix-1.0.0) would be chopped to bits.

This is purely speculation on my part, but it's my first thought when so many people report problems.

[darkgod]

Well, in the case of the library fix addon, your page on te4.org says short_name to be "lib_fix" while the init.lua says it's "lib-fix".
And the page when you edit does say you should only use _
This is indicative actually, anything will work: as long as you use the same short_name everywhere !

[omero]

After the clarifications in the other thread http://forums.te4.org/viewtopic.php?f=42&t=36491,
I started a new character, but this is what I get on 'stdout':

Code: Select all

[LOG]   #LIGHT_RED#Online profile disabled(switching to offline profile) due to bad game addon version [addon: lib-fix].

[aardvark]

Well, in the case of the library fix addon, your page on te4.org says short_name to be "lib_fix" while the init.lua says it's "lib-fix".
And the page when you edit does say you should only use _
This is indicative actually, anything will work: as long as you use the same short_name everywhere ! :)

Well... belgium! You're right and I was wrong. Not sure how I mistyped it and missed the discrepancy on the recheck. I've changed it to "lib-fix" to match the file.

Out of curiosity, if any characters work, why the "only letters and underscores" admonishment?

[shonen]

Does this mean we can re-download the two plugins and they'll work in online mode now? It still shows a 2/9 upload date on the addons page.

BTW, thanks for taking the time to post these, the Lore library issue is a pain.

S

[aardvark]

Does this mean we can re-download the two plugins and they'll work in online mode now?

You shouldn't even need to re-download anything. The library fix should work now (if not, I want to know about it) and the unlearning fix should have worked before (having been done correctly the first time, I think).

[darkgod]

Well, in the case of the library fix addon, your page on te4.org says short_name to be "lib_fix" while the init.lua says it's "lib-fix".
And the page when you edit does say you should only use _
This is indicative actually, anything will work: as long as you use the same short_name everywhere !

Well... belgium! You're right and I was wrong. Not sure how I mistyped it and missed the discrepancy on the recheck. I've changed it to "lib-fix" to match the file.

Out of curiosity, if any characters work, why the "only letters and underscores" admonishment?

Well the server doesnt care; however the OS might care which characters are allowed in a filename; so better be safe than sorry

[shonen]

Still no luck...

lib-fix-error.png (35.74 KiB) Viewed 2724 times

Could be me, it's 2AM and I'm killing off characters with dumb mistakes, but I can't see what I could do wrong.

S

[omero]

Still no luck...

Same here and I did remove previous addon version and downloaded it again just to be on the safe side.

Code: Select all

[LOG]   #LIGHT_RED#Online profile disabled(switching to offline profile) due to bad game addon version [addon: lib-fix].

[daftigod]

needs to be named tome-*.teaa

or tome-lib-fix.teaa

[shonen]

needs to be named tome-*.teaa

or tome-lib-fix.teaa

... that's in init.lua? I just tried that, but it merely caused the entire module not to be recognized. Was hoping that wouldn't be included in the checksum.

shonen