[svn] Sometimes impossible to unlearn last 4 talents

[supermini]

I can't really figure out if this happens randomly or if there's a connection to something I'm doing but sometimes it's impossible to unlearn last 4 class talents. Today I've tried to do an arcane/aether mage run in the ID and put 4 points into flame until I get manathrust. I even removed points from flame every level and made sure that those 4 were the last points I put in. On level 7, I could only unlearn 3 class talent points. I double checked to make sure if I didn't make any mistakes, but no, I can only unlearn 3 points in total, and none of the talents I invested in have 'change the world permanently so they can't be unlearned etc.' I've kept some points in reserve (didn't spend all my class points), so maybe that's causing it?

I kept a copy of the save game if it helps.

[johnnyzero]

I've noticed this too. I think this triggers at character creation. As an example, I'll use my standard starting arcane blade build:

Non-bugged method

1. Start an arcane blade
2. Place my stat points as required (12 str, 14 mag)
3. Pick talents in the following order: rush, flame, flame, lightning, lightning
4. Pick generics
5. Save and begin playing

If I make no mistakes in the order I pick talents, the character will play fine and I'll be able to remove flame/lightning skill levels later on. However, if I accidentally pick flame first before rush and do the following procedure, the flame talent tends to be locked-in as I gain levels:

Bugged method

1. Start an arcane blade
2. Place my stat points as required (12 str, 14 mag)
3. Pick in the following order (flame, remove flame, rush, flame, flame, lightning, lightning)
4. Pick generics
5. Save and begin playing

With this method I can usually remove flame/lightning at level 1 as expected. However, if I put them back in and try to float the four talent points, eventually one point will become stuck in flame as I level up. If I reuse a character generated with the "bugged method" via new game -> load premade, I see the same buggy behavior.

[supermini]

That seems consistent with how flame got stuck on my arcane mage.

[johnnyzero]

I just got this to happen outside of birth.

I've been fairly paranoid about this and usually exit out of the level up screen (answer no to save changes) if I make a mistake picking my talents. I did something similar to bugged method, step #3 around level 8 and a few levels later flame was locked in at 1/5.

The reason why I've noticed it so many times at character creation is that during creation it's not possible to exit the level up dialog without saving.

[Tyren]

I can unlearn only 1 generic talent level. I equipped Eden's Guile and 2 generics got stuck. SVN 5972.

[johnnyzero]

Bump for RC1.

I can unlearn only 1 generic talent level. I equipped Eden's Guile and 2 generics got stuck. SVN 5972.

I see this same behavior immediately after equipping eden's guile. Cunning/survival's heightened senses and charm mastery always turn into a "recently learned" talent.

[supermini]

Hmm, it should probably be tested if amulets of mastery do this as well.

[aardvark]

It's because setTalentTypeMastery() calls updateTalentTypeMastery() which calls unlearnTalent() and learnTalent() to recompute the bonuses from passive talents like those on the boots. Relearning those passives puts them on the top of the unlearn stack. This bug probably triggers any time a category with passives has its mastery changed in any way, including spending category points and wearing mastery affecting items.

[darkgod]

Oh! nice find! Thanks
Fixing