[SVN] Coral Spray yields error when countering attacks

[belmarduk]

Code: Select all

[ATTACK] attacking with	iron battleaxe of vileness
[ATTACK] to 	Wendigo	 :: 	24.452772912031	1	31.241213927703	0	::	1
checkHit	16	0
=> chance to hit	90
[ATTACK] raw dam	24.452772912031	versus	31.241213927703	0.5	with APR	1
[ATTACK] after armor	12.226386456015
[ATTACK] after range	12
[PHYS CRIT %]	100
[ATTACK] after crit	18
[ATTACK] after mult	18
[LOG]	#{bold}#Ben Cruthdar, the Cursed performs a critical strike!#{normal}#
[PROJECTOR] starting dam	18
[PROJECTOR] after difficulty dam	18
[PROJECTOR] starting dam	30
[PROJECTOR] after difficulty dam	30
[PROJECTOR] res	3.7180687992294	0.96281931200771	 on dam	30
[PROJECTOR] after resists dam	28.884579360231
[PROJECTOR] after flat damage armor	28.884579360231
[PROJECTOR] final dam	28.884579360231
stack traceback:
	[C]: in function 'error'
	/engine/interface/ActorTalents.lua:135: in function </engine/interface/ActorTalents.lua:126>
Lua Error: /engine/interface/ActorTalents.lua:143: /engine/interface/ActorTalents.lua:135: /data/general/objects/world-artifacts.lua:4779: attempt to perform arithmetic on field 'x' (a nil value)
stack traceback:
	/data/general/objects/world-artifacts.lua:4779: in function 'check'
	/data/timed_effects/physical.lua:1742: in function 'do_block'
	/data/damage_types.lua:63: in function 'projector'
	/mod/class/interface/Combat.lua:437: in function 'attackTargetWith'
	/mod/class/interface/Combat.lua:156: in function 'attackTarget'
	/data/talents/cursed/strife.lua:63: in function </data/talents/cursed/strife.lua:47>
	[C]: in function 'xpcall'
	/engine/interface/ActorTalents.lua:131: in function </engine/interface/ActorTalents.lua:126>
	At [C]:-1 
	At [C]:-1 error
	At /engine/interface/ActorTalents.lua:143 useTalent
	At /mod/ai//tactical.lua:378 runAI
	At /mod/ai//tactical.lua:403 doAI
	At /mod/class/NPC.lua:47 act
	At /engine/GameEnergyBased.lua:131 tickLevel
	At /engine/GameEnergyBased.lua:62 tick
	At /engine/GameTurnBased.lua:46 tick
	At /mod/class/Game.lua:1015 
 ----------------  Stack Dump ----------------
2: table // e35df8
1: table // e35df8
--------------- Stack Dump Finished ---------------

This occured when using Block with the Coral Spray artefact equipped as a dwarf wyrmic. This is reproducable, but doesn't appear to happen on every block/counter.

caveat: I'm still using an old exe, so it's possible this is entirely the fault of how my client is set up.

[darkgod]

fixed

[johnnyzero]

I just encountered this in svn-5779. Happened when a monster blocked against me using Coral Spray and later on when I blocked against an enemy.

Code: Select all

[LOG]	Nubsie uses Block.
addTmpVal	table: 0x05572020	block	48	 :=: 	2	1493	add
addTmpVal	table: 0x05572020	combat_def	-48	 :=: 	2	1494	add
addTmpVal	table: 0x05572020	combat_def_ct	48	 :=: 	2	1495	add
[ATTACK] attacking with	arcing iron longsword of paradox
[ATTACK] to 	Nubsie	 :: 	23.585199486573	2	29.894285931467	0	::	1
checkHit	18	0
=> chance to hit	95
[ATTACK] raw dam	23.585199486573	versus	29.894285931467	0.465	with APR	2
[ATTACK] after armor	12.618081725317
[ATTACK] after range	16
[PHYS CRIT %]	0
[ATTACK] after crit	16
[ATTACK] after mult	16
[PROJECTOR] starting dam	16
[PROJECTOR] after difficulty dam	16
[PROJECTOR] starting dam	30
[PROJECTOR] after difficulty dam	30
[PROJECTOR] res	15	0.85	 on dam	33.3
[PROJECTOR] after resists dam	28.305
[PROJECTOR] after flat damage armor	28.305
[PROJECTOR] final dam	28.305
stack traceback:
	[C]: in function 'error'
	/engine/interface/ActorTalents.lua:135: in function </engine/interface/ActorTalents.lua:126>
Lua Error: /engine/interface/ActorTalents.lua:143: /engine/interface/ActorTalents.lua:135: /data/general/objects/world-artifacts.lua:4784: attempt to perform arithmetic on field 'x' (a nil value)
stack traceback:
	/data/general/objects/world-artifacts.lua:4784: in function 'check'
	/data/timed_effects/physical.lua:1742: in function 'do_block'
	/data/damage_types.lua:63: in function 'projector'
	/mod/class/interface/Combat.lua:437: in function 'attackTargetWith'
	/mod/class/interface/Combat.lua:156: in function 'attackTarget'
	/data/talents/misc/misc.lua:71: in function </data/talents/misc/misc.lua:51>
	[C]: in function 'xpcall'
	/engine/interface/ActorTalents.lua:131: in function </engine/interface/ActorTalents.lua:126>
	At [C]:-1 
	At [C]:-1 error
	At /engine/interface/ActorTalents.lua:143 bumpInto
	At /mod/class/Actor.lua:2593 attack
	At /engine/interface/ActorLife.lua:41 check
	At [string "return function(self, x, y, what, ...) local ..."]:1 checkAllEntities
	At /engine/interface/ActorAI.lua:63 aiCanPass
	At /engine/interface/ActorAI.lua:85 runAI
	At /engine/ai//talented.lua:63 doAI
	At /mod/class/NPC.lua:47 act
	At /engine/GameEnergyBased.lua:131 tickLevel
	At /engine/GameEnergyBased.lua:62 tick
	At /engine/GameTurnBased.lua:46 tick
	At /mod/class/Game.lua:1015 
 ----------------  Stack Dump ----------------
2: table // 2bf5e38
1: table // 2bf5e38
--------------- Stack Dump Finished ---------------
AI took for target	125284	elven guard	::	1492	Nubsie	1	<	100

[darkgod]

fixed (for real ;> )

[johnnyzero]

svn-5783:

Code: Select all

stack traceback:
	[C]: in function 'error'
	/engine/interface/ActorTalents.lua:135: in function </engine/interface/ActorTalents.lua:126>
Lua Error: /engine/interface/ActorTalents.lua:143: /engine/interface/ActorTalents.lua:135: /engine/Particles.lua:55: cannot open /data/gfx/particles/breath_ice.lua: No error
stack traceback:
	[C]: in function 'error'
	/engine/Particles.lua:55: in function 'loaded'
	/engine/Particles.lua:35: in function 'init'
	/engine/class.lua:39: in function 'new'
	/engine/Map.lua:1072: in function 'particleEmitter'
	/data/general/objects/world-artifacts.lua:4784: in function 'check'
	/data/timed_effects/physical.lua:1742: in function 'do_block'
	/data/damage_types.lua:63: in function 'projector'
	/mod/class/interface/Combat.lua:437: in function 'attackTargetWith'
	/mod/class/interface/Combat.lua:190: in function 'attackTarget'
	/data/talents/misc/misc.lua:71: in function </data/talents/misc/misc.lua:51>
	[C]: in function 'xpcall'
	/engine/interface/ActorTalents.lua:131: in function </engine/interface/ActorTalents.lua:126>
	At [C]:-1 
	At [C]:-1 error
	At /engine/interface/ActorTalents.lua:143 useTalent
	At /engine/ai//talented.lua:51 runAI
	At /engine/ai//talented.lua:60 doAI
	At /mod/class/NPC.lua:47 act
	At /engine/GameEnergyBased.lua:131 tickLevel
	At /engine/GameEnergyBased.lua:62 tick
	At /engine/GameTurnBased.lua:46 tick
	At /mod/class/Game.lua:1015 
 ----------------  Stack Dump ----------------
2: table // 2bb5e38
1: table // 2bb5e38
--------------- Stack Dump Finished ---------------

At /data/general/objects/world-artifacts.lua:4784:

Code: Select all

game.level.map:particleEmitter(target.x, target.y, burst.radius, "breath_ice", {radius=burst.radius, tx=target.x-who.x, ty=target.y-who.y})

edit: I also noticed one more small issue...
At /data/general/objects/world-artifacts.lua:4785:

Code: Select all

game.logSeen(who, "A burst of chilling water launches from your shield to %s!", who.name:capitalize())

This logs in the message window, "A burst of chilling water launches from your shield to [source]!", rather than "... from your shield to [target blocked]!" Additionally, "A burst of chilling water launches from [source]'s shield to [target]!" might be better for clarity, since things other than the player can block with this artifact (other monsters, golems, etc.).

In any case, what a headache of an item.

edit 2: Here's a patch which seems to resolve the problems. "breath_ice" was changed to "breath_cold" and the game log was changed for clarity.

Code: Select all

Index: world-artifacts.lua
===================================================================
--- world-artifacts.lua	(revision 5791)
+++ world-artifacts.lua	(working copy)
@@ -4782,8 +4782,8 @@
 			local burst = {type="cone", range=0, radius=4, force_target=target, selffire=false,}
 		
 			who:project(burst, target.x, target.y, engine.DamageType.COLD, 30)
-			game.level.map:particleEmitter(target.x, target.y, burst.radius, "breath_ice", {radius=burst.radius, tx=target.x-who.x, ty=target.y-who.y})
-			game.logSeen(who, "A burst of chilling water launches from your shield to %s!", who.name:capitalize())
+			game.level.map:particleEmitter(target.x, target.y, burst.radius, "breath_cold", {radius=burst.radius, tx=target.x-who.x, ty=target.y-who.y})
+			game.logSeen(who, "A burst of chilling water launches from %s's shield to %s!", who.name:capitalize(), target.name:capitalize())
 		end
 	end,
 }