[b37] Talents automatically target yourself while frozen

[MarvinPA]

This results in instant, automatic suicide when firing a damage spell while frozen. I think in previous versions there was still the same interface problem, but it at least didn't deal damage to yourself? But changing the behaviour of a targeted spell to automatically fire at yourself seems like a pretty bad inconsistency either way.

[bricks]

Which spell? They should damage the ice block, yes. It might be a problem with a talent-specific mechanic or weird targeting code. If it's all spells, that's a problem.

[MarvinPA]

This was with Turn back the Clock in particular that caused the instant death.

[yufra]

Did you by chance have TbtC above level 4 so that there are two bolts?

[MarvinPA]

Yep.

[yufra]

Then this is the same problem as other talents that have multiple targeting. Thanks for the report, though.

[tiger_eye]

In the latest bugfix addon, you will get a chance to cancel target-able talents if you're in an iceblock. You will still only be able to target the iceblock though. This should help those with fat fingers or short memories.

[tiger_eye]

oops, but the following (very minor) change is needed:

Code: Select all

Index: game/modules/tome/class/Player.lua
===================================================================
--- game/modules/tome/class/Player.lua	(revision 4791)
+++ game/modules/tome/class/Player.lua	(working copy)
@@ -543,6 +543,9 @@
 --- Tries to get a target from the user
 function _M:getTarget(typ)
 	if self:attr("encased_in_ice") then
+		if type(typ) ~= "table" then
+			return self.x, self.y, self
+		end
 		local orig_range = typ.range
 		typ.range = 0
 		local x, y, act = game:targetGetForPlayer(typ)