Range of different attacks is not correct displayed

Where bugs go to lie down and rest

Moderator: Moderator

Post Reply
Message
Author
Tom
Spiderkin
Posts: 555
Joined: Wed Apr 27, 2011 11:04 pm

Range of different attacks is not correct displayed

#1 Post by Tom »

From another thread.

I got Spit Poison from a task.
Spit Poison has a MUCH longer range radius than is shown when I aim it.
When I did aim, I had perhaps 2 or 3 squares in blue, and then it was red including the X over the target, but the poison hit never the less.

Yesterday I tried to Rush an opponent. I aimed and all was blue, but the rush fizzled out and nothing happened without an explanation.
This might have been 5 or 6 tiles away. No obstacles beween me and the target.

Gray@ No, I am abolutely sure about the Rush display.
All in blue and no obstacle in between.

Tom

tiger_eye
Perspiring Physicist
Posts: 889
Joined: Thu Feb 17, 2011 5:20 am

Re: Range of different attacks is not correct displayed

#2 Post by tiger_eye »

Tom wrote:Yesterday I tried to Rush an opponent. I aimed and all was blue, but the rush fizzled out and nothing happened without an explanation.
This might have been 5 or 6 tiles away. No obstacles beween me and the target.
yeah, this can happen if you're near the edge of the range, and, yeah, it is a bug. In the targeting code, the range is allowable between source (x,y) and target (tx, tx) if "(tx-x)**2 + (ty-y)**2 < (range+0.5)**2", because this provides a very nice circle. However, many talents use their own check, which is "(tx-x)**2 + (ty-y)**2 < range**2". This was discussed a little bit here:

http://forums.te4.org/viewtopic.php?f=45&t=25019

and I think yufra and I discussed it a little more somewhere else too.

We'd like to use what the targeting code uses for everything, and I think the reason it hasn't been fixed yet is it needs to be fixed in a lot of places, and the work would be a little tedious and boring. Any volunteers? :wink:

tiger_eye
Perspiring Physicist
Posts: 889
Joined: Thu Feb 17, 2011 5:20 am

Re: Range of different attacks is not correct displayed

#3 Post by tiger_eye »

tiger_eye wrote:We'd like to use what the targeting code uses for everything, and I think the reason it hasn't been fixed yet is it needs to be fixed in a lot of places, and the work would be a little tedious and boring. Any volunteers? :wink:
Actually, now that I think I know where all these checks might be hiding, I volunteer myself :D.
Tom wrote:I got Spit Poison from a task.
Spit Poison has a MUCH longer range radius than is shown when I aim it.
When I did aim, I had perhaps 2 or 3 squares in blue, and then it was red including the X over the target, but the poison hit never the less.
Did you have clear line of sight of all tiles between yourself and the enemy, or were some tiles darkened?

Tom
Spiderkin
Posts: 555
Joined: Wed Apr 27, 2011 11:04 pm

Re: Range of different attacks is not correct displayed

#4 Post by Tom »

tiger_eye wrote:
tiger_eye wrote:We'd like to use what the targeting code uses for everything, and I think the reason it hasn't been fixed yet is it needs to be fixed in a lot of places, and the work would be a little tedious and boring. Any volunteers? :wink:
Actually, now that I think I know where all these checks might be hiding, I volunteer myself :D.
Tom wrote:I got Spit Poison from a task.
Spit Poison has a MUCH longer range radius than is shown when I aim it.
When I did aim, I had perhaps 2 or 3 squares in blue, and then it was red including the X over the target, but the poison hit never the less.
Did you have clear line of sight of all tiles between yourself and the enemy, or were some tiles darkened?
If any tiles where darkened I can not recall for sure.
But the area was open.

Tom
Spiderkin
Posts: 555
Joined: Wed Apr 27, 2011 11:04 pm

Re: Range of different attacks is not correct displayed

#5 Post by Tom »

tiger_eye wrote:
tiger_eye wrote:We'd like to use what the targeting code uses for everything, and I think the reason it hasn't been fixed yet is it needs to be fixed in a lot of places, and the work would be a little tedious and boring. Any volunteers? :wink:
Actually, now that I think I know where all these checks might be hiding, I volunteer myself :D.
Tom wrote:I got Spit Poison from a task.
Spit Poison has a MUCH longer range radius than is shown when I aim it.
When I did aim, I had perhaps 2 or 3 squares in blue, and then it was red including the X over the target, but the poison hit never the less.
Did you have clear line of sight of all tiles between yourself and the enemy, or were some tiles darkened?
Hmm.
Now that I think some more about it, it is possible that some tiles actually were darkened.
I often play with zero and no light radius and depend on the rogue skill Hightened Senses which makes your suspicions very probable.

kyuubee
Thalore
Posts: 136
Joined: Wed Jun 22, 2011 10:11 pm

Re: Range of different attacks is not correct displayed

#6 Post by kyuubee »

i just have the same problem with a doomed i tested on arena (btw it's not fair to spawn four level 30 monsters between many others in an ordinal wave against my level 18 char ><)

many of doomed talents couldn't be cast at the limit range (but with blue aiming line). i.e. it was written in the log that i cast them but 1) they did nothing 2) usually they didn't set cooldown. also blast aiming is really misleading, when i upgraded it to 5/5 i couldn't aim it without affecting myself, i.e. i could but i couldn't cast it and when i aimed it one tile closer i was in its area. so i was afraid to cast it thinking it could kill me (it seems it's safe to cast though unlike scatter shot)

lukep
Sher'Tul Godslayer
Posts: 1712
Joined: Mon Mar 14, 2011 10:32 am
Location: Canada

Re: Range of different attacks is not correct displayed

#7 Post by lukep »

Blast does not affect you, but you can still be hit by monsters being knocked out from the centre and into you.
Some of my tools for helping make talents:
Melee Talent Creator
Annotated Talent Code (incomplete)

Post Reply