[1.7.4] [Forbidden Cults] 2 Split damage reduction bugs
Posted: Sun Sep 19, 2021 1:29 pm
The talent Split applies an effect Split to the target who is split. This effect reduces both the damage they deal and the damage they take. Here are 2 bugs with the reduction of damage that the target takes:
1) The tooltip of the effect always says that the reduction of damage they take is 10%, instead of the value shown in the talent tooltip and used for the functionality of the effect (in the callbackOnHit). This happens because the talent's code to apply the effect and the effect's code to reduce damage taken call the parameter "resist", but the effect's tooltip expects a parameter called "power", and so it uses the default value, power = 10.
2) The formula used in the callbackOnHit is
which simplifies to
So despite the talent's tooltip saying "All damage taken will be reduced by 76%, 70%, 66%, 63%, 60%", it actually works as "All damage taken will be reduced to 76%, etc". (i.e. the target would take 76% of incoming damage, not 24% as you would expect from the tooltip.)
To fix the effect to match the tooltip, the formula could be changed to
1) The tooltip of the effect always says that the reduction of damage they take is 10%, instead of the value shown in the talent tooltip and used for the functionality of the effect (in the callbackOnHit). This happens because the talent's code to apply the effect and the effect's code to reduce damage taken call the parameter "resist", but the effect's tooltip expects a parameter called "power", and so it uses the default value, power = 10.
2) The formula used in the callbackOnHit is
Code: Select all
cb.value = cb.value - (cb.value * (1 - eff.resist/100))Code: Select all
cb.value = cb.value * eff.resist/100To fix the effect to match the tooltip, the formula could be changed to
Code: Select all
cb.value = cb.value * (1 - eff.resist/100)