Steady Shot Doesn't Auto-Use Correctly Without Master Marksman
Posted: Fri Jun 04, 2021 1:33 am
When Steady Shot is available, Shoot will use it automatically.
What this actually does is set Shoot's mark chance and damage to match Steady Shot's, and then put it on cooldown.
When you have Master Marksman, Shoot gains a 15% mark chance. Coincidentally, Steady Shot has a 15% mark chance hard coded, and then a getBonusMark function that adds 5 and a scaling value to it.
When you use Steady Shot through Shoot, Shoot adds getBonusMark to its default 15% mark chance.
-Except before it does that, it says "Do we know Master Marksman? No? Then we can't mark." even though it's currently doing a Steady Shot impression.
This problem is easily avoided by:
-Using Steady Shot manually.
-Taking Master Marksman.
This problem could be easily fixed by:
-Moving a few lines of code outside of an If conditional
-having it be "if self:knowTalent(self.T_MASTER_MARKSMAN) or self.mark_steady then"
This problem exists for:
-Any adventurer
-Archers who unlearn their mastery talent I guess? You can probably do that?
-Probably people with the "auto-assign talent points on chargen" button turned off
What this actually does is set Shoot's mark chance and damage to match Steady Shot's, and then put it on cooldown.
When you have Master Marksman, Shoot gains a 15% mark chance. Coincidentally, Steady Shot has a 15% mark chance hard coded, and then a getBonusMark function that adds 5 and a scaling value to it.
When you use Steady Shot through Shoot, Shoot adds getBonusMark to its default 15% mark chance.
-Except before it does that, it says "Do we know Master Marksman? No? Then we can't mark." even though it's currently doing a Steady Shot impression.
This problem is easily avoided by:
-Using Steady Shot manually.
-Taking Master Marksman.
This problem could be easily fixed by:
-Moving a few lines of code outside of an If conditional
-having it be "if self:knowTalent(self.T_MASTER_MARKSMAN) or self.mark_steady then"
This problem exists for:
-Any adventurer
-Archers who unlearn their mastery talent I guess? You can probably do that?
-Probably people with the "auto-assign talent points on chargen" button turned off