Riposte do not increase Counterstrike duration
Posted: Fri May 07, 2021 3:57 pm
Hi!
The talent description of Riposte says:
" Increases the duration of the counterstrike debuff on attackers by 1, 1, 1, 2, 2 turn, turn, turn, turns, turns."
BUT, in the code these is no such thing:
(It is called in the timed effects/physical -> blocking effect)
src:setEffect(src.EFF_COUNTERSTRIKE, 2, {power=eff.power, no_ct_effect=true, src=self, crit_inc=crit_inc, nb=nb})
The duration is a fixed 2 turns.
Interestingly, in game version 1.5 Riposte did increase the duration:
(from 1.5.10)
src:setEffect(src.EFF_COUNTERSTRIKE, (1 + dur_inc) * math.max(1, (src.global_speed or 1)), {power=eff.power, no_ct_effect=true, src=self, crit_inc=crit_inc, nb=nb})
But in 1.6 this was changed somehow, despite the talent still states it increases the duration.
Imo an increased duration would be still nice, due to the increased number of triggers.
The talent description of Riposte says:
" Increases the duration of the counterstrike debuff on attackers by 1, 1, 1, 2, 2 turn, turn, turn, turns, turns."
BUT, in the code these is no such thing:
(It is called in the timed effects/physical -> blocking effect)
src:setEffect(src.EFF_COUNTERSTRIKE, 2, {power=eff.power, no_ct_effect=true, src=self, crit_inc=crit_inc, nb=nb})
The duration is a fixed 2 turns.
Interestingly, in game version 1.5 Riposte did increase the duration:
(from 1.5.10)
src:setEffect(src.EFF_COUNTERSTRIKE, (1 + dur_inc) * math.max(1, (src.global_speed or 1)), {power=eff.power, no_ct_effect=true, src=self, crit_inc=crit_inc, nb=nb})
But in 1.6 this was changed somehow, despite the talent still states it increases the duration.
Imo an increased duration would be still nice, due to the increased number of triggers.