HiddenBlade+assasinate apply twice the same bleeding
Posted: Tue May 23, 2017 12:51 pm
Looking at the hidden blade/assassinate code in cunning/Artifice, I noticed that there is dual application of the same bleed damage.
in hiddenblade
So hidden blade calls assassinate (if it is known), then applies a bleeding based on the life difference
But in assassinate....
... there is an attack and then the very same bleeding is also applied.
I assume this an error.
in hiddenblade
Code: Select all
newTalent{
name = "Hidden Blades",
...
callbackOnCrit = function(self, t, kind, dam, chance, target)
...
local oldlife = target.life
...
if self:knowTalent(self.T_ASSASSINATE) then
local scale = nil
scale = self:callTalent(self.T_ASSASSINATE, "getBleed")
local life_diff = oldlife - target.life
if life_diff > 0 and target:canBe('cut') and scale then
target:setEffect(target.EFF_CUT, 5, {power=life_diff * scale / 5, src=self})
end
end
self:startTalentCooldown(t)
...
}
But in assassinate....
Code: Select all
newTalent{
name = "Assassinate",
...
action = function(self, t)
...
local bleed = t.getBleed(self, t)
local oldlife = target.life
...
local do_attack = function() self:attackTarget(target, nil, t.getDamage(self, t), true, true) end
....
local life_diff = oldlife - target.life
if life_diff > 0 and target:canBe('cut') and bleed then
target:setEffect(target.EFF_CUT, 5, {power=life_diff * bleed / 5, src=self})
end
return true
end,
...
}:
I assume this an error.