Page 1 of 1
[Ember 1.0.3] Arcane Shield not triggering with HealingSalve
Posted: Fri Jul 22, 2016 4:34 am
by Relic
Arcane Shield talent says it triggers on a direct heal. Tinker Healing Salve heals ### health just like the healing inscriptions. The Tinker Healing Salve didn't trigger arcane shield to make a shield as the talent describes.
Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS
Posted: Fri Jul 22, 2016 4:52 am
by Effigy
I wonder if it's related to this bit from /data/general/objects/tinkers/therapeutics.lua:line 36
Code: Select all
resolvers.medical_salves("heal %d", 15, function(self, who)
self:attr("allow_on_heal", 1)
who:heal(self:getCharmPower(who), who)
self:attr("allow_on_heal", -1)
I don't know what the difference is between "self" and "who" in this context, but maybe allow_on_heal should be getting set on who instead of self.
Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS
Posted: Fri Jul 22, 2016 8:47 am
by HousePet
Yep, that is wrong.
Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS
Posted: Fri Jul 22, 2016 8:58 am
by Stuntofthelitter
Yup, that's it. I fixed it a week or so ago when the revelation came up.
Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS
Posted: Fri Jul 22, 2016 11:00 pm
by Zeyphor
Stuntofthelitter wrote:Yup, that's it. I fixed it a week or so ago when the revelation came up.
was the comparable bug with fungal growth fixed too?
Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS
Posted: Sat Jul 23, 2016 1:15 am
by Stuntofthelitter
Not a problem with either fungal growth or arcane shield, but an issue in what the salve was doing. So yes, it will correct the issue in both cases.