Mind Damage and hardcoded damage conversions
Posted: Wed Oct 21, 2015 1:44 am
Turns out that the order of operations of having damage converted via elemental_mastery (Elemental Fury) or twilight_mastery (Pendant of the Sun and Moons) in damage_types.lua has a major important difference from normal damage conversion. Mind damage converted this way still has the resist check for half damage, despite no mind damage ever being inflicted. Weapon damage converted via convert_damage in combat.lua doesn't have this problem, so weird inconsistency is with how those two items work.
Ideally the effect of those two items wouldn't be hardcoded at all so that other things desiring a similar effect wouldn't need to put their own unique entry in setDefaultProjector. Really though it's kind of an unfortunate consequence of how it's currently handled that mind damage is penalized even when it's not even mind damage (or getting the benefit from anything of BEING mind damage).
EDIT: I assume the same thing would happen if using all_damage_convert, but I don't think there's currently a situation that this could come up for with it.
Ideally the effect of those two items wouldn't be hardcoded at all so that other things desiring a similar effect wouldn't need to put their own unique entry in setDefaultProjector. Really though it's kind of an unfortunate consequence of how it's currently handled that mind damage is penalized even when it's not even mind damage (or getting the benefit from anything of BEING mind damage).
EDIT: I assume the same thing would happen if using all_damage_convert, but I don't think there's currently a situation that this could come up for with it.