ToME: the Tales of Maj'Eyal

• In several places it checks for completion of the "ambush-finished" sub-objective, which is a misspelling of "ambush-finish".
• In one branch, it checks for completion of both the "ambush-finished" and "survived-ukruk" sub-objectives; even setting aside the misspelling, "ambush-finish" is completed by dying while Ukruk is still alive and "survived-ukruk" is completed by killing Ukruk, so they can't both be completed.

local desc = {}
desc[#desc+1] = "Deep in the Dreadfell you fought and destroyed the Master, a powerful vampire."
desc[#desc+1] = "In its remains, you found a strange staff. It radiates power and danger and you dare not use it yourself."
if self:isCompleted("survived-ukruk") then
  desc[#desc+1] = "On your way out of the Dreadfell you were ambushed by a band of orcs."
  desc[#desc+1] = "They asked about the staff and tried to steal it from you."
  desc[#desc+1] = "You told them nothing and vanquished them."
  desc[#desc+1] = "#LIGHT_GREEN#Go at once to Last Hope to report those events!"
elseif self:isCompleted("ambush-finish") then
  desc[#desc+1] = "On your way out of the Dreadfell you were ambushed by a band of orcs and left for dead."
  desc[#desc+1] = "They asked about the staff and stole it from you."
  desc[#desc+1] = "#LIGHT_GREEN#Go at once to Last Hope to report those events!"
elseif self:isCompleted("ambush") then
  desc[#desc+1] = "On your way out of the Dreadfell you were ambushed by a band of orcs."
  desc[#desc+1] = "They asked about the staff."
else
  desc[#desc+1] = "You should bring it to the elders of Last Hope in the southeast."
end
return table.concat(desc, "\n")

Zizzo wrote:Ha! That's why I could never figure out what to do after the orc ambush --- the quest description is buggy:

• In several places it checks for completion of the "ambush-finished" sub-objective, which is a misspelling of "ambush-finish".
• In one branch, it checks for completion of both the "ambush-finished" and "survived-ukruk" sub-objectives; even setting aside the misspelling, "ambush-finish" is completed by dying while Ukruk is still alive and "survived-ukruk" is completed by killing Ukruk, so they can't both be completed.

All of which has the effect of truncating most of the quest's description in the quest log, notably including the bit at the end telling you what to do next.

As I follow the logic, I think what we want here is something like this:

Code: Select all

local desc = {}
desc[#desc+1] = "Deep in the Dreadfell you fought and destroyed the Master, a powerful vampire."
desc[#desc+1] = "In its remains, you found a strange staff. It radiates power and danger and you dare not use it yourself."
if self:isCompleted("survived-ukruk") then
  desc[#desc+1] = "On your way out of the Dreadfell you were ambushed by a band of orcs."
  desc[#desc+1] = "They asked about the staff and tried to steal it from you."
  desc[#desc+1] = "You told them nothing and vanquished them."
  desc[#desc+1] = "#LIGHT_GREEN#Go at once to Last Hope to report those events!"
elseif self:isCompleted("ambush-finish") then
  desc[#desc+1] = "On your way out of the Dreadfell you were ambushed by a band of orcs and left for dead."
  desc[#desc+1] = "They asked about the staff and stole it from you."
  desc[#desc+1] = "#LIGHT_GREEN#Go at once to Last Hope to report those events!"
elseif self:isCompleted("ambush") then
  desc[#desc+1] = "On your way out of the Dreadfell you were ambushed by a band of orcs."
  desc[#desc+1] = "They asked about the staff."
else
  desc[#desc+1] = "You should bring it to the elders of Last Hope in the southeast."
end
return table.concat(desc, "\n")

darkgod wrote:fixed