[svn] Bloodrage talent tooltip

[aardvark]

The Bloodrage effect's tooltip shows the last strength bonus given (i.e., always 2) rather than the cumulative bonus. The effect is applied correctly but the tooltip is misleading.

Code: Select all

--- tome/data/timed_effects/mental.lua.old	2012-09-13 17:38:43.000000000 -0700
+++ tome/data/timed_effects/mental.lua	2012-09-14 16:50:29.281250000 -0700
@@ -1783,7 +1783,7 @@
 newEffect{
 	name = "BLOODRAGE", image = "talents/bloodrage.png",
 	desc = "Bloodrage",
-	long_desc = function(self, eff) return ("The target's strength is increased by %d by the thrill of combat."):format(eff.inc) end,
+	long_desc = function(self, eff) return ("The target's strength is increased by %d by the thrill of combat."):format(eff.cur_inc) end,
 	type = "mental",
 	subtype = { frenzy=true },
 	status = "beneficial",

On another note, the effect is always applied for 5 turns. This is contrary to the other talents in the Bloodthirst tree, all of which scale with points invested. The following patch changes it to match the other skills.

Code: Select all

--- tome/data/talents/techniques/bloodthirst.lua.old	2012-09-13 17:38:43.000000000 -0700
+++ tome/data/talents/techniques/bloodthirst.lua	2012-09-14 16:54:26.843750000 -0700
@@ -80,7 +80,7 @@
 	points = 5,
 	mode = "passive",
 	on_kill = function(self, t)
-		self:setEffect(self.EFF_BLOODRAGE, 5, {max=math.floor(self:getTalentLevel(t) * 6), inc=2})
+		self:setEffect(self.EFF_BLOODRAGE, 5 + self:getTalentLevelRaw(t), {max=math.floor(self:getTalentLevel(t) * 6), inc=2})
 	end,
 	info = function(self, t)
 		return ([[Each time one of your foes bites the dust you feel a surge of power, increasing your strength by 2 up to a maximum of %d.]]):

Maybe the shorter duration is by design, but 5 turns is often too short a time to continue a killing spree. Making the duration longer provides incentive to put points into the skill. If you can't keep the effect long enough to keep the bonus climbing, you'll never hit the higher maximum that comes with more talent points...