Page 1 of 1

setEffect round up duration, while %d in desc round down

Posted: Sun Mar 06, 2011 7:22 am
by hops
For example, perfect strike at tlvl 1.1, the description says duration=2, while setEffect make it 3.

Re: setEffect round up duration, while %d in desc round down

Posted: Sun Mar 06, 2011 9:55 am
by Grey
Hmm, I believe this is also the case with shield runes, as they always seem to give 1 more turn than advertised.

Re: setEffect round up duration, while %d in desc round down

Posted: Sun Mar 06, 2011 4:44 pm
by edge2054
I think this actually has to do with the way Zero Usage Speed abilities work. (Both Shield Runes and Perfect Strike are instant use).

The description will say two turns but those two turns don't actually start counting until your next action so generally a timed effect will get set to duration + 1. When you go you see that the duration is what you'd expect but if you're using an instant ability you basically interrupt that first tic.

I encountered something similar with Borrowed Time and it always rounds before it gets passed so I don't think this is a rounding issue. The fix I used for it was to lower the duration by 1 and add a +1 to the duration in the description. I'm sure other instant use chronomancy effects are having a similar issue but Borrowed Time's duration is very short and 1 extra tic was a lot in this instance so I felt it needed to be fixed.