Page 1 of 2
Problems with a large inventory
Posted: Tue Oct 12, 2010 10:28 am
by ghostbuster
With a LARGE number of items, there is a no way to do any inventory operation. Either 'i', 'd' or 'w', just return without displaying anything.
I check in the savefiles, and it seems to happen if the player has more than 160 items. By destroying the items above 160 (with a text editor!), the inventory commands are back again and work properly.
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 10:44 am
by Fela
Troubleshooting or did you actually carry that much stuff with you?
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 10:58 am
by darkgod
Yup, fixed already
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 11:05 am
by ghostbuster
Fela wrote:Troubleshooting or did you actually carry that much stuff with you?
I did carry that much stuff with me. I was an archmage with feather wind, and I mostly had light items (like rings, ...)
The problem is that, with the present UI, dropping many items is more annoying than dealing with a large inventory :d
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 11:42 am
by PowerWyrm
The problem is simply that the new UI is slow as hell. If you carry 10-15 items, the inventory window will open in 2-5 seconds. If you carry 40-50 items, it will take way over a minute. With 160 items, it would probably require a whole day...
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 11:59 am
by darkgod
Spend the last 2 days optimizing it, I think it's better now we'll see
I'll send you a new test archive soon powerwyrm
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 12:11 pm
by darkgod
Can you try using that please: see if it is faster?
http://te4.org/dl/t-engine/t-engine4-wi ... omusic.zip
PS: no not really beta13, do not use for real characters
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 1:24 pm
by Massimiliano Marangio
I have the same problem. After clearing a Crypt in Tol Falas, I carried the loot in one place, took all items and identified the whole lot.
"wield" and "take off" do work, but neither "inventory" nor "drop". The log shows these error messages:
Code: Select all
Lua Error: /engine/dialogs/ShowEquipInven.lua:183: bad argument #1 to 'char' (invalid value)
At [C]:-1
At [C]:-1 char
At /engine/dialogs/ShowEquipInven.lua:183 generateList
At /engine/dialogs/ShowEquipInven.lua:35 init
At /engine/class.lua:64 new
At /engine/interface/ActorInventory.lua:220 showEquipInven
At /mod/class/Game.lua:725 ?
At /engine/KeyBind.lua:202
Code: Select all
Lua Error: /engine/dialogs/ShowInventory.lua:85: bad argument #1 to 'char' (invalid value)
At [C]:-1
At [C]:-1 char
At /engine/dialogs/ShowInventory.lua:85 generateList
At /engine/dialogs/ShowInventory.lua:37 init
At /engine/class.lua:64 new
At /engine/interface/ActorInventory.lua:230 showInventory
At /mod/class/Player.lua:584 playerDrop
At /mod/class/Game.lua:720 ?
At /engine/KeyBind.lua:202
168 object with 542 encumbrance, by the way.
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 1:28 pm
by darkgod
Yes it will not work with more than 160 in beta12, in beta13 you will be however be able to carry thousands of items!
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 1:30 pm
by PowerWyrm
I'll check that tonight...
The problem is to build a character quickly to be able to carry a truckload of items, and I suppose that build is not compatible with b12...
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 1:31 pm
by darkgod
Probably not but if it lags so heavily you should notice it even with a low number of items no ?
Also this should make the leveltup talents screen better too
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 7:57 pm
by PowerWyrm
Ok here we go...
Started a char in both beta12 and pseudo beta 13, collected 50 items and noted down the time needed to display the inventory windows with some commands.
Beta 12: 4 seconds (roughly)
Pseudo beta 13: (a little less than) 3 seconds
I'd say it's 30% faster. There's some improvement, but it's still very laggy
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 8:18 pm
by darkgod
Good news I found a new bottleneck after sending it so it should be even faster now
Re: Problems with a large inventory
Posted: Tue Oct 12, 2010 8:18 pm
by darkgod
About two thousands objects can now make my computer lag now (it did before obviously)
Re: Problems with a large inventory
Posted: Thu Oct 14, 2010 8:40 pm
by PowerWyrm
I know the pseudo-beta13 file is an intermediate build, but are Fire spells supposed not to work anymore? A little check now Is probably better than a bug report later
