[svn 2880] npc's hit in melee from range 2

Message

Freddybear · #1 Post by **Freddybear** » Mon Feb 28, 2011 11:53 pm

Playing on svn 2880, my character is being hit by melee attacks from npc's which are two squares away.
Here is an example screenshot:

I have attached a partial stdout.txt from a wolf ambush which also has the same problem. I didn't get a screenshot from the wolf ambush.

#2 Post by **yufra** » Tue Mar 01, 2011 12:46 am

Many thanks to Freddybear and edge2054 for helping me debug this on IRC. I have attached a patch.

EDIT: Removed this patch, added one further along in the thread.

edge2054 · #3 Post by **edge2054** » Tue Mar 01, 2011 1:17 am

Not sure if it's this fix or a separate issue but Ice Claw, Swallow, and Nature's Touch all act like they can target beyond melee range when right clicking (though none go off.)

Attack does not act this way and only shows up if I right click on adjacent tiles.

Freddybear · #4 Post by **Freddybear** » Tue Mar 01, 2011 2:32 am

The right-click menu seems to be sensitive to certain types of ranged "attacks" but not others.
For my wyrmic character, the targeting for Ice Breath is apparantly one square in range, but the cone extends far beyond that.
For example:

The right-click menu for a one-square range "attack" is:

Even though the cone of Ice Breath extends far enough, the right-click menu for a range greater than one is:

Freddybear · #5 Post by **Freddybear** » Tue Mar 01, 2011 3:03 am

On the other hand, the right-click menu for an Archmage, who does not have any melee or range-1 "cone" attacks, seems to be correct, although it excludes talents which cannot "directly" target the square on which the cursor was placed, which precludes using the right-click menu for "indirect" targeting of beams or bolts around corners or obstacles.

#6 Post by **yufra** » Tue Mar 01, 2011 5:56 am

Thanks again guys, here is a new patch against SVN2880 (ignore the first patch) that I think is fixed.

EDIT: Not fixed... working on it.

#7 Post by **yufra** » Tue Mar 01, 2011 5:31 pm

Alright, it required a bit of refactoring but I think this is a much more robust method. This new patch is against SVN 2885 to take advantage of tiger_eye's asymmetry fix. Please let me know if you notice anything odd with the MapMenu, projections and projectiles. Cheers.

EDIT: Updated the patch to fix a minor bug with MapMenu.

ToME: the Tales of Maj'Eyal

[svn 2880] npc's hit in melee from range 2

[svn 2880] npc's hit in melee from range 2

Re: [svn 2880] npc's hit in melee from range 2

Re: [svn 2880] npc's hit in melee from range 2

Re: [svn 2880] npc's hit in melee from range 2

Re: [svn 2880] npc's hit in melee from range 2

Re: [svn 2880] npc's hit in melee from range 2

Re: [svn 2880] npc's hit in melee from range 2