[v.1.3.0+] Nur Kit

[Zizzo]

Ashes doesn't add a water level, unless I'm grossly misremembering.

Good to hear; in that case, I can go ahead and release v3 with the Embers support. This release puts a rough leather belt of unlife and rough leather armor of the deep in Kruk Pride's Tanner store, and that special artifact tinker in the Tinker Store.

[Zizzo]

Just discovered Einzbern's Tinker Stores in Last Hope addon, and using it with my Maj'Eyal-side tinker characters. It occurred to me that that artifact tinker we added in v3 above should really be available in these new steamtech stores too; v3a, just released, puts it in the new Last Hope Implant Store.

[astralInferno]

Just made my first charrie in a while to try out the Harbinger mod. Nur Kit didnt seem to work, but it's showing as active. Probably an incompatibility in one of my 60-odd mods?

https://gyazo.com/f5a73625a1b291e2b927de53e153d52d is a screenshot of the mod list.

[HunterZ]

Just made my first charrie in a while to try out the Harbinger mod. Nur Kit didnt seem to work, but it's showing as active. Probably an incompatibility in one of my 60-odd mods?

https://gyazo.com/f5a73625a1b291e2b927de53e153d52d is a screenshot of the mod list.

How did you test it? Did you visit the correct shop? Do you have any other mods that affect merchants?

[astralInferno]

I was definitely in the right shop, unless something changed while I wasn't looking. I don't think I've picked up any NEW mods that affect merchants; I normally get content mods, not utility mods.

Lessee.

[stolen sfx: source diving]okay so most of this is done in hooks, so it shouldn't be overwritten there. The hooks are all procced by a superloaded finishEntity in Zone.lua. Searching my mod folder for finishEntity doesn't bring up anything messing with it... lets try zone.lua.

...ah, hello, odyssey of the summoner. You touch everything. I bet it's you.
...but I have you turned off, like a sensible person. O_o

Well, let's see if it happens a second time.
...it didn't.

...good job, guys, we can pack up? O_o
I load my old character and go check. Still no amulet of the fish, so whatever's going on SOMETHING is wrong SOMETIMES.
...there is, however, a belt of unlife and armor of the deeps that I SWEAR weren't here last time. Whatever. I give up. Problem solved I guess. Coding is black magic.

[Zizzo]

Whatever. I give up. Problem solved I guess. Coding is black magic.

Gyeep! Okay, off the top of my head:

• The water-breathing gear is placed in the Lost Merchant shop by way of modifying the store.fixed{} subtable of the store entity; anything that touched that could have clobbered stuff.
• The Zone:finishEntity() superload is a Spectacularly Evil Hack™ to get the force_ego field to work so that we can place specific ego items in the store; if that was breaking, I'd think it would have blocked all four gear pieces.
• If all three of the other gear pieces are present (there should be armor of the deep, a cap of the depths and a belt of unlife), it's possible that our amulet of the fish ego definition is not getting loaded or is breaking somehow.
• I doubt saving and reloading would have changed anything, as the store's contents should have been persisted across that.

[Zizzo]

So you remember above when I added our artifact water-breathing tinker to the tinker store from the Tinker Stores in Last Hope addon? Well, that addon has apparently been taken over by Dienes in the form of the new Tinker Stores in Last Hope - Tinker addon — with a different internal short_name, which means my changes from before weren't detecting it. That's fixed in v3a.1, just pushed out, so our tinker should now appear in the stores from both addons. We Apologize for the Inconvenience.™

[Zizzo]

So, early access to stores is back, but since the player now starts with no gold, Yeek characters still wouldn't be able to buy the Heart of Rel from the gem store dude. Fortunately, the workaround I came up with back when stores were locked before level 10 is probably better than buying something anyway. Specifically, v3b adds an NPC to give you the Heart (and for you to return it to, which seems thematically more fitting than just having it taken from you as you leave the island).

Also, similar to the problems we had with 1.4.0's store changes, the newly nerfed stores in 1.6.0 apparently won't stock tier-3 gear when you first get to them, which screws up the installation of T3 water-breathing sources. What I'm trying this time out is to widen our parameters slightly: instead of specifically telling the store to stock "hardened leather armor", we tell it to stock something of type armor/light (i.e. leather armor), so the store stocking code should automatically pick the right material level for whatever the store thinks it's allowed to stock. Tests so far aren't perfect (getting duplicates, but so far getting everything), but it should be good enough for now, and ideally will be future-proofed against future store shenanigans.

[Zizzo]

v3b.1 is sort of a bugfix release, with small tweaks to how we modify store stocks — in particular, we refrain from assuming that the store doesn't already have a fixed{} table, in case some other addon has added one before us (*ahem…*) Should be no change in functionality.

[Zizzo]

With the changes in 1.6, we can no longer count on being able to kill the Assassin Lord early enough to get the water breathing gear we need for Lake Nur. Loosely inspired by the yeek-elder strategy we adopted for v3, then, we bite the proverbial bullet for v4 and just add a new store to Last Hope that sells water breathing gear — basically the same stuff we add to the lost merchant store.

(If you've already been to Last Hope with a character before updating to this release, the store won't appear; We Apologize for the Inconvenience.™ The Lost Merchant store will still carry water breathing gear either way, so you'll still be covered.)

We also tweak the store filters slightly, in both stores. Turns out "non-metal headwear" isn't good enough to specify leather caps of the depths, since that also lets through wizard hats, which apparently can't get the "of the depths" ego.

[astralInferno]

hey, just to be sure, is this Meant to be adding /two/ of every item to the merchant's store? There were two of each in the other shop too (which I forgot existed to start with)

Screenshot

I figure it probably is, but better safe than sorry?

[Zizzo]

hey, just to be sure, is this Meant to be adding /two/ of every item to the merchant's store? There were two of each in the other shop too (which I forgot existed to start with)

Screenshot

I figure it probably is, but better safe than sorry?

(shrug) It's a side effect of 1.6's new store stocking schedule. Every time a store is restocked (which by the time you first get to Last Hope is likely twice, at levels 1 and 10), everything in the store definition's fixed{} subtable is added to the store's stock. Sometimes with later restocks you'll get higher-tier versions, like the copper and steel amulets of the fish in your screenshot. It's aesthetically unsatisfying, I agree, but I don't know how to change that behavior, and I'm not sure how much effort it's worth to try to figure out a way to work around it.

[astralInferno]

that makes perfect sense, no worries! Just wanted to check you knew.

[Zizzo]

So when one of my recent characters visited our water-breathing store in Last Hope, it turned out that the store stocking algorithm had "upgraded" one of the amulets of the fish into the Black Core. Which… is nice? I guess? but since said artifact does not in fact confer water breathing, it kind of defeats the point. I've taken a stab at preventing that from happening in v4a.1; at the very least, it hasn't broken anything in tests so far.

[64legos]

Got a Lua error that specified this addon when I tried to leave the level-up screen after learning the Secret of Telos prodigy.