Page 1 of 1

Particle crashes

Posted: Fri Sep 07, 2012 1:22 am
by aardvark
I note that the recent r5662 update hopefully fixes the particle related crashes by introducing extra checks before the lua_pcalls in the particles.c file. I don't think that's going to fix them, though, since those were already protected calls. My (relatively unfamiliar) reading of the code says that after those errors are logged a default particle cloud(?) is generated. I think the problem is on line 285 of particles-gas.c, which goes (lines 284-286 of b42):

Code: Select all

	lua_rawgeti(L, LUA_REGISTRYINDEX, gz->generator_ref);
	lua_call(L, 0, 1);
	if (!lua_isnil(L, -1))
It's that unprotected lua_call that I think is biting players. Maybe?

Re: Particle crashes

Posted: Fri Sep 07, 2012 7:04 pm
by darkgod
particle_gas is never used :)

And yes my fix seem to actually work, game ran for many hours under very high particle load (never ending urkis fight with auto turn passing).