ToME: the Tales of Maj'Eyal

Effigy wrote:It's not a bad idea for an addon, but personally I like to save my gems until I unlock the fortress for a quick energy boost. Unless I'm desperate for money earlier, that is.

Would it be possible to add a setting for exactly this? So it checks whether you already linked the chest with the fortress before putting the gems in?
This addon is really convenient, but I always disable it at the start for the quick energy boost.
And with how often I start over...

Feuerhai wrote:

Effigy wrote:It's not a bad idea for an addon, but personally I like to save my gems until I unlock the fortress for a quick energy boost. Unless I'm desperate for money earlier, that is.

Would it be possible to add a setting for exactly this? So it checks whether you already linked the chest with the fortress before putting the gems in?
This addon is really convenient, but I always disable it at the start for the quick energy boost.
And with how often I start over...

Huh. I always figured the money was more useful early on. (Of course, since I don't use the farportal, I don't have much call for fortress energy anyway…)

But, fair enough. What degree of control would you want over this? I'm already working on another requested option to control when gems go in the transmo chest; I can probably merge this in with that.

actually i nearly always play an alchemist or some class that i add stone alchemy to. what would be useful for such play style is a thing that automatically extracts gems and moves them to normal inventory. if the player wants to keep an item he or she can first move the item to normal inventory like you would for arts you want to keep any way.

you could consider this the alchemists version. actually this might make a good talent for new alchemist trees or a generic so other classes could use it. or it could just be a check the chest does.

Every time i see something like this it is always about automatically transmorgrifying gems; never the other way around and i have seen what seems to be countless add ons or discussions of add ons to do this. (well ok at least 4 or so.) Alchemists get no love.

stormbringer wrote:actually i nearly always play an alchemist or some class that i add stone alchemy to. what would be useful for such play style is a thing that automatically extracts gems and moves them to normal inventory. if the player wants to keep an item he or she can first move the item to normal inventory like you would for arts you want to keep any way.

We're already adding an "Extract gems" item command to the transmo chest; do you mean something different?

Zizzo wrote:

stormbringer wrote:actually i nearly always play an alchemist or some class that i add stone alchemy to. what would be useful for such play style is a thing that automatically extracts gems and moves them to normal inventory. if the player wants to keep an item he or she can first move the item to normal inventory like you would for arts you want to keep any way.

We're already adding an "Extract gems" item command to the transmo chest; do you mean something different?

the Fortress butler thing changes the chest to extract gems only if it makes more economic sense to do so. If you mean you are making an add on to preferentially extract gems regardless of economics then i haven't seen it or i have greatly misunderstood the purpose of your mod. Thats certainly possible.

Transmogrifiy means "to transform" not "to extract" so when i see an addon with transmogrify or variants of that i think they mean turn into gold and energy not pry out gems.

stormbringer wrote:the Fortress butler thing changes the chest to extract gems only if it makes more economic sense to do so. If you mean you are making an add on to preferentially extract gems regardless of economics then i haven't seen it or i have greatly misunderstood the purpose of your mod. Thats certainly possible.

It may be a mutual misunderstanding. What I took you to be suggesting was an option to have the transmo chest extract gems out of metal objects and leave them in player inventory as part of the transmogrification process. That's been suggested before, but as I said at the time, I'm no longer particularly confident in my ability to successfully modify the actual operation of the transmo chest at that level (the last time I tried, it ended badly…). The current implementation is something of a compromise; the "Extract gems" command on the transmo chest's use-item dialog at least avoids having to walk through the chest contents and manually extract gems from stuff.

Release v3b combines the feature requested by Effigy and Feuerhai above with a feature requested from Steam, in the form of a new game option "When to auto-transmo gems". This can be set to 'Standard' for the current behavior, 'Always' to put gems in the chest even if you know gem-using talents, or 'After linking transmo chest', which should be self-explanatory.

Thanks for this (and all your other) addons! As an alchemist, I'd like an option to auto-extract gems from items if they're worth more (as it currently behaves), but not to automatically transmogrify them afterwards.

Sinister Stairs wrote:Thanks for this (and all your other) addons! As an alchemist, I'd like an option to auto-extract gems from items if they're worth more (as it currently behaves), but not to automatically transmogrify them afterwards.

That's been suggested before; that particular handling is done deep in the transmo chest's object definition, and I've screwed up badly before when trying to modify it. [sound F/X: source diving] …hmm, actually, I might be able to get away with superloading Actor:transmoInven(), which would be safer. Let me investigate. In the meantime, what sort of interface would you want for this? I'm assuming that whether you want to auto-extract and keep a gem from an object isn't actually dependent on whether the gem is worth more than the object; would it depend on the object's tier?

Zizzo wrote:what sort of interface would you want for this? I'm assuming that whether you want to auto-extract and keep a gem from an object isn't actually dependent on whether the gem is worth more than the object; would it depend on the object's tier?

My thought process (with no regard to add-on logic) is: I want to have a stash of x gems per type per tier. I tend to use lower tier gems for alchemist gems, and save higher tiers for the golem/imbuing. (Where lower/higher tier is relative to whatever tier items are commonly dropping at my current level.)

If I have enough gems of a particular type/tier, I always want to transmo excess gems for maximum gold/fortress energy (whether it's the extracted gem or item). If I'm still "collecting" a particular gem type/tier, I want to always keep extracted gems from "trash" items (i.e. items that are worth less than the extracted gem); and always transmo items for fortress energy when they're worth than if their gem were extracted.

Clearly this is a very specific use case to how I balance gems and amassing fortress energy, so I'm pleasantly surprised you're even inquiring.

In terms of an add-on, that's way too complex. I'd simplify it by having a gameplay option of simply "Auto-transmo extracted gems?" and make it true/false. The add-on would use the existing "extract gems if worth more than the item" and follow the current tier setting, but always/never auto-transmo any extracted gems.

What I most use the add-on for is just determining whether an extracted gem is worth more than the item; I would be perfectly fine with never auto-transmo'ing extracted gems, and manually transmo'ing all gems myself.

Sinister Stairs wrote:In terms of an add-on, that's way too complex. I'd simplify it by having a gameplay option of simply "Auto-transmo extracted gems?" and make it true/false. The add-on would use the existing "extract gems if worth more than the item" and follow the current tier setting, but always/never auto-transmo any extracted gems.

What I most use the add-on for is just determining whether an extracted gem is worth more than the item; I would be perfectly fine with never auto-transmo'ing extracted gems, and manually transmo'ing all gems myself.

Hmm, not sure how close I am to what you wanted, then. What I've got so far will extract and not transmo a gem from an object if it's at or above a certain tier (speciried by a game option), whether or not the gem would be worth more then the object. (You could get "always" or "never" by setting "tier 1 or higher" or "tier 6 or higher", respectively.)

This has turned out to be trickier than I expected, though; putting a gem back into inventory while the transmo chest is walking the inventory looking for stuff to transmo could break things badly. I'm experimenting with some dirty hackery using game:onTickEnd() to put all the gems into inventory after everything has been transmo'd, but I'll need to do more testing before I'm confident enough to release it.

Zizzo wrote:[...] but I'll need to do more testing before I'm confident enough to release it.

We Apologize for the Delay™; after further testing, I'm reasonly confident that our new "Gameplay | Keep auto-extracted gems" option is working the way I want it to work. That's going at as v3c. This release also includes a small bugfix: I can only assume that no one else was using the "Extract gems" action that this addon adds to the transmo chest, because I recently discovered that said action wasn't actually restricting itself to stuff in the transmo chest… It also wasn't checking for quest items or plot items or things specifically "no-transmo". I hope that didn't bite anyone in the proverbial at any point…

Thanks so much! Your addons, and your support for them, are the best!

So, the fix for that recent bug in Inventory Sort Order involves reaching into the ActorInventory:pickupFloor() method. This addon touches that method too, and since both are in ZOmnibus, we have to arrange for them to coordinate. In the process, I noticed that this addon is actually not passing through all the return values returned by the parent method — which is the sort of mistake that has caused all sorts of problems in some of my other addons. I don't know whether the game code changed between then and now or whether I was just that bad at writing code 11 years ago, and I don't know if it actually was causing any problems, but just to be safe, v3d.1 fixes the bug. Should be no change in functionality (I hope…); We Apologize for the Interruption.™