ToME: the Tales of Maj'Eyal

Everything about ToME
It is currently Wed Apr 01, 2020 2:29 pm

All times are UTC




Post new topic Reply to topic  [ 519 posts ]  Go to page Previous  1 ... 31, 32, 33, 34, 35

What do you want to see in the next release?
Hey, why haven't you implemented my favorite race/subrace/class yet? (specify below) 0%  0%  [ 0 ]
Hey, why haven't you implemented my favorite skill/talent/spell/ability yet? (specify below) 67%  67%  [ 2 ]
Hey, why haven't you implemented my favorite scroll/potion/wand/staff/rod/other object yet? (specify below) 0%  0%  [ 0 ]
Hey, why haven't you implemented my favorite store/quest/event yet? (specify below) 0%  0%  [ 0 ]
Hey, that's not what that dungeon's supposed to look like! (specify below) 0%  0%  [ 0 ]
Hey, why haven't you implemented my favorite game mechanic/UI feature yet? (specify below) 0%  0%  [ 0 ]
Hey, that's a bug! Go fix that bug! (specify below) 33%  33%  [ 1 ]
Hey, you didn't list what I want to see! (specify below) 0%  0%  [ 0 ]
Total votes : 3
Author Message
PostPosted: Fri Jan 17, 2020 1:29 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1789
Location: A shallow water area south of Bree
Sissa Dreki wrote:
When attempting to use Copy Spell, I ran into a lua error.

[sound F/X: source diving] *blink…* [sound F/X: forehead repeatedly striking desk] And that's probably going to come up enough to warrant an emergency bugfix release:

Release 0.4.1 "Message Repeats"

Handful of bugfixes this time out:
  • Small bug in tunneling that I think would only have cropped up in hex mode (which we don't support, but principle of the matter…).
  • So, y'know that fix for repeated log messages that I was so proud of in the last release? Yeahp, I botched it. :oops: Should be fixed now (famous last words…).
  • Waaay back in a pre-0.1.0 version, I papered over a small bug in the engine's inventory/equipment dialog that would crop up if inventory and equipment were both empty. I only just noticed that I didn't do the same for my variant of the dialog that includes items on the floor.
  • And bump us up to the latest engine version, as long as we're in the neighborhood.

And this doesn't bode well for the likelihood of more bugs cropping up in the near future… :oops: As always, here is a good place to report them.

And as always, the .team file for the release is available from my site, along with the Subversion repo and SVN::Web front-end thereto. And for those of you following along on SVN, the 0.4.1 release branch will get bug fixes for all the aforementioned inevitable bugs.

And since having them scattered throughout the thread is sort of useless, here's a reference list of all the T2 addons I've released:
  • Alchemic Arcanorum (current release 1.0.0): Starts Alchemist characters with an Alchemic Arcanorum object from my old ToME:Arcanorum T2 module, which can be used to store and extract essences.
  • Gender Parity (current release 1.0.1): Modifies assorted NPCs that don't particularly have to be male or female so that they can be either randomly.
  • Go to Landmark (current release 1.0.1): A quickie port of my T4 addon of the same name; allows you to auto-travel to various landmarks like stores or up/down stairs via the "Show known landmarks" action on the <Esc> menu.
  • Neutral Townsfolk (current release 1.0.0): As requested by Thorondor above. :wink: Modifies a few of the more harmless town denizens into the "Neutral" faction so they don't pester you.
  • ZAngband Monsters (current release 1.0.1): Adds ZAngband monsters (hence the name). Untested.
  • Gondolin Book Store (current release 1.0.0): Also as requested by Thorondor. :wink: Adds a book store to Gondolin (hence the name…).

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Mon Mar 23, 2020 5:24 pm 
Offline
Cornac

Joined: Wed Apr 15, 2015 11:59 am
Posts: 44
Cheers Zizzo
Well done on implementing item destruction. :D
Bravo sir!

A couple of bugs are below; and also the bug-report seems to now record all activities recently undertaken rather than just the error (127k file error reports which actually seem to be a diary of the character's activity.

I tried to explore the automatizer: - trying to exit the automatizer menu it got into a loop from which it couldn't escape - not sure I've captured the correct bit of the error log,

fail energy
[DEBUG] notice 238^3 = 13481272 vs. noise 67108864
[USE ITEM] name='Test automatizer rule' action=automat-test talent=nil
true


ERROR:
Game version: tome2-0.4.1
Addons: town_neutral-0.3.0, landmark-0.2.0

Lua Error: /mod/dialogs/UseItemDialog.lua:196: attempt to index local 'item' (a nil value)
At [C]:-1 __index
At /mod/dialogs/UseItemDialog.lua:196 fct
At /mod/ui-util.lua:63
At /engine/KeyBind.lua:265 triggerVirtual
At /engine/ui/Dialog.lua:506 fct
At /engine/Mouse.lua:71


Error 2: tried to drop a stack of something:

ERROR:
Game version: tome2-0.4.1
Addons: town_neutral-0.3.0, landmark-0.2.0

Lua Error: /mod/class/Player.lua:1453: attempt to index field 'object' (a nil value)
At [C]:-1 __index
At /mod/class/Player.lua:1453 action
At /engine/dialogs/ShowEquipInven.lua:127 use
At /engine/dialogs/ShowEquipInven.lua:78 on_input
At /engine/KeyCommand.lua:72 receiveKey
At /engine/ui/Dialog.lua:802 keyEvent
At /engine/ui/Dialog.lua:510


Top
 Profile  
 
PostPosted: Mon Mar 23, 2020 5:26 pm 
Offline
Cornac

Joined: Wed Apr 15, 2015 11:59 am
Posts: 44
Just seen the Star of Elendil on sale in the black market!
Alas only L17 character. Best kill some hydras...


Top
 Profile  
 
PostPosted: Mon Mar 23, 2020 11:31 pm 
Offline
Cornac

Joined: Wed Apr 15, 2015 11:59 am
Posts: 44
tried to destroy an average item

ERROR:
Game version: tome2-0.4.1
Addons: town_neutral-0.3.0, landmark-0.2.0

Lua Error: /mod/dialogs/UseItemDialog.lua:196: attempt to index local 'item' (a nil value)
At [C]:-1 __index
At /mod/dialogs/UseItemDialog.lua:196 fct
At /mod/ui-util.lua:63
At /engine/KeyBind.lua:231 receiveKey
At /engine/ui/Dialog.lua:802 keyEvent
At /engine/ui/Dialog.lua:510


Have noticed that currently trying to drop a stack of items doesn't work if your initial command is drop, but if you go to inventory first, select an item and then drop it's more tolerant :)


Top
 Profile  
 
PostPosted: Wed Mar 25, 2020 1:36 pm 
Offline
Cornac

Joined: Wed Apr 15, 2015 11:59 am
Posts: 44
Bullywags generated on grass so can't move.
Is slowing of movement de to carrying too much loot meant to occur at 100% of capacity, or >100%? - it currently kicks in at 100%
Selling item stacks (e.g. arrows) doesn't multiply the number of items by the cost. e.g. arrow of venom - 237gp / item, try to sell a stack: 240 for entire stack.
Would you mind checking the bookstore in Gondolin is active?
Cheers :)


Top
 Profile  
 
PostPosted: Thu Mar 26, 2020 3:30 am 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1789
Location: A shallow water area south of Bree
Thorondor wrote:
Well done on implementing item destruction. :D
Bravo sir!

*blush* (bows)

Thorondor wrote:
A couple of bugs are below; and also the bug-report seems to now record all activities recently undertaken rather than just the error (127k file error reports which actually seem to be a diary of the character's activity.

[sound F/X: source diving] Interesting; it looks like there are two relevant directories now, error-reports/ and error-logs/. The latter appears to get populated with full copies of the game log file up to the point of the error, which would explain the file sizes you're seeing. If error-reports/ is still present and being populated, that'll probably have the shorter stack traces we're used to.

Thorondor wrote:
I tried to explore the automatizer: - trying to exit the automatizer menu it got into a loop from which it couldn't escape - not sure I've captured the correct bit of the error log,

[sound F/X: source diving] Well, the bit you've got here is from trying to exit out of the automatizer rules list from the "Test automatizer rule" action in the use-item dialog. Ah, and I can see how exiting out of that dialog without selecting a rule to test would produce that error. Should be fixed in SVN.

Thorondor wrote:
Error 2: tried to drop a stack of something:

[sound F/X: source diving] …okay, I have no idea what I was thinking there. Fixed in SVN.

Thorondor wrote:
Just seen the Star of Elendil on sale in the black market!

?! I should be filtering artifacts out of store stock candidates. [sound F/X: source diving] Ah, I see where I should have been doing that. Should be fixed in SVN. We Apologize for the Oversight.™

Thorondor wrote:
tried to destroy an average item

…This looks like the wrong stack trace; it's the same as the one from the automatizer error above.

Thorondor wrote:
Have noticed that currently trying to drop a stack of items doesn't work if your initial command is drop, but if you go to inventory first, select an item and then drop it's more tolerant :)

[sound F/X: source diving] Ohhh, that's where I copy/pasted that code from. Unfortunately, I forgot to change some relevant bits after the copy, hence the error above. We Apologize for the Inconvenience.™ :oops:

Thorondor wrote:
Bullywags generated on grass so can't move.

Yeah, bullywugs shouldn't be created on grass in the first place. I'll investigate.

Thorondor wrote:
Is slowing of movement de to carrying too much loot meant to occur at 100% of capacity, or >100%? - it currently kicks in at 100%

[sound F/X: source diving] Should be >100%. What's your STR, and how much weight are you carrying?

Thorondor wrote:
Selling item stacks (e.g. arrows) doesn't multiply the number of items by the cost. e.g. arrow of venom - 237gp / item, try to sell a stack: 240 for entire stack.

Dangit, I know I've fixed that before. I'll investigate.

Thorondor wrote:
Would you mind checking the bookstore in Gondolin is active?

Well, from the error reports you've shown so far, you don't appear to have the Gondolin Book Store addon installed and enabled. :wink:

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Fri Mar 27, 2020 12:57 pm 
Offline
Cornac

Joined: Wed Apr 15, 2015 11:59 am
Posts: 44
Thorondor wrote:
tried to destroy an average item

…This looks like the wrong stack trace; it's the same as the one from the automatizer error above.
Apologies :oops:

Thorondor wrote:
Is slowing of movement de to carrying too much loot meant to occur at 100% of capacity, or >100%? - it currently kicks in at 100%

[sound F/X: source diving] Should be >100%. What's your STR, and how much weight are you carrying?

It looks like it's a crossing threshold issue:
- if you are at 80% capacity and go to 100% it's fine, no penalty.
- if you are at 120% capacity (and therefore have movement penalty), dropping to 100% doesn't remove the movement penalty, but if you go to 99% penalty removed, and then back up to 100% will still be fine.

Thorondor wrote:
Would you mind checking the bookstore in Gondolin is active?

Well, from the error reports you've shown so far, you don't appear to have the Gondolin Book Store addon installed and enabled. :wink:[/quote]

:oops: :lol:
will investigate

Scroll of enchant armour (read from the floor / then subsequently tried from inventory)
error = "Game version: tome2-0.4.1\
Addons: town_neutral-0.3.0, landmark-0.2.0\
\
Lua Error: /mod/spell-util.lua:784: attempt to index global 'self' (a nil value)\
At [C]:-1 __index\
At /mod/spell-util.lua:784 action\
At /mod/dialogs/ShowEquipInvenFloor.lua:73 use\
At /engine/dialogs/ShowEquipInven.lua:57 fct\
At /engine/ui/ListColumns.lua:463 onUse\
At /engine/ui/ListColumns.lua:135 fct\
At /engine/Mouse.lua:71 receiveMouse\
At /engine/Mouse.lua:111 delegate\
At /engine/ui/Dialog.lua:793 mouseEvent\
At /engine/ui/Dialog.lua:508 fct\
At /engine/Mouse.lua:71 "
seen = true
reported = false


Activating the star of elendil:
error = "Game version: tome2-0.4.1\
Addons: town_neutral-0.3.0, landmark-0.2.0\
\
Lua Error: /mod/class/Player.lua:1511: /engine/interface/ActorTalents.lua:1019: attempt to index local 't' (a nil value)\
At [C]:-1 \
At [C]:-1 error\
At /mod/class/Player.lua:1511 playerUseItem\
At /mod/dialogs/UseItemDialog.lua:70 use\
At /mod/dialogs/UseItemDialog.lua:46 fct\
At /engine/ui/List.lua:155 onUse\
At /engine/ui/List.lua:81 fct\
At /engine/Mouse.lua:71 receiveMouse\
At /engine/Mouse.lua:111 delegate\
At /engine/ui/Dialog.lua:793 mouseEvent\
At /engine/ui/Dialog.lua:508 fct\
At /engine/Mouse.lua:71 "
seen = true
reported = false

Have just looked in the library in Gondolin; - it's a nice set of prices for identity staffs :) - all 1gp. :D


Top
 Profile  
 
PostPosted: Sun Mar 29, 2020 7:51 pm 
Offline
Sher'Tul Godslayer

Joined: Thu Jan 23, 2003 8:13 pm
Posts: 1789
Location: A shallow water area south of Bree
Thorondor wrote:
Zizzo wrote:
Thorondor wrote:
tried to destroy an average item

…This looks like the wrong stack trace; it's the same as the one from the automatizer error above.
Apologies :oops:

No worries, found it. :oops: Fixed in SVN.

Thorondor wrote:
It looks like it's a crossing threshold issue:
- if you are at 80% capacity and go to 100% it's fine, no penalty.
- if you are at 120% capacity (and therefore have movement penalty), dropping to 100% doesn't remove the movement penalty, but if you go to 99% penalty removed, and then back up to 100% will still be fine.

Hmm, I wonder if it's a floating-point rounding issue. T2 stores object weights as integer tenths of a pound, but we use floating-point numbers for it, since we can — but that could mean that we're ending up with, say, 90.0001 load out of a 90 capacity. I'll try rewriting that code to clamp it down to integral handling.

Thorondor wrote:
Scroll of enchant armour (read from the floor / then subsequently tried from inventory)

[sound F/X: source diving] Ah, assorted stupid typos in handling item enchantment, some in scroll handling, some in store handling. Fixed in SVN.

Thorondor wrote:
Activating the star of elendil:

[sound F/X: source diving] Mm, sloppy; was re-using the code for ball damage with a talent to handle stuff like this, doing damage in a radius around the player not associated with a talent. That cropped up a lot of places. Lucky you caught it. :oops: :wink: Fixed in SVN.

Thorondor wrote:
Selling item stacks (e.g. arrows) doesn't multiply the number of items by the cost. e.g. arrow of venom - 237gp / item, try to sell a stack: 240 for entire stack.

Do me a favor: the next time you see this, try dropping the arrows a few at a time (whichever way it was that wasn't bugged) to see if they're all Arrows of Venom. I've got a sinking feeling something's going wrong in the object creation in this area…

Thorondor wrote:
Have just looked in the library in Gondolin; - it's a nice set of prices for identity staffs :) - all 1gp. :D

[sound F/X: testing]*blink* …Okay, that's clearly wrong. I'll investigate.

_________________
"Blessed are the yeeks, for they shall inherit Arda..."


Top
 Profile  
 
PostPosted: Mon Mar 30, 2020 3:54 pm 
Offline
Cornac

Joined: Wed Apr 15, 2015 11:59 am
Posts: 44
Thanks Zizzo.
It looks like dig isn't working - at least on granite rock.
- tried the skill, the spell, and a thaumaturgy spell. Nothing works :( Deathwatch
When you manually dig it says that you finish the tunnel but the granite remains. Alas for a set of leather gloves {special}!

<edit> - this also applies to rubble

I think a pile of novice paladins spawned in Death watch; - is that allowed?

There's no major rush for another update unless I manage to break something good and proper...
- would you mind having a look at implementing recharge and dig skills for the next update?

The stacked items thing; - it's on identified arrows. I'll try and report back next time it comes up.

Also I have no idea how to implement the gondolin library addon!
- could you advise :)
Many thanks

<edit> managed to get the gloves via phase door :D

did a lot of shop recharges of a staff of identify:

error = "Game version: tome2-0.4.1\
Addons: town_neutral-0.3.0, landmark-0.2.0\
\
Lua Error: /mod/class/Actor.lua:1761: /data/general/objects/bases.lua:844: attempt to index local 'self' (a nil value)\
At [C]:-1 \
At [C]:-1 error\
At /mod/class/Actor.lua:1761 unload\
At /engine/Game.lua:467 unregisterDialog\
At /mod/dialogs/ShowEquipInvenFloor.lua:74 use\
At /engine/dialogs/ShowEquipInven.lua:49 fct\
At /engine/ui/ListColumns.lua:463 onUse\
At /engine/ui/ListColumns.lua:135 fct\
At /engine/Mouse.lua:71 receiveMouse\
At /engine/Mouse.lua:111 delegate\
At /engine/ui/Dialog.lua:793 mouseEvent\
At /engine/ui/Dialog.lua:508 fct\
At /engine/Mouse.lua:71 "
seen = true
reported = false


Top
 Profile  
 
Display posts from previous:  Sort by  
Post new topic Reply to topic  [ 519 posts ]  Go to page Previous  1 ... 31, 32, 33, 34, 35

All times are UTC


Who is online

Users browsing this forum: No registered users and 2 guests


You cannot post new topics in this forum
You cannot reply to topics in this forum
You cannot edit your posts in this forum
You cannot delete your posts in this forum
You cannot post attachments in this forum

Search for:
Jump to:  
Powered by phpBB® Forum Software © phpBB Group