[1.6b] Swift Shot, Bull Shot

[nsrr]

I mentioned these both on the discord, but just so there is a formal report I'll post it here, too. These are included together because it's the same bug for each. Can't say how long Swift Shot has been bugged, but this only concerns the new Bull Shot in Agility from 1.5.0, not the older one.

Bug: Both talents have a callbackOnMove which reduces the cooldown of the talent itself. Neither callback properly checks that the actor actually moved.

Steps to reproduce: Learn the talent. Position yourself next to an impassable tile(wall). Use the talent. Attempt to move onto the wall. The UI will not update without some input, so mouse over the talent or press the hotkey. You will see the cooldown has decreased. You can repeat this to completely reduce the cooldown to 0 without expending any turn energy.

Fix: Add the following check to the callback:

Code: Select all

 if not (self.x == ox and self.y ==oy) then 

[nsrr]

Bump. Bug still exists for both talents in 1.6b.

[darkgod]

fixed