Carrier doesn't un-learn properly

[Flare]

Start a new Reaver. Race probably doesn't matter, but I used Higher.

Either reach level 8, or use cheat mode. You've gained a level! If you cheated, you gained a lot of levels! Celebrate your accomplishment by admiring your character sheet. It looks great, but you notice that you don't have many resistances. Let's fix that. Close the character sheet.

Open the gain talents screen.

Invest a class point into Carrier. Don't leave the gain talents screen yet - we're just looking.

Carrier looks good, but let's think about it a bit more. Change your mind and take the class point back.

Close the gain talents screen without having spent any points at all.

Now open your character sheet again. Notice anything different? That's right - you've gained 20% resistance to disease. Do this four more times to get complete immunity. Shoot yourself with Virulent Disease to prove that it works. (When you're done, shoot yourself with Drain to recharge Vim.)

Sometime over the next few levels, remember to actually buy the Carrier skill. Because exploitation isn't cool, kids.

I did this on accident with one character, and again on cheat mode to prove that it works. Carrier doesn't take back the resistance when it gets unlearned. I couldn't tell whether the disease spreading effect was also stacking up.

[tiger_eye]

Huh. Good catch. You are indeed correct.

This is easy enough to fix in "game/modules/tome/data/talents/corruptions/reaving-combat.lua", simply change:

Code: Select all

        on_learn = function(self, t)
                self:attr("disease_immune", 0.2 * self:getTalentLevelRaw(t))
        end,
        on_unlearn = function(self, t)
                self:attr("disease_immune", -0.2 * self:getTalentLevelRaw(t))
        end,

to

Code: Select all

        on_learn = function(self, t)
                self:attr("disease_immune", 0.2)
        end,
        on_unlearn = function(self, t)
                self:attr("disease_immune", -0.2)
        end,

[darkgod]

fixed