[b41] Class Pack 1.03

[ne0pets22]

Addon is still not loading. I don't know what I'm doing wrong. Still cramming on Lua, some of the stuff in the documentation interests me.

I've just merged the newest barbarian, and I made a shiny webpage with git pages.

http://davidy22.github.com/classPack/


And again, the repo is: https://github.com/Davidy22/classPack.git

[daftigod]

thanks for your work ne0!

i'm sorry i've been neglecting this, really sorry. i was actually prepping the barbarian for the new class pack version. let me take a stab at it through the day today and i'll see what needs to be changed.

the most problematic change for old classes in the new versions of ToME is (in the birth file)

Code: Select all

getBirthDescriptor("class", "Wilder").descriptor_choices.subclass.Barbarian= "allow"

got changed to

Code: Select all

getBirthDescriptor("class", "Wilder").descriptor_choices.subclass["Barbarian"] = "allow"

other than that, the addon codes in the Actor.lua, Combat.lua, DamageTypes.lua, etc. would have to be reapplied to the newest versions of those files since they've changed significantly since b41.

also, the b41 version of the class pack is flawed like DG pointed out. it actually breaks some talents that pre-exist in the engine. Sooo.. with all that said, i'll get working on this from my end and see what we can get done!

[ne0pets22]

Merged barbarian 0.95.

I did actually notice that line was different in the new barbarian code, and I changed all the other classes too in the previous. That shouldn't have broken anything, I hope. Feel free to fork the github repo and start pushing stuff, I have no idea what changed between tome b41 and now. For some of the seemingly abandoned classes, I'm willing to maintain and balance them in place of their creators. Monk best.

Merge more classes when we get the thing working? I've got my eye on spellsword and faeros in particular.

[daftigod]

yeah, i downloaded the master you've been working on and noticed that you had fixed pretty much everything that was broken. i think that the only problems we have left is in the proper modifications to the superloaded files (Actors, Combat, etc). This will be a pain in the ass for the older classes, except maybe for grayswandir's monk, which properly hooks in without using the rest of the code.

for example, if we wanted to convert the old ranger code for an archery talent that's embedded in Archery.lua, we'd need to do the following:

1. Compare the changes in Dekar's Archery.lua with the original, unaltered, version of Archery.lua from ToME b41.

2. Anything that Dekar changed would have to be placed in the same spot, under the same talent, in the current 1.00 version of Archery.lua.

3. Have to make sure that the code in the new version doesn't break Dekar's old code.

4. Repeat this proess for every addition, in every superloaded file, from every class. Bleeeh.


OR-
we could start superloading properly, by which we strip out the unneeded code, and add hooks in their place. this should make future upgrades to class pack much easier. BUT I can't wrap my head around the process. everytime I try to convert my barbarian code to hooks, it doesn't load. I'm probably doing something wrong, but I can't figure it out. This is my first time playing with any time of code, lua or otherwise, but 'm stubborn enough to keep trying.

ps- I got the spellsword working with the barbarian without any issues. But, I can't get the Ranger to work. I think the updated zip that Dekar posted might be broken, and I can't tell what's causing it.

[Sradac]

Gardener and monk are the two old ones most deserving some new love I think

And the arcane archer was pretty cool too, there was some nice changes planned that I dont think ever made it in.

And the illusionist just for masochist mode heh

[ne0pets22]

Gaddammit, applied dekar's no_reload_break thing, fixed one bug, raised another.

Is there any error reporting in ToME that we can use? Apart from staring at the loading bar and timing it?

Also, could you put the git link in the main post? And mebbe the fancy site too:
https://github.com/Davidy22/classPack.git
http://davidy22.github.com/classPack/

[lukep]

Is there any error reporting in ToME that we can use? Apart from staring at the loading bar and timing it?

Yes, run with --flush std out (or whatever the real command is), or else from the terminal. The error will show up in the log output.

[daftigod]

ok here's what i have so far.

it's the barbarian 0.95 and spellsword-v24 merged, both working in game. they share the same Combat.lua superloaded file. it's not in hook version, which is what i would much rather have. If anyone wouldn't mind taking a look at this to see how it can be improved, especially Actors.lua and Combat.lua!

As far as i can tell all of the talents are working as they should. feel free to upload this version as a base!

[ne0pets22]

Hrm, I'm still trying to get the old version to work with the ranger changes merged. I'm getting /loader/init.lua:148: bad argument #1 to 'setfenv' whenever I try to merge the ranger. I've traced it to local _M = loadPrevious(...) in the actor.lua file, but I have no idea what I'm doing wrong. From init.lua in the ToME source code, it looks like the addon isn't loading properly, and that's causing setfenv to choke on a broken argument. I'm lost from there.

And browsing the spellsword class, holywhat hirumakai works at Caltech? I just applied there! Uh, if you're reading this and you're in any position to influence the admissions office, I really like your class. And your hair. Even though I've never seen it. That's how good your hair is.

[MisiuPysiu]

Hey,

I don't know if the bug is connected to the ClassPack or the Addon itself but in the Spellsword class I can have all 4 stances active at the same time. Its quite OP at the moment. But fun

[daftigod]

oops, sorry about that. it's version 24 of the spellsword, not 26. I think i might know what i did to cause that bug... not Hirumakai's fault!

[wildwolfofdark]

I tried putting this into my 1.0.0 and Spellsword and Barbarian were the only two showing.

[ne0pets22]

That's a version with only barbarian and spellsword merged. Old classpack was old, and we still be getting it to work.

[JerryShaw]

Thank you for working on this. It sounds like it's a lot of work and I truly appreciate it and look forward to a new release.

[wildwolfofdark]

I would love to see a class pack updated to 1.0.0, so if you could please update all the classes soon, I would really appreciate it. I know you're probably busy but thank you for all the work that has gone into this addon, and other addons in the future.