Combat:getDammod:subs hook not used anymore?

[Doctornull]

Code: Select all

   class:bindHook("Combat:getDammod:subs",
		  function(self, combat, dammod, subs)
                       .....
		  end
   )

In the above hook, dammod used to be populated, and modifications to dammod were honored (so I could do stuff with weapon stat mods in my addon).

Now I'm getting nil for dammod and subs, and modifications to dammod aren't being honored by the engine.

What changed?

Is there a replacement callback or hook? I don't see anything near getDammod in Combat.lua

[darkgod]

?? bindHook function always have the same parameters list: (self, data) tah'ts all and that never has changed
What you want is data.dammod, data.subs and so on

[Doctornull]

?? bindHook function always have the same parameters list: (self, data) tah'ts all and that never has changed
What you want is data.dammod, data.subs and so on

Thanks, I'll do that instead!

I wonder why the code appeared to work in previous versions.

[HousePet]

Variable still had values assigned to it outside the scope of its definition maybe?

[Doctornull]

Variable still had values assigned to it outside the scope of its definition maybe?

Ah, something that used to be global turned into better code between then and 1.5.10? Possible, I guess.