[v1.0.4-1.0.5] Enhanced Object Compare

A place to post your add ons and ideas for them

Moderator: Moderator

Message
Author
Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#16 Post by Zizzo »

Pushing out v3b, with a small tweak to work with the finally-relased Enhanced Wield Replace addon.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#17 Post by Zizzo »

Pushing out v3b.1, with a bugfix related to comparing gems in your inventory with gems attached to your golem.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#18 Post by Zizzo »

Pushing out a minor point release v3b.2, to cover a small 1.4.0 change in the description of Manasurge runes. Also, I apparently hadn't implemented <ctrl>-comparison of Frozen Spear runes; that's covered now. We Apologize for the Omission.™
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#19 Post by Zizzo »

Pushing out bugfix release 3b.3, to fix this addon and Enhanced Wield Replace tripping over each other.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#20 Post by Zizzo »

Minor thing, but I just noticed that inscriptions don't get the "press <control> to compare" bit in their description when they're comparable to your current inscriptions. Heck, some users might not even know the addon provides that functionality. Now, normally I wouldn't push out an update for a change that small, but since I'm already making changes to another ZOmnibus component, I'll piggyback on that with release v3c.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#21 Post by Zizzo »

Pushing out v3d, with <ctrl>-comparison support for Embers' implant inscriptions (specifically, medical injectors and steam generators). We Apologize for the Omission.™
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#22 Post by Zizzo »

So, yeah, turns out lower cooldown mod on an injector is good. So we want to highlight a lower cooldown mod as green for good in the comparison. Which we were getting wrong. :oops: v3d.1 fixes this. We Apologize for the Error.™
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#23 Post by Zizzo »

Release 3e adapts to some v1.5.0 changes in the talent description of a few inscriptions (specifically, healing infusions, heroism infusions, biting gale runes and acid wave runes), so that <ctrl>-comparing them with inscriptions on your body will still work. Should be no other change in functionality.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#24 Post by Zizzo »

Remember way back when we added <shift>-cycling through the alchemist golem's equipment? Seems obvious to do the same thing with Writhing Ones' worm that walks; v3f, just released, adds that.
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#25 Post by Zizzo »

Ah, right, obviously when deciding which of the worm that walks' equipment to compare something (say, a one-handed weapon) against, we need to consider whether it can offhand-wield the weapon, not whether the player can. :oops: Fixed in v3f.1, just pushed out. We Apologize for the Inconvenience.™
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#26 Post by Zizzo »

So, turns out I broke a thing in v3f: when <shift>-cycling through inscribed inscriptions to compare with one in your inventory, I was misidentifying inscriptions that were on your body versus inscriptions on the body of your golem or worm that walks (note to self: appending nil to a Lua array is basically a no-op :oops: ). That should be fixed in v3f.2, just pushed out.
"Blessed are the yeeks, for they shall inherit Arda..."

Cathbald
Uruivellas
Posts: 743
Joined: Wed Jan 22, 2014 1:46 pm

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#27 Post by Cathbald »

meant to post this forever : having wintouched speed fucks up the inscription cd comparison. I guess any kind of cd red fucks it up, it just never happens outside of wintouched speed ?

what happens is that i can still compare insc, but while it compare for example duration and speed of move infusion, the cd no longer says either > or < not even =, just nothing appears
I write guides and make addons too now, apparently

You can go here for a compilation of everything I wrote, plus some other important stuff!

Includes general guides (inscriptions, zone, prodigies), and class guides (Demo, Anorithil, Bulwark, Zerker, Sblade)

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#28 Post by Zizzo »

Cathbald wrote:meant to post this forever : having wintouched speed fucks up the inscription cd comparison. I guess any kind of cd red fucks it up, it just never happens outside of wintouched speed ?

what happens is that i can still compare insc, but while it compare for example duration and speed of move infusion, the cd no longer says either > or < not even =, just nothing appears
[sound F/X: source diving] Ah, yes, our modified Object:getDesc() is inappropriately grabbing the cooldown directly out of the inscription data (bypassing Actor:getTalentCooldown(), where the cooldown reduction is applied), and then trying and failing to find its incorrect original cooldown description and replace with its also-incorrect modified description. That's fixed in v3f.3, just released. We Apologize for the Inconvenience.™ :oops:
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#29 Post by Zizzo »

v3g is a compatibility update for the 1.6 release; we track changes to the tooltips of various runes and infusions, and add our comparison functionality to 1.6's new runes and infusions (the non-artifact ones, at least).
"Blessed are the yeeks, for they shall inherit Arda..."

Zizzo
Sher'Tul Godslayer
Posts: 2010
Joined: Thu Jan 23, 2003 8:13 pm
Location: A shallow water area south of Bree
Contact:

Re: [v1.0.4-1.0.5] Enhanced Object Compare

#30 Post by Zizzo »

A Steam user resported a bug which, after some digging, I can only conclude is an incompatibility with the CHN Addons for ToME addon — it appears to be setting the display_name of various inscriptions to strings in places where our object description code is expecting functions. v3g.1 is a best-guess attempt at working around the problem.
"Blessed are the yeeks, for they shall inherit Arda..."

Post Reply