Reaver(+ Corruptor) Tweaks v1.2 - Become a Worm that Walks!

[Razakai]

Yeah, I know that bug. Will fix it shortly.

[Zul]

Yeah, I was a little worried it might be too good on Reaver if it gave the talent failure, and wanted to make it more attractive for Corruptors who otherwise would want to stay out of range. The intent is that it should be a potent source of damage and defence thanks to the stacking DoT and -damage debuff even without talent failure, is that not the case currently?

I did not yet try it on a reaver, it is probably fine. I just really wanted that talent failure.

The thing is that DOT is not very attractive to corruptors, because they usually want to maximize their single target burst, and let Overkill do AOE damage.

What do you think about improving Worm Walk? (I would gladly trade the heal and vim for being able to use it without worms as target.) I guess it will be more useful once you have more possibilities to spawn carrion worms, but at the moment it is not very useful. The worms usually spawn right next to you (until you get Worm Rot), so the blink is kind of wasted.
Also, the heal is kind of redundant, because you will get healed by the killed carrion worm anyway.

[Doctornull]

Got an error when a random boss NPC had some talents from this tree, but not others:

Code: Select all

Lua Error: /engine/interface/GameTargeting.lua:120: /engine/interface/ActorTalents.lua:153: /engine/interface/ActorTalents.lua:615: attempt to index local 't' (a nil value)
stack traceback:
	/engine/interface/ActorTalents.lua:615: in function 'getTalentLevel'
	/data-reaver-tweaks/talents/corruptions/rot.lua:82: in function 'carrionworm'
	/data-reaver-tweaks/talents/corruptions/rot.lua:188: in function 'callTalent'
	/mod/class/Actor.lua:4664: in function </mod/class/Actor.lua:4651>
	/mod/class/Actor.lua:2676: in function 'baseonTakeHit'
	/mod/addons/faerierace/superload/mod/class/Actor.lua:92: in function 'onTakeHit'
	/mod/class/NPC.lua:304: in function 'onTakeHit'
	/mod/class/interface/ActorLife.lua:40: in function 'takeHit'
	/mod/class/Actor.lua:2720: in function 'takeHit'
	/data/damage_types.lua:436: in function 'defaultProjector'
	/data/damage_types.lua:757: in function 'projector'
	/engine/interface/ActorProject.lua:198: in function 'project'
	/data/talents/spells/nightfall.lua:61: in function </data/talents/spells/nightfall.lua:47>
	[C]: in function 'xpcall'
	/engine/interface/ActorTalents.lua:148: in function </engine/interface/ActorTalents.lua:135>
	At [C]:-1 
	At [C]:-1 error
	At /engine/interface/GameTargeting.lua:120 fct
	At /engine/interface/GameTargeting.lua:126 targetMode
	At /engine/interface/GameTargeting.lua:187 
	At /engine/KeyBind.lua:229 

Unfortunately this is due to a core game issue which is that NPCs don't define all self.T_WHATEVER, just the few they think they'll need.

The solution to this sort of thing is to use 'T_MY_TALENT' instead of self.T_MY_TALENT in calls to getTalentLevel() and callTalent().

[grayswandir]

Unfortunately this is due to a core game issue which is that NPCs don't define all self.T_WHATEVER, just the few they think they'll need.

Rather, you have a talent file somewhere with

Code: Select all

local NPC = require("mod.class.NPC")

at the top (for making summons, usually). This forces the NPC class to generate, copying over all the existing talents. Then all the talents defined afterwards don't make it in.

Edit: This is also apparently causing the random inscription bug with arcanum/nulltweaks, so if you could fix that in rot.lua, that'd be appreciated. Just move the require NPC line into the actual talent that needs it, instead of at the top of the file.

[Razakai]

Yeah, I've been trying to merge this into the main git on DG's request so I have a new version with various bugfixes and improvements like making Pestilent Blight T2 and spawn a carrion worm. That's moved the NPC line to the correct location so that ought to fix things, I'll do that shortly.

[Razakai]

Oops, turns out I can't upload the addon as I'm currently visiting family and the copy I have has an invalid md5. Sorry! However this does give me more time to think about balancing it, I think the worm walk spawning a worm or usable without worms is a good idea.

[Doctornull]

Not sure if this is the same bug that's shown up previously. This one was an infinite LUA pop-up spam.

Code: Select all

[PROJECTOR] starting dam	27
[PROJECTOR] after difficulty dam	27
[PROJECTOR] res	0	1	 on dam	27
[PROJECTOR] after resists dam	27
[PROJECTOR] after flat damage armor	27
[PROJECTOR] final dam after static checks	27
Lua Error: /hooks/reaver-tweaks/load.lua:22: attempt to call method 'knowTalent' (a nil value)
	At [C]:-1 knowTalent
	At /hooks/reaver-tweaks/load.lua:22 
	At [string "return function(l, self, data) local ok=false..."]:1 triggerHook
	At /data/damage_types.lua:422 defaultProjector
	At /data/damage_types.lua:733 projector
	At /data/damage_types.lua:2195 projector
	At /data/maps/vaults/paladin-vs-vampire.lua:35 check
	At /engine/Map.lua:762 checkEntity
	At /mod/class/Actor.lua:669 act
	At /mod/class/NPC.lua:54 act
	At /engine/GameEnergyBased.lua:126 tickLevel
	At /engine/GameEnergyBased.lua:62 tick
	At /engine/GameTurnBased.lua:46 tick
	At /mod/class/Game.lua:1185 

[stinkstink]

The uncontrollable nature of carrion worm spawning, the fact that their blight pools damage neutral creatures, and the monolith cultists' tendency to follow you like puppies sure makes for some amusingly unfortunate situations.

[astralInferno]

This was giving me infinite load times when I tried to play a mardrop with it loaded. It worked fine until I tried to enter the slazish fens.

[pyroflare77]

I also had consistent infinite load times with this upon entering Elvara.

[astralInferno]

I grabbed a lua error for my instance of this error.

Loading tile from tileset /data/gfx/shockbolt/invis.png
Loading tile from tileset /data/gfx/shockbolt/npc/humanoid_naga_naga_tidewarden.png
Lua Error: /engine/interface/ActorTalents.lua:373: attempt to index local 't' (a nil value)
At [C]:-1 __index
At /engine/interface/ActorTalents.lua:373 learnTalent
At /mod/class/Actor.lua:4065 learnTalent
At /mod/class/interface/ActorInscriptions.lua:103 setInscription
At /mod/resolvers.lua:671
At /engine/Entity.lua:677 resolve
At /engine/Zone.lua:570 finishEntity
At /engine/Zone.lua:414 makeEntity
At /engine/generator/actor/Random.lua:108 generateOne
At /engine/generator/actor/Random.lua:125 regenFrom
At /engine/generator/actor/Random.lua:47 generate
At /engine/Zone.lua:1008 newLevel
At /engine/Zone.lua:898 getLevel
At /mod/class/Game.lua:928 changeLevelReal
At /mod/class/Game.lua:807 changeLevel
At /mod/class/Game.lua:1834
At /engine/KeyBind.lua:229

Looking into the ActorTalents line, the error seems to be happening on this line:
if t.mode ~= "passive" and not t.no_auto_hotkey and self.hotkey then

t. refers to _M.talents_def[t_id]. And apparently is nil.

So... the game is loading infinitely cause it's trying to teach a talent (an inscription talent?) and not finding it?

Edit: Tried a shaloren and couldn't get into Elvala either. Lua error is nearly identical.

Loading tile store/shop_sign_library.png
Loading tile store/shop_sign_staves.png
Lua Error: /engine/interface/ActorTalents.lua:373: attempt to index local 't' (a nil value)
At [C]:-1 __index
At /engine/interface/ActorTalents.lua:373 learnTalent
At /mod/class/Actor.lua:4065 learnTalent
At /mod/class/interface/ActorInscriptions.lua:103 setInscription
At /mod/resolvers.lua:671
At /engine/Entity.lua:677 resolve
At /engine/Zone.lua:570 finishEntity
At /engine/Zone.lua:414 makeEntity
At /mod/class/generator/actor/Random.lua:44 generateOne
At /engine/generator/actor/Random.lua:125 regenFrom
At /engine/generator/actor/Random.lua:47 generate
At /engine/Zone.lua:1008 newLevel
At /engine/Zone.lua:898 getLevel
At /mod/class/Game.lua:928 changeLevelReal
At /mod/class/Game.lua:807 changeLevel
At /mod/class/Game.lua:1834
At /engine/KeyBind.lua:229

Oh hey, still happens with midnight off.

[HousePet]

The line of:
local NPC = require "mod.class.NPC"
at the top of rot.lua is causing the problems.

[xnd]

+chrono=
a Worm That Walks made out of time worms would be an interesting variant. and it could take enemies into a temporal anomaly (like the fearscape takes you to its place) but packed full of silvery time worms with nasty and strange temporal effects. Instead of burning with each step, worms would crawl on you with each step, with some temporal effects.
Worm That Walks Through Time!

[Razakai]

This is in the main branch now, but unfortunately didn't get in to 1.3 like I hoped. I'll see if I can just make some quick fixes to make it still usable until it goes into the main game.

[astralInferno]

It's going into the main game? Niiiice, congrats!