As subject. It's currently very non-obvious whether a talent runs off effective or raw, and knowing this can have some pretty serious implications for a build.
Is there any way to implement something like this without manually changing every effected talent? If not, does anyone have a list of which talents run off raw? I'd be willing to do the scutwork if I had a list of which talents need the change.
Minor: Display if talent runs off raw or effective tlvl
Moderator: Moderator
-
catwhowalksbyhimself
- Wyrmic
- Posts: 249
- Joined: Sun Aug 15, 2004 1:19 am
- Location: Plainville, CT
Re: Minor: Display if talent runs off raw or effective tlvl
I'm pretty sure this would require manually changing descriptions, or adding a new variable. The former wouldn't be hard to do, just tedious.
"I am the cat that walks by himself. All ways are alike to me."
--Rudyard Kipling, "The Cat That Walked By Himself"
--Rudyard Kipling, "The Cat That Walked By Himself"
Re: Minor: Display if talent runs off raw or effective tlvl
Are there many which run off raw only? I know the Combat Veteran tree does, and I think in its instance it should always be 1.0 effectivity and impossible to boost by any means (or changed to all run off effective talent level).
Re: Minor: Display if talent runs off raw or effective tlvl
A lot of passive talents run off Raw. Otherwise a lot of portions of other talents may run off raw depending on how game breaking it would be for them to run off effective.
So it's not even a simple check for each talent. As an example take Paradox Mastery. The reductions to failure, backfire, and anomaly checks all run off effective as does the buff to static history (because these are calculated on the fly). The temporal resist runs off raw (because this is only calculated once, when you learn the talent).
So if we take that case and change the description it would manually need something like this added at the end; note that the temporal resist bonus is calculated off your raw talent level while the rest of the bonuses use your effective talent level.
It's doable, but a lot of the scrutwork as Frumple put it would be digging through the code and figuring out what works off what. If it's an idea Darkgod likes I'd be willing to help Frumple figure out which talents need adjustment (and by help I mean he can get on IRC with me and if he can't tell just by looking at the talent I'll help him find the answer.) Either way someone is going to need to go through pretty much everything by hand and look for getTalentLevelRaw (which is the easy part, a file search will grab those ones) and talents that don't seem to do anything at all because they take place entirely outside the talent code.
So it's not even a simple check for each talent. As an example take Paradox Mastery. The reductions to failure, backfire, and anomaly checks all run off effective as does the buff to static history (because these are calculated on the fly). The temporal resist runs off raw (because this is only calculated once, when you learn the talent).
So if we take that case and change the description it would manually need something like this added at the end; note that the temporal resist bonus is calculated off your raw talent level while the rest of the bonuses use your effective talent level.
It's doable, but a lot of the scrutwork as Frumple put it would be digging through the code and figuring out what works off what. If it's an idea Darkgod likes I'd be willing to help Frumple figure out which talents need adjustment (and by help I mean he can get on IRC with me and if he can't tell just by looking at the talent I'll help him find the answer.) Either way someone is going to need to go through pretty much everything by hand and look for getTalentLevelRaw (which is the easy part, a file search will grab those ones) and talents that don't seem to do anything at all because they take place entirely outside the talent code.