Solipisism Threshold Not Working on Some Enemies

[Snarvid]

I haven't noted it working, but I have noticed enemies with 0% psi remaining and a listed 0% solipsism threshold not having their speed debuffed. Not sure whether this is an unlisted mechanics change where you can have a 0% solipsism threshold or is a byproduct of enemy skill stacking (was at Solipsism level 10 and that was the only skill in the category.)

[Snarvid]

This is still happening. The talent will list both (paraphrased) “learning this talent will raise the user’s Solipsism threshold by 20%” and immediately after “(currently 0).” Cannot both be right, and I’ve not noticed them getting the debuff even at very low psi so it appears the latter is correct.

[snj]

The computer occasionally ignores other game mechanics, the details of which I can't remember right now. It's possible that solipsism threshold is intentionally disabled for mobs. A person who could look at the code (which, I guess, is anyone) could possibly make this an educated guess.

[Snarvid]

It used to work on enemies pre 1.6.

[starsapphire]

I will guess that would be a side effect of commit https://git.net-core.org/tome/t-engine4 ... 8d88b7bc0e, an attempt to fix another bug http://forums.te4.org/viewtopic.php?f=42&t=50159 that would cause negative HP on adventurer.

In pre 1.6, constantly learn and unlearn solipsism on level up dialog will decrease your HP, eventually reach negative HP.

To avoid that abuse on adventurer, this commit seem to set that it only recalculate the stat changes after you close level up dialog (on_levelup_close) to turn off this abuse as a player.

However, two things needs to be checked:
1. The code checked

Code: Select all

if self:getTalentLevelRaw(t) == 1 then

, so would it work correctly if I level up multiple level solipsism at once, skipping the level 1?
2. If on_levelup_close will not trigger completely for NPC.

Any of the two bug above will cause NPC have 0 solipsism threshold.

I will check it in game tomorrow if possible.

UPDATES:
Confirmed [1], the code here is not right.
For adventurer, you may completely skip the solipsism thresold gain if you directly get 2 level of solipsism.
[2] is not right, it would trigger by NPC.

There is a screenshot taken in Heart of the gloom to demonstrate the code misaction on enemies, giving 40 solipsism thresold.