[Ember 1.0.3] Arcane Shield not triggering with HealingSalve

Message

Relic · #1 Post by **Relic** » Fri Jul 22, 2016 4:34 am

Arcane Shield talent says it triggers on a direct heal. Tinker Healing Salve heals ### health just like the healing inscriptions. The Tinker Healing Salve didn't trigger arcane shield to make a shield as the talent describes.

Effigy · #2 Post by **Effigy** » Fri Jul 22, 2016 4:52 am

I wonder if it's related to this bit from /data/general/objects/tinkers/therapeutics.lua:line 36

Code: Select all

	resolvers.medical_salves("heal %d", 15, function(self, who)
		self:attr("allow_on_heal", 1)
		who:heal(self:getCharmPower(who), who)
		self:attr("allow_on_heal", -1)

I don't know what the difference is between "self" and "who" in this context, but maybe allow_on_heal should be getting set on who instead of self.

HousePet · #3 Post by **HousePet** » Fri Jul 22, 2016 8:47 am

Yep, that is wrong.

#4 Post by **Stuntofthelitter** » Fri Jul 22, 2016 8:58 am

Yup, that's it. I fixed it a week or so ago when the revelation came up.

Zeyphor · #5 Post by **Zeyphor** » Fri Jul 22, 2016 11:00 pm

Stuntofthelitter wrote:Yup, that's it. I fixed it a week or so ago when the revelation came up.

was the comparable bug with fungal growth fixed too?

#6 Post by **Stuntofthelitter** » Sat Jul 23, 2016 1:15 am

Not a problem with either fungal growth or arcane shield, but an issue in what the salve was doing. So yes, it will correct the issue in both cases.

ToME: the Tales of Maj'Eyal

[Ember 1.0.3] Arcane Shield not triggering with HealingSalve

[Ember 1.0.3] Arcane Shield not triggering with HealingSalve

Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS

Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS

Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS

Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS

Re: [Ember 1.0.3] Arcane Shield not triggering with HealingS