Offhand mindstar ignores skill damage multipliers

[visage]

It's intended and expected that mindstars ignore the offhand damage penalty.

What I didn't expect is that offhand mindstars ignore damage multipliers. Attack with Ice Claw and the offhand ice damage isn't multiplied by 2.3 for the 230% damage multiplier on that skill. Attack with Frenzy, and the offhand damage isn't reduced by whatever the current multiplier on Frenzy is. Mainhand mindstars work normally with skill damage multipliers.

This is not intended behavior, is it?

[visage]

Looking through the code, I suspect that the correct behavior would be for getOffHandMult() to check no_offhand_penalty at the beginning of the function rather than at the end.

Does that seem right?

[HousePet]

I had thought this had been dealt with.

[visage]

Looks like no change for this made it into 1.4.7.

Am I correct in thinking that the correct fix is to insert after line 1736 of Combat.lua:

Code: Select all

if combat and combat.no_offhand_penalty then return mult or 1 end

[Zeyphor]

Looks like no change for this made it into 1.4.7.

Am I correct in thinking that the correct fix is to insert after line 1736 of Combat.lua:

Code: Select all

if combat and combat.no_offhand_penalty then return mult or 1 end

based entirely off of only that line, how would it know whether to return mult or 1? you'd want something to tell it to return the higher value too

[visage]

Looks like no change for this made it into 1.4.7.

Am I correct in thinking that the correct fix is to insert after line 1736 of Combat.lua:

Code: Select all

if combat and combat.no_offhand_penalty then return mult or 1 end

based entirely off of only that line, how would it know whether to return mult or 1? you'd want something to tell it to return the higher value too

I disagree. If you attack with (fully-leveled) Quake and a mindstar in the offhand, that offhand should do 210% damage, not 100% damage. The construction of the line mirrors line 1736, which establishes that there's no offhand penalty for ranged weapons -- similarly, mindstars should have no offhand penalty.

[visage]

...and it looks like it now works in 1.4.8.

Yay, my Wyrmic now does the damage they're supposed to! Boo, my Cursed now does the damage they're supposed to!