1.1.3 can't upload addon from within the game

Where bugs go to lie down and rest

Moderator: Moderator

Post Reply
Message
Author
Doctornull
Sher'Tul Godslayer
Posts: 2402
Joined: Tue Jun 18, 2013 10:46 pm
Location: Ambush!

1.1.3 can't upload addon from within the game

#1 Post by Doctornull »

This new addon:
http://te4.org/games/addons/tome/new-gems

Was forked from this old addon:
http://te4.org/games/addons/tome/new-ge ... ystal-race

The old addon is abandoned and will not be updated, but it seems to be blocking my ability to upload the new addon from within the game -- when I try to upload the new addon, the upload fails with the message "you don't own this addon".


Since addons tend to be open source, it's pretty reasonable to assume forking will happen more than just this one time, so I think it would be better for the uploader to check the pair (addon-shortname, developer-name) rather than just the single string (addon-shortname).
Check out my addons: Nullpack (classes), Null Tweaks (items & talents), and New Gems fork.

darkgod
Master of Eyal
Posts: 10751
Joined: Wed Jul 24, 2002 9:26 pm
Location: Angolwen
Contact:

Re: 1.1.3 can't upload addon from within the game

#2 Post by darkgod »

Nope, not a bug, short_name has to be unique, for many reasons
[tome] joylove: You can't just release an expansion like one would release a Kraken XD
--
[tome] phantomfrettchen: your ability not to tease anyone is simply stunning ;)

Doctornull
Sher'Tul Godslayer
Posts: 2402
Joined: Tue Jun 18, 2013 10:46 pm
Location: Ambush!

Re: 1.1.3 can't upload addon from within the game

#3 Post by Doctornull »

darkgod wrote:Nope, not a bug, short_name has to be unique, for many reasons
I'm able to upload to te4.org manually, but not within the game.

At least one of these is a bug ;)

Still, I think it's short-sighted to rely on short_name alone rather than the pair (short_name, developer_name). Since addons tend to be open source, it's pretty reasonable to assume forking will happen more than just this one time. Why screw over everyone who tries to fork an addon?
Check out my addons: Nullpack (classes), Null Tweaks (items & talents), and New Gems fork.

darkgod
Master of Eyal
Posts: 10751
Joined: Wed Jul 24, 2002 9:26 pm
Location: Angolwen
Contact:

Re: 1.1.3 can't upload addon from within the game

#4 Post by darkgod »

Yeah te4.org is the bug :)

And no, it doesnt screw anybody; it's your fork, so it's your addon, it should have a unique name
[tome] joylove: You can't just release an expansion like one would release a Kraken XD
--
[tome] phantomfrettchen: your ability not to tease anyone is simply stunning ;)

Doctornull
Sher'Tul Godslayer
Posts: 2402
Joined: Tue Jun 18, 2013 10:46 pm
Location: Ambush!

Re: 1.1.3 can't upload addon from within the game

#5 Post by Doctornull »

darkgod wrote:Yeah te4.org is the bug :)

And no, it doesnt screw anybody; it's your fork, so it's your addon, it should have a unique name
The old one is abandoned: could you delete that, so mine (the new, active one) will upload?

Thanks!
Check out my addons: Nullpack (classes), Null Tweaks (items & talents), and New Gems fork.

darkgod
Master of Eyal
Posts: 10751
Joined: Wed Jul 24, 2002 9:26 pm
Location: Angolwen
Contact:

Re: 1.1.3 can't upload addon from within the game

#6 Post by darkgod »

Nope, things will break if data disappear. Just rename the short_name.
I can make the old one hidden though
[tome] joylove: You can't just release an expansion like one would release a Kraken XD
--
[tome] phantomfrettchen: your ability not to tease anyone is simply stunning ;)

Doctornull
Sher'Tul Godslayer
Posts: 2402
Joined: Tue Jun 18, 2013 10:46 pm
Location: Ambush!

Re: 1.1.3 can't upload addon from within the game

#7 Post by Doctornull »

darkgod wrote:Nope, things will break if data disappear. Just rename the short_name.
I can make the old one hidden though
What will break if the new one's short_name no longer matches its previous version?

Can you re-name the old one's short_name?
Check out my addons: Nullpack (classes), Null Tweaks (items & talents), and New Gems fork.

darkgod
Master of Eyal
Posts: 10751
Joined: Wed Jul 24, 2002 9:26 pm
Location: Angolwen
Contact:

Re: 1.1.3 can't upload addon from within the game

#8 Post by darkgod »

You don't understand, the shortname is the unique id of an addon. They can not change. I'm not sure why you want so much to use the old shortname ?? Just use a new one
[tome] joylove: You can't just release an expansion like one would release a Kraken XD
--
[tome] phantomfrettchen: your ability not to tease anyone is simply stunning ;)

Doctornull
Sher'Tul Godslayer
Posts: 2402
Joined: Tue Jun 18, 2013 10:46 pm
Location: Ambush!

Re: 1.1.3 can't upload addon from within the game

#9 Post by Doctornull »

darkgod wrote:You don't understand, the shortname is the unique id of an addon. They can not change. I'm not sure why you want so much to use the old shortname ?? Just use a new one
Because I've already got ~10 releases on the page with that old name.

It's going to be annoying for everyone who uses the addon.

Not a huge problem for me, but kinda needlessly frustrating for everyone else. :-/
Check out my addons: Nullpack (classes), Null Tweaks (items & talents), and New Gems fork.

StarKeep
Uruivellas
Posts: 703
Joined: Sun Feb 03, 2013 12:29 am
Location: Turtlemire

Re: 1.1.3 can't upload addon from within the game

#10 Post by StarKeep »

Best to get into the hang of doing it the right way earlier than later.
I had the same issue with Faerie, but everybody found the new addon post easy enough by me redirecting the main forum post, and adding a new forum post to the thread saying why I had to switch over.
<mex> have you heard the good word about archmage?
<mex> I'm here to tell you about your lord and savior shalore archmage
<mex> have you repented your bulwark sins yet?
<mex> cornac shall inherit the Eyal

Post Reply