[b34] targeting bug

[lukep]

It is still possible to manually aim to hit tiles that are obstructed by walls. One example:

Code: Select all

.....X
....m.
...#..
@.....

You cannot hit the monster ("m") by aiming at it, but you can by aiming at "X".

[yufra]

Yes, this is an old bug and to be honest I don't know how you would suggest fixing it. I believe the problem is that targeting tries to aim from the middle of @ to the middle of m or X. @-to-m is thus blocked, but the line that goes from @-to-X does enter the tile containing m. If that is true, what would you propose?

[lukep]

Make targeting check if aiming several spaces diagonally different would change anything? I don't really know how targeting code works, so I can't add much here.

[tiger_eye]

Yup, this should already be fixed for b35. One of the conditional statements for "smart lines" introduced in b34 was totally whack (it worked half the time), and I was hoping b35 would be released before this particular issue was revealed . Thanks for reporting it though, lukep, and I'll double-check the configuration you posted just to make sure.